From de2ae19cf6048efc38d47af09831e1786db4ee0a Mon Sep 17 00:00:00 2001 From: Anna Zaks Date: Thu, 6 Jun 2013 22:32:11 +0000 Subject: [analyzer] Address Jordan’s code review for r183451 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit llvm-svn: 183455 --- clang/lib/StaticAnalyzer/Core/BugReporter.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'clang/lib/StaticAnalyzer') diff --git a/clang/lib/StaticAnalyzer/Core/BugReporter.cpp b/clang/lib/StaticAnalyzer/Core/BugReporter.cpp index e3f43854d63..e93bb3fce5e 100644 --- a/clang/lib/StaticAnalyzer/Core/BugReporter.cpp +++ b/clang/lib/StaticAnalyzer/Core/BugReporter.cpp @@ -248,7 +248,7 @@ static void adjustCallLocations(PathPieces &Pieces, /// We might have pieces with invalid locations as a result of inlining Body /// Farm generated functions. static void removePiecesWithInvalidLocations(PathPieces &Pieces) { - for (PathPieces::iterator I = Pieces.begin(), E = Pieces.end(); I != E; ++I) { + for (PathPieces::iterator I = Pieces.begin(), E = Pieces.end(); I != E;) { if (PathDiagnosticCallPiece *C = dyn_cast(*I)) removePiecesWithInvalidLocations(C->path); @@ -257,10 +257,10 @@ static void removePiecesWithInvalidLocations(PathPieces &Pieces) { if (!(*I)->getLocation().isValid() || !(*I)->getLocation().asLocation().isValid()) { - Pieces.erase(I); + I = Pieces.erase(I); continue; } - + I++; } } -- cgit v1.2.3