From 604d0bbba579e934a10609a4f9cea85170337750 Mon Sep 17 00:00:00 2001 From: Jordan Rose Date: Sat, 23 Mar 2013 01:21:20 +0000 Subject: Add reverseComparisonOp and negateComparisonOp to BinaryOperator. ...and adopt them in the analyzer. llvm-svn: 177802 --- .../lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) (limited to 'clang/lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp') diff --git a/clang/lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp b/clang/lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp index 86940a1e844..d87c51fed35 100644 --- a/clang/lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp +++ b/clang/lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp @@ -124,21 +124,6 @@ ProgramStateRef SimpleConstraintManager::assume(ProgramStateRef state, return state; } -static BinaryOperator::Opcode NegateComparison(BinaryOperator::Opcode op) { - // FIXME: This should probably be part of BinaryOperator, since this isn't - // the only place it's used. (This code was copied from SimpleSValBuilder.cpp.) - switch (op) { - default: - llvm_unreachable("Invalid opcode."); - case BO_LT: return BO_GE; - case BO_GT: return BO_LE; - case BO_LE: return BO_GT; - case BO_GE: return BO_LT; - case BO_EQ: return BO_NE; - case BO_NE: return BO_EQ; - } -} - ProgramStateRef SimpleConstraintManager::assumeAuxForSymbol(ProgramStateRef State, @@ -189,7 +174,7 @@ ProgramStateRef SimpleConstraintManager::assumeAux(ProgramStateRef state, BinaryOperator::Opcode op = SE->getOpcode(); if (BinaryOperator::isComparisonOp(op)) { if (!Assumption) - op = NegateComparison(op); + op = BinaryOperator::negateComparisonOp(op); return assumeSymRel(state, SE->getLHS(), op, SE->getRHS()); } -- cgit v1.2.3