From fcd016e57ec6b1a24df7999e062ec2d2198fb69f Mon Sep 17 00:00:00 2001 From: Jordan Rose Date: Mon, 30 Jul 2012 20:22:09 +0000 Subject: [analyzer] Only allow CallEvents to be created by CallEventManager. This ensures that it is valid to reference-count any CallEvents, and we won't accidentally try to reclaim a CallEvent that lives on the stack. It also hides an ugly switch statement for handling CallExprs! There should be no functionality change here. llvm-svn: 160986 --- clang/lib/StaticAnalyzer/Core/CheckerManager.cpp | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) (limited to 'clang/lib/StaticAnalyzer/Core/CheckerManager.cpp') diff --git a/clang/lib/StaticAnalyzer/Core/CheckerManager.cpp b/clang/lib/StaticAnalyzer/Core/CheckerManager.cpp index 5e3ce7a72dc..e1d6a261932 100644 --- a/clang/lib/StaticAnalyzer/Core/CheckerManager.cpp +++ b/clang/lib/StaticAnalyzer/Core/CheckerManager.cpp @@ -192,15 +192,10 @@ namespace { void runChecker(CheckerManager::CheckObjCMessageFunc checkFn, NodeBuilder &Bldr, ExplodedNode *Pred) { - ProgramPoint::Kind K = IsPreVisit ? ProgramPoint::PreStmtKind : - ProgramPoint::PostStmtKind; - const ProgramPoint &L = - ProgramPoint::getProgramPoint(Msg.getOriginExpr(), - K, Pred->getLocationContext(), - checkFn.Checker); + const ProgramPoint &L = Msg.getProgramPoint(IsPreVisit,checkFn.Checker); CheckerContext C(Bldr, Eng, Pred, L); - checkFn(Msg, C); + checkFn(*Msg.cloneWithState(Pred->getState()), C); } }; } @@ -237,10 +232,10 @@ namespace { void runChecker(CheckerManager::CheckCallFunc checkFn, NodeBuilder &Bldr, ExplodedNode *Pred) { - const ProgramPoint &L = Call.getProgramPoint(IsPreVisit, checkFn.Checker); + const ProgramPoint &L = Call.getProgramPoint(IsPreVisit,checkFn.Checker); CheckerContext C(Bldr, Eng, Pred, L); - checkFn(Call, C); + checkFn(*Call.cloneWithState(Pred->getState()), C); } }; } -- cgit v1.2.3