From ef5c554df49a27da18e8c04eab2ec16170108a76 Mon Sep 17 00:00:00 2001 From: Ted Kremenek Date: Wed, 29 Feb 2012 06:05:28 +0000 Subject: [analyzer] Tweak the UnreachableCode checker to not warning about unreachable default blocks. Patch by Cyril Roelandt! llvm-svn: 151709 --- clang/lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'clang/lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp') diff --git a/clang/lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp index 2b550df2b93..8ac785ce7df 100644 --- a/clang/lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp @@ -116,6 +116,14 @@ void UnreachableCodeChecker::checkEndAnalysis(ExplodedGraph &G, if (CB->size() > 0 && isInvalidPath(CB, *PM)) continue; + // It is good practice to always have a "default" label in a "switch", even + // if we should never get there. It can be used to detect errors, for + // instance. Unreachable code directly under a "default" label is therefore + // likely to be a false positive. + if (const Stmt *label = CB->getLabel()) + if (label->getStmtClass() == Stmt::DefaultStmtClass) + continue; + // Special case for __builtin_unreachable. // FIXME: This should be extended to include other unreachable markers, // such as llvm_unreachable. -- cgit v1.2.3