From 09c6b509fec80977fe35984779ffd83669b97b0f Mon Sep 17 00:00:00 2001 From: George Karpenkov Date: Wed, 22 Aug 2018 23:17:02 +0000 Subject: [analyzer] Track the problematic subexpression in UndefResultChecker This is tested in a subsequent commit, which allows tracking those values. Differential Revision: https://reviews.llvm.org/D51139 llvm-svn: 340474 --- clang/lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'clang/lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp') diff --git a/clang/lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp index b9a93bedca2..bbf3215e4db 100644 --- a/clang/lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp @@ -122,6 +122,7 @@ void UndefResultChecker::checkPostStmt(const BinaryOperator *B, << ((B->getOpcode() == BinaryOperatorKind::BO_Shl) ? "left" : "right") << " shift is undefined because the right operand is negative"; + Ex = B->getRHS(); } else if ((B->getOpcode() == BinaryOperatorKind::BO_Shl || B->getOpcode() == BinaryOperatorKind::BO_Shr) && isShiftOverflow(B, C)) { @@ -130,6 +131,7 @@ void UndefResultChecker::checkPostStmt(const BinaryOperator *B, << ((B->getOpcode() == BinaryOperatorKind::BO_Shl) ? "left" : "right") << " shift is undefined due to shifting by "; + Ex = B->getRHS(); SValBuilder &SB = C.getSValBuilder(); const llvm::APSInt *I = @@ -147,6 +149,7 @@ void UndefResultChecker::checkPostStmt(const BinaryOperator *B, C.isNegative(B->getLHS())) { OS << "The result of the left shift is undefined because the left " "operand is negative"; + Ex = B->getLHS(); } else if (B->getOpcode() == BinaryOperatorKind::BO_Shl && isLeftShiftResultUnrepresentable(B, C)) { ProgramStateRef State = C.getState(); @@ -160,6 +163,7 @@ void UndefResultChecker::checkPostStmt(const BinaryOperator *B, << "\', which is unrepresentable in the unsigned version of " << "the return type \'" << B->getLHS()->getType().getAsString() << "\'"; + Ex = B->getLHS(); } else { OS << "The result of the '" << BinaryOperator::getOpcodeStr(B->getOpcode()) -- cgit v1.2.3