From 088b1c9cdcdb3d83fa730c1fcbae6db8252fe76d Mon Sep 17 00:00:00 2001 From: Kristof Umann Date: Mon, 4 Mar 2019 00:28:16 +0000 Subject: [analyzer] Enable subcheckers to possess checker options Under the term "subchecker", I mean checkers that do not have a checker class on their own, like unix.MallocChecker to unix.DynamicMemoryModeling. Since a checker object was required in order to retrieve checker options, subcheckers couldn't possess options on their own. This patch is also an excuse to change the argument order of getChecker*Option, it always bothered me, now it resembles the actual command line argument (checkername:option=value). Differential Revision: https://reviews.llvm.org/D57579 llvm-svn: 355297 --- clang/lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'clang/lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp') diff --git a/clang/lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp index 76103f81a68..cb7ba73a091 100644 --- a/clang/lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp @@ -1397,8 +1397,8 @@ void ento::registerNonLocalizedStringChecker(CheckerManager &mgr) { NonLocalizedStringChecker *checker = mgr.registerChecker(); checker->IsAggressive = - mgr.getAnalyzerOptions().getCheckerBooleanOption("AggressiveReport", - false, checker); + mgr.getAnalyzerOptions().getCheckerBooleanOption( + checker, "AggressiveReport", false); } bool ento::shouldRegisterNonLocalizedStringChecker(const LangOptions &LO) { @@ -1409,7 +1409,8 @@ void ento::registerEmptyLocalizationContextChecker(CheckerManager &mgr) { mgr.registerChecker(); } -bool ento::shouldRegisterEmptyLocalizationContextChecker(const LangOptions &LO) { +bool ento::shouldRegisterEmptyLocalizationContextChecker( + const LangOptions &LO) { return true; } -- cgit v1.2.3