From 91f61fc921e4abcaeb4a85b4e52f1db0cbdf2468 Mon Sep 17 00:00:00 2001 From: John McCall Date: Tue, 26 Jan 2010 06:04:06 +0000 Subject: Allow ADL to find functions imported by using decls. Leave wordy comment about interaction between ADL and default arguments. Shrug shoulders, commit. llvm-svn: 94524 --- clang/lib/Sema/SemaOverload.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'clang/lib/Sema/SemaOverload.cpp') diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp index 54db885e23b..a4c11b077a2 100644 --- a/clang/lib/Sema/SemaOverload.cpp +++ b/clang/lib/Sema/SemaOverload.cpp @@ -4133,8 +4133,13 @@ Sema::AddArgumentDependentLookupCandidates(DeclarationName Name, bool PartialOverloading) { ADLFunctionSet Functions; - // FIXME: Should we be trafficking in canonical function decls throughout? - + // FIXME: This approach for uniquing ADL results (and removing + // redundant candidates from the set) relies on pointer-equality, + // which means we need to key off the canonical decl. However, + // always going back to the canonical decl might not get us the + // right set of default arguments. What default arguments are + // we supposed to consider on ADL candidates, anyway? + // FIXME: Pass in the explicit template arguments? ArgumentDependentLookup(Name, Operator, Args, NumArgs, Functions); -- cgit v1.2.3