From 9a881019a597d218f838fb1e2b92fba19258a5bd Mon Sep 17 00:00:00 2001 From: Fariborz Jahanian Date: Wed, 13 Jul 2011 19:05:43 +0000 Subject: With -Wselector, don't warn about unimplemented optional method used in @selector expression because, well, their implementation is optional. // rdar://9545564 llvm-svn: 135057 --- clang/lib/Sema/SemaExprObjC.cpp | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'clang/lib/Sema/SemaExprObjC.cpp') diff --git a/clang/lib/Sema/SemaExprObjC.cpp b/clang/lib/Sema/SemaExprObjC.cpp index 3df6d3f96e4..02a4682cc84 100644 --- a/clang/lib/Sema/SemaExprObjC.cpp +++ b/clang/lib/Sema/SemaExprObjC.cpp @@ -178,11 +178,14 @@ ExprResult Sema::ParseObjCSelectorExpression(Selector Sel, SourceRange(LParenLoc, RParenLoc)); if (!Method) Diag(SelLoc, diag::warn_undeclared_selector) << Sel; - - llvm::DenseMap::iterator Pos - = ReferencedSelectors.find(Sel); - if (Pos == ReferencedSelectors.end()) - ReferencedSelectors.insert(std::make_pair(Sel, SelLoc)); + + if (!Method || + Method->getImplementationControl() != ObjCMethodDecl::Optional) { + llvm::DenseMap::iterator Pos + = ReferencedSelectors.find(Sel); + if (Pos == ReferencedSelectors.end()) + ReferencedSelectors.insert(std::make_pair(Sel, SelLoc)); + } // In ARC, forbid the user from using @selector for // retain/release/autorelease/dealloc/retainCount. -- cgit v1.2.3