From 4eda2c00861cfdbc20b64b623a8fa32f03cbe699 Mon Sep 17 00:00:00 2001 From: Fariborz Jahanian Date: Fri, 15 Aug 2014 17:39:00 +0000 Subject: Objective-C. Do not warn if user is using property-dox syntax to name a user provided setter name (as declared in @property attribute declaration). rdar://18022762 llvm-svn: 215736 --- clang/lib/Sema/SemaExprObjC.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'clang/lib/Sema/SemaExprObjC.cpp') diff --git a/clang/lib/Sema/SemaExprObjC.cpp b/clang/lib/Sema/SemaExprObjC.cpp index 0facca03915..39598b5a19a 100644 --- a/clang/lib/Sema/SemaExprObjC.cpp +++ b/clang/lib/Sema/SemaExprObjC.cpp @@ -1708,11 +1708,15 @@ HandleExprPropertyRefExpr(const ObjCObjectPointerType *OPT, // name 'x'. if (Setter && Setter->isImplicit() && Setter->isPropertyAccessor() && !IFace->FindPropertyDeclaration(Member)) { - if (const ObjCPropertyDecl *PDecl = Setter->findPropertyDecl()) + if (const ObjCPropertyDecl *PDecl = Setter->findPropertyDecl()) { + // Do not warn if user is using property-dot syntax to make call to + // user named setter. + if (!(PDecl->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_setter)) Diag(MemberLoc, diag::warn_property_access_suggest) << MemberName << QualType(OPT, 0) << PDecl->getName() << FixItHint::CreateReplacement(MemberLoc, PDecl->getName()); + } } if (Getter || Setter) { -- cgit v1.2.3