From 4a82d815de070537545538ac1fbfaafa48cb97bf Mon Sep 17 00:00:00 2001 From: Steve Naroff Date: Tue, 30 Sep 2008 14:38:43 +0000 Subject: Fix [sema] Objective-C method lookup (at global scope) fails to handle overloaded selectors properly. Long standing bug in Sema::ActOnInstanceMessage(). We now warn when messaging an "id" with multiple method signatures in scope. The diags are a little verbose, however they can be streamlined if necessary. llvm-svn: 56843 --- clang/lib/Sema/SemaDeclObjC.cpp | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'clang/lib/Sema/SemaDeclObjC.cpp') diff --git a/clang/lib/Sema/SemaDeclObjC.cpp b/clang/lib/Sema/SemaDeclObjC.cpp index f98eeb61125..05c3bc78b31 100644 --- a/clang/lib/Sema/SemaDeclObjC.cpp +++ b/clang/lib/Sema/SemaDeclObjC.cpp @@ -776,6 +776,21 @@ void Sema::AddInstanceMethodToGlobalPool(ObjCMethodDecl *Method) { } } +ObjCMethodDecl *Sema::LookupInstanceMethodInGlobalPool(Selector Sel, + SourceRange R) { + ObjCMethodList &MethList = InstanceMethodPool[Sel]; + + if (MethList.Method && MethList.Next) { + Diag(R.getBegin(), diag::warn_multiple_method_decl, Sel.getName(), R); + Diag(MethList.Method->getLocStart(), diag::warn_using_decl, + MethList.Method->getSourceRange()); + for (ObjCMethodList *Next = MethList.Next; Next; Next = Next->Next) + Diag(Next->Method->getLocStart(), diag::warn_also_found_decl, + Next->Method->getSourceRange()); + } + return MethList.Method; +} + void Sema::AddFactoryMethodToGlobalPool(ObjCMethodDecl *Method) { ObjCMethodList &FirstMethod = FactoryMethodPool[Method->getSelector()]; if (!FirstMethod.Method) { -- cgit v1.2.3