From da7c4ba1af98430eb16468d2cf211473a3be175e Mon Sep 17 00:00:00 2001 From: Richard Smith Date: Wed, 8 Feb 2012 06:14:53 +0000 Subject: Implement the agreed resolution to DR1457: a signed left shift of a 1 bit into the sign bit doesn't have undefined behavior, but a signed left shift of a 1 bit out of the sign bit still does. As promised to Howard :) The suppression of the potential constant expression checking in system headers is also removed, since the problem it was working around is gone. llvm-svn: 150059 --- clang/lib/Sema/SemaDeclCXX.cpp | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) (limited to 'clang/lib/Sema/SemaDeclCXX.cpp') diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp index 2c1642361b8..ca64af644f6 100644 --- a/clang/lib/Sema/SemaDeclCXX.cpp +++ b/clang/lib/Sema/SemaDeclCXX.cpp @@ -984,13 +984,8 @@ bool Sema::CheckConstexprFunctionBody(const FunctionDecl *Dcl, Stmt *Body, // C++11 [dcl.constexpr]p4: // - every constructor involved in initializing non-static data members and // base class sub-objects shall be a constexpr constructor. - // - // FIXME: We currently disable this check inside system headers, to work - // around early STL implementations which contain constexpr functions which - // can't produce constant expressions. llvm::SmallVector Diags; - if (!Context.getSourceManager().isInSystemHeader(Dcl->getLocation()) && - !IsInstantiation && !Expr::isPotentialConstantExpr(Dcl, Diags)) { + if (!IsInstantiation && !Expr::isPotentialConstantExpr(Dcl, Diags)) { Diag(Dcl->getLocation(), diag::err_constexpr_function_never_constant_expr) << isa(Dcl); for (size_t I = 0, N = Diags.size(); I != N; ++I) -- cgit v1.2.3