From 8b0f4ff317be790b964821fd1ab854e3398dcc0c Mon Sep 17 00:00:00 2001 From: John McCall Date: Mon, 2 Aug 2010 21:13:48 +0000 Subject: Further adjustments to -Wglobal-constructors; works for references and direct initializations now. llvm-svn: 110063 --- clang/lib/Sema/SemaDeclCXX.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'clang/lib/Sema/SemaDeclCXX.cpp') diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp index a0bc5840cdb..5677b5c9933 100644 --- a/clang/lib/Sema/SemaDeclCXX.cpp +++ b/clang/lib/Sema/SemaDeclCXX.cpp @@ -5461,6 +5461,14 @@ void Sema::AddCXXDirectInitializerToDecl(DeclPtrTy Dcl, VDecl->setInit(Result.takeAs()); VDecl->setCXXDirectInitializer(true); + if (!VDecl->isInvalidDecl() && + !VDecl->getDeclContext()->isDependentContext() && + VDecl->hasGlobalStorage() && + !VDecl->getInit()->isConstantInitializer(Context, + VDecl->getType()->isReferenceType())) + Diag(VDecl->getLocation(), diag::warn_global_constructor) + << VDecl->getInit()->getSourceRange(); + if (const RecordType *Record = VDecl->getType()->getAs()) FinalizeVarWithDestructor(VDecl, Record); } -- cgit v1.2.3