From 39ab743e59634dfda9a936f7bc0fa99e1aba2326 Mon Sep 17 00:00:00 2001 From: Chad Rosier Date: Fri, 26 Aug 2011 21:28:44 +0000 Subject: [driver] When generating temporary files allow a prefix to be added. In many cases we want the prefix to be the original file name less the suffix. For an input such as test.c to named temporary would be something like test-3O4Clq.o Part of llvm-svn: 138662 --- clang/lib/Driver/Driver.cpp | 22 +++++++++++++++++----- clang/lib/Driver/Tools.cpp | 4 ++-- 2 files changed, 19 insertions(+), 7 deletions(-) (limited to 'clang/lib/Driver') diff --git a/clang/lib/Driver/Driver.cpp b/clang/lib/Driver/Driver.cpp index 2baed75e0c1..acdfdc21a25 100644 --- a/clang/lib/Driver/Driver.cpp +++ b/clang/lib/Driver/Driver.cpp @@ -1335,6 +1335,15 @@ void Driver::BuildJobsForAction(Compilation &C, } } +// Strip the directory and suffix from BaseInput. +static const char *getBaseName (const char *BaseInput) { + std::pair Split = StringRef(BaseInput).rsplit('/'); + if (Split.second != "") + return Split.second.split('.').first.str().c_str(); + else + return Split.first.split('.').first.str().c_str(); +} + const char *Driver::GetNamedOutputPath(Compilation &C, const JobAction &JA, const char *BaseInput, @@ -1355,7 +1364,8 @@ const char *Driver::GetNamedOutputPath(Compilation &C, if ((!AtTopLevel && !C.getArgs().hasArg(options::OPT_save_temps)) || CCGenDiagnostics) { std::string TmpName = - GetTemporaryPath(types::getTypeTempSuffix(JA.getType())); + GetTemporaryPath(getBaseName(BaseInput), + types::getTypeTempSuffix(JA.getType())); return C.addTempFile(C.getArgs().MakeArgString(TmpName.c_str())); } @@ -1388,9 +1398,10 @@ const char *Driver::GetNamedOutputPath(Compilation &C, // If we're saving temps and the temp filename conflicts with the input // filename, then avoid overwriting input file. if (!AtTopLevel && C.getArgs().hasArg(options::OPT_save_temps) && - NamedOutput == BaseName) { + NamedOutput == BaseName) { std::string TmpName = - GetTemporaryPath(types::getTypeTempSuffix(JA.getType())); + GetTemporaryPath(getBaseName(BaseInput), + types::getTypeTempSuffix(JA.getType())); return C.addTempFile(C.getArgs().MakeArgString(TmpName.c_str())); } @@ -1475,7 +1486,8 @@ std::string Driver::GetProgramPath(const char *Name, const ToolChain &TC, return Name; } -std::string Driver::GetTemporaryPath(const char *Suffix) const { +std::string Driver::GetTemporaryPath(const char *Prefix, const char *Suffix) + const { // FIXME: This is lame; sys::Path should provide this function (in particular, // it should know how to find the temporary files dir). std::string Error; @@ -1487,7 +1499,7 @@ std::string Driver::GetTemporaryPath(const char *Suffix) const { if (!TmpDir) TmpDir = "/tmp"; llvm::sys::Path P(TmpDir); - P.appendComponent("cc"); + P.appendComponent(Prefix); if (P.makeUnique(false, &Error)) { Diag(clang::diag::err_drv_unable_to_make_temp) << Error; return ""; diff --git a/clang/lib/Driver/Tools.cpp b/clang/lib/Driver/Tools.cpp index d91285b0a83..22747e4c8f1 100644 --- a/clang/lib/Driver/Tools.cpp +++ b/clang/lib/Driver/Tools.cpp @@ -2983,7 +2983,7 @@ void darwin::Compile::ConstructJob(Compilation &C, const JobAction &JA, // NOTE: gcc uses a temp .s file for this, but there doesn't seem // to be a good reason. const char *TmpPath = C.getArgs().MakeArgString( - D.GetTemporaryPath("s")); + D.GetTemporaryPath("cc", "s")); C.addTempFile(TmpPath); CmdArgs.push_back(TmpPath); @@ -3125,7 +3125,7 @@ void darwin::Link::AddLinkArgs(Compilation &C, // dsymutil step. if (Version[0] >= 116 && D.IsUsingLTO(Args)) { const char *TmpPath = C.getArgs().MakeArgString( - D.GetTemporaryPath(types::getTypeTempSuffix(types::TY_Object))); + D.GetTemporaryPath("cc", types::getTypeTempSuffix(types::TY_Object))); C.addTempFile(TmpPath); CmdArgs.push_back("-object_path_lto"); CmdArgs.push_back(TmpPath); -- cgit v1.2.3