From 99202b358f364f8fc352152a4da609022f5f78a5 Mon Sep 17 00:00:00 2001 From: Charles Davis Date: Tue, 9 Nov 2010 18:04:24 +0000 Subject: Use the right calling convention when mangling names in the Microsoft C++ mangler. Now member functions and pointers thereof have their calling convention mangled as __thiscall if they have the default CC (even though, they technically still have the __cdecl CC). llvm-svn: 118598 --- clang/lib/CodeGen/MicrosoftCXXABI.cpp | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'clang/lib/CodeGen/MicrosoftCXXABI.cpp') diff --git a/clang/lib/CodeGen/MicrosoftCXXABI.cpp b/clang/lib/CodeGen/MicrosoftCXXABI.cpp index baa6ed3f827..dd2f1cb1345 100644 --- a/clang/lib/CodeGen/MicrosoftCXXABI.cpp +++ b/clang/lib/CodeGen/MicrosoftCXXABI.cpp @@ -72,7 +72,7 @@ private: void mangleType(const ArrayType *T, bool IsGlobal); void mangleExtraDimensions(QualType T); void mangleFunctionClass(const FunctionDecl *FD); - void mangleCallingConvention(const FunctionType *T); + void mangleCallingConvention(const FunctionType *T, bool IsInstMethod = false); void mangleThrowSpecification(const FunctionProtoType *T); }; @@ -803,7 +803,7 @@ void MicrosoftCXXNameMangler::mangleType(const FunctionType *T, if (IsInstMethod) mangleQualifiers(Qualifiers::fromCVRMask(Proto->getTypeQuals()), false); - mangleCallingConvention(T); + mangleCallingConvention(T, IsInstMethod); // ::= // ::= @ # structors (they have no declared return type) @@ -898,7 +898,8 @@ void MicrosoftCXXNameMangler::mangleFunctionClass(const FunctionDecl *FD) { } else Out << 'Y'; } -void MicrosoftCXXNameMangler::mangleCallingConvention(const FunctionType *T) { +void MicrosoftCXXNameMangler::mangleCallingConvention(const FunctionType *T, + bool IsInstMethod) { // ::= A # __cdecl // ::= B # __export __cdecl // ::= C # __pascal @@ -914,7 +915,10 @@ void MicrosoftCXXNameMangler::mangleCallingConvention(const FunctionType *T) { // that keyword. (It didn't actually export them, it just made them so // that they could be in a DLL and somebody from another module could call // them.) - switch (T->getCallConv()) { + CallingConv CC = T->getCallConv(); + if (CC == CC_Default) + CC = IsInstMethod ? getASTContext().getDefaultMethodCallConv() : CC_C; + switch (CC) { case CC_Default: case CC_C: Out << 'A'; break; case CC_X86Pascal: Out << 'C'; break; -- cgit v1.2.3