From 15984457a673eff3969c0755be543e7d572edd47 Mon Sep 17 00:00:00 2001 From: Dmitry Mikulin Date: Thu, 17 Oct 2019 00:55:38 +0000 Subject: Revert Tag CFI-generated data structures with "#pragma clang section" attributes. This reverts r375022 (git commit e2692b3bc0327606748b6d291b9009d2c845ced5) llvm-svn: 375069 --- clang/lib/CodeGen/CodeGenModule.cpp | 27 +++++---------------------- 1 file changed, 5 insertions(+), 22 deletions(-) (limited to 'clang/lib/CodeGen/CodeGenModule.cpp') diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index a4859e7fbbf..8eb2176ca3a 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -1699,8 +1699,11 @@ bool CodeGenModule::GetCPUAndFeaturesAttributes(GlobalDecl GD, return AddedAttr; } -void CodeGenModule::setPragmaSectionAttributes(const Decl *D, - llvm::GlobalObject *GO) { +void CodeGenModule::setNonAliasAttributes(GlobalDecl GD, + llvm::GlobalObject *GO) { + const Decl *D = GD.getDecl(); + SetCommonAttributes(GD, GO); + if (D) { if (auto *GV = dyn_cast(GO)) { if (auto *SA = D->getAttr()) @@ -1718,26 +1721,6 @@ void CodeGenModule::setPragmaSectionAttributes(const Decl *D, if (!D->getAttr()) F->addFnAttr("implicit-section-name", SA->getName()); - if (auto *SA = D->getAttr()) - F->addFnAttr("bss-section", SA->getName()); - if (auto *SA = D->getAttr()) - F->addFnAttr("data-section", SA->getName()); - if (auto *SA = D->getAttr()) - F->addFnAttr("rodata-section", SA->getName()); - if (auto *SA = D->getAttr()) - F->addFnAttr("relro-section", SA->getName()); - } - } -} - -void CodeGenModule::setNonAliasAttributes(GlobalDecl GD, - llvm::GlobalObject *GO) { - const Decl *D = GD.getDecl(); - SetCommonAttributes(GD, GO); - setPragmaSectionAttributes(D, GO); - - if (D) { - if (auto *F = dyn_cast(GO)) { llvm::AttrBuilder Attrs; if (GetCPUAndFeaturesAttributes(GD, Attrs)) { // We know that GetCPUAndFeaturesAttributes will always have the -- cgit v1.2.3