From be4504df268af9f68edc212356cbdacf3bbf97da Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Thu, 11 Jul 2013 01:32:21 +0000 Subject: Simplify atomic load/store IRGen. Also fixes a couple minor bugs along the way; see testcases. llvm-svn: 186049 --- clang/lib/CodeGen/CGExpr.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'clang/lib/CodeGen/CGExpr.cpp') diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp index 419075fe179..b283174514e 100644 --- a/clang/lib/CodeGen/CGExpr.cpp +++ b/clang/lib/CodeGen/CGExpr.cpp @@ -2717,11 +2717,10 @@ LValue CodeGenFunction::EmitCastLValue(const CastExpr *E) { case CK_BuiltinFnToFnPtr: llvm_unreachable("builtin functions are handled elsewhere"); - // These two casts are currently treated as no-ops, although they could - // potentially be real operations depending on the target's ABI. + // These are never l-values; just use the aggregate emission code. case CK_NonAtomicToAtomic: case CK_AtomicToNonAtomic: - return EmitLValue(E->getSubExpr()); + return EmitAggExprToLValue(E); case CK_Dynamic: { LValue LV = EmitLValue(E->getSubExpr()); -- cgit v1.2.3