From 9cacbabd33eea88e9c416e4bc8abf58eebf5589d Mon Sep 17 00:00:00 2001 From: Alp Toker Date: Mon, 20 Jan 2014 20:26:09 +0000 Subject: Rename FunctionProtoType accessors from 'arguments' to 'parameters' Fix a perennial source of confusion in the clang type system: Declarations and function prototypes have parameters to which arguments are supplied, so calling these 'arguments' was a stretch even in C mode, let alone C++ where default arguments, templates and overloading make the distinction important to get right. Readability win across the board, especially in the casting, ADL and overloading implementations which make a lot more sense at a glance now. Will keep an eye on the builders and update dependent projects shortly. No functional change. llvm-svn: 199686 --- clang/lib/CodeGen/CGClass.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'clang/lib/CodeGen/CGClass.cpp') diff --git a/clang/lib/CodeGen/CGClass.cpp b/clang/lib/CodeGen/CGClass.cpp index 8143fb9ca5d..d3a1f391f77 100644 --- a/clang/lib/CodeGen/CGClass.cpp +++ b/clang/lib/CodeGen/CGClass.cpp @@ -1738,14 +1738,14 @@ CodeGenFunction::EmitSynthesizedCXXCopyCtorCall(const CXXConstructorDecl *D, Args.add(RValue::get(This), D->getThisType(getContext())); // Push the src ptr. - QualType QT = *(FPT->arg_type_begin()); + QualType QT = *(FPT->param_type_begin()); llvm::Type *t = CGM.getTypes().ConvertType(QT); Src = Builder.CreateBitCast(Src, t); Args.add(RValue::get(Src), QT); // Skip over first argument (Src). - EmitCallArgs(Args, FPT->isVariadic(), FPT->arg_type_begin() + 1, - FPT->arg_type_end(), ArgBeg + 1, ArgEnd); + EmitCallArgs(Args, FPT->isVariadic(), FPT->param_type_begin() + 1, + FPT->param_type_end(), ArgBeg + 1, ArgEnd); EmitCall(CGM.getTypes().arrangeCXXMethodCall(Args, FPT, RequiredArgs::All), Callee, ReturnValueSlot(), Args, D); -- cgit v1.2.3