From 1cfa27309184d95b3e2f9a4f74d35fb3723856cc Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Mon, 2 May 2016 22:29:40 +0000 Subject: Remove unneeded test in tryCaptureAsConstant. It isn't necessary to call hasDefaultArg because we can't rematerialize a captured variable that is a function parameter, regardless of whether or not it has a default argument. NFC. llvm-svn: 268318 --- clang/lib/CodeGen/CGBlocks.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'clang/lib/CodeGen/CGBlocks.cpp') diff --git a/clang/lib/CodeGen/CGBlocks.cpp b/clang/lib/CodeGen/CGBlocks.cpp index 88786bc9fcf..d603d21bbe0 100644 --- a/clang/lib/CodeGen/CGBlocks.cpp +++ b/clang/lib/CodeGen/CGBlocks.cpp @@ -262,10 +262,10 @@ static bool isSafeForCXXConstantCapture(QualType type) { static llvm::Constant *tryCaptureAsConstant(CodeGenModule &CGM, CodeGenFunction *CGF, const VarDecl *var) { - // Don't rematerialize default arguments of function parameters. - if (auto *PD = dyn_cast(var)) - if (PD->hasDefaultArg()) - return nullptr; + // Return if this is a function paramter. We shouldn't try to + // rematerialize default arguments of function parameters. + if (isa(var)) + return nullptr; QualType type = var->getType(); -- cgit v1.2.3