From f878a84cc4d58035c0d622b988af6fb5f286f140 Mon Sep 17 00:00:00 2001 From: Richard Smith Date: Mon, 5 Jun 2017 22:05:31 +0000 Subject: Fix memory leak exposed by r304726. When giving a ContentCache a null buffer, ignore the DoNotFree flag rather than inheriting it onto whatever buffer we end up using for the file. Also ensure that the main buffer is properly destroyed. llvm-svn: 304740 --- clang/lib/Basic/SourceManager.cpp | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'clang/lib/Basic/SourceManager.cpp') diff --git a/clang/lib/Basic/SourceManager.cpp b/clang/lib/Basic/SourceManager.cpp index c0cd2a8d2a1..fc4c6d30380 100644 --- a/clang/lib/Basic/SourceManager.cpp +++ b/clang/lib/Basic/SourceManager.cpp @@ -73,11 +73,11 @@ void ContentCache::replaceBuffer(llvm::MemoryBuffer *B, bool DoNotFree) { Buffer.setInt(DoNotFree? DoNotFreeFlag : 0); return; } - + if (shouldFreeBuffer()) delete Buffer.getPointer(); Buffer.setPointer(B); - Buffer.setInt(DoNotFree? DoNotFreeFlag : 0); + Buffer.setInt((B && DoNotFree) ? DoNotFreeFlag : 0); } llvm::MemoryBuffer *ContentCache::getBuffer(DiagnosticsEngine &Diag, @@ -362,9 +362,11 @@ void SourceManager::initializeForReplay(const SourceManager &Old) { // Set up our main file ID as a copy of the old source manager's main file. const SLocEntry &OldMainFile = Old.getSLocEntry(Old.getMainFileID()); assert(OldMainFile.isFile() && "main file is macro expansion?"); - setMainFileID(createFileID( - CloneContentCache(OldMainFile.getFile().getContentCache()), - SourceLocation(), OldMainFile.getFile().getFileCharacteristic(), 0, 0)); + auto *MainCC = CloneContentCache(OldMainFile.getFile().getContentCache()); + MemBufferInfos.push_back(MainCC); + setMainFileID(createFileID(MainCC, SourceLocation(), + OldMainFile.getFile().getFileCharacteristic(), + 0, 0)); // Ensure all SLocEntries are loaded from the external source. for (unsigned I = 0, N = Old.LoadedSLocEntryTable.size(); I != N; ++I) -- cgit v1.2.3