From f4c511b026a8c9d11392c5ce05ff0a6de28d8172 Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Sat, 14 Nov 2009 12:08:24 +0000 Subject: Change *BugReport constructors to take StringRefs. - Eliminates many calls to std::string.c_str() - Fixes an invalid read in ReturnStackAddressChecker due to an unsafe call to StringRef.data() which doesn't guarantee null-termination. llvm-svn: 88779 --- clang/lib/Analysis/UndefinedArraySubscriptChecker.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'clang/lib/Analysis/UndefinedArraySubscriptChecker.cpp') diff --git a/clang/lib/Analysis/UndefinedArraySubscriptChecker.cpp b/clang/lib/Analysis/UndefinedArraySubscriptChecker.cpp index 47d615dbbdf..887c7755fe4 100644 --- a/clang/lib/Analysis/UndefinedArraySubscriptChecker.cpp +++ b/clang/lib/Analysis/UndefinedArraySubscriptChecker.cpp @@ -46,8 +46,7 @@ UndefinedArraySubscriptChecker::PreVisitArraySubscriptExpr(CheckerContext &C, BT = new BuiltinBug("Array subscript is undefined"); // Generate a report for this bug. - EnhancedBugReport *R = new EnhancedBugReport(*BT, BT->getName().c_str(), - N); + EnhancedBugReport *R = new EnhancedBugReport(*BT, BT->getName(), N); R->addRange(A->getIdx()->getSourceRange()); R->addVisitorCreator(bugreporter::registerTrackNullOrUndefValue, A->getIdx()); -- cgit v1.2.3