From b6cbf28d82fb70edd84b45d65e4eaebd30401f25 Mon Sep 17 00:00:00 2001 From: Ted Kremenek Date: Wed, 7 May 2008 18:36:45 +0000 Subject: Use llvm::CStrInCStrNoCase instead of strcasestr, since the latter is not portable. Correctly check if the result of CStrInCStrNoCase is NULL to generate summaries; before we were inverting the condition. llvm-svn: 50822 --- clang/lib/Analysis/CFRefCount.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'clang/lib/Analysis/CFRefCount.cpp') diff --git a/clang/lib/Analysis/CFRefCount.cpp b/clang/lib/Analysis/CFRefCount.cpp index 5698dc8a21b..5c4cc12f36d 100644 --- a/clang/lib/Analysis/CFRefCount.cpp +++ b/clang/lib/Analysis/CFRefCount.cpp @@ -23,11 +23,13 @@ #include "llvm/ADT/DenseMap.h" #include "llvm/ADT/FoldingSet.h" #include "llvm/ADT/ImmutableMap.h" +#include "llvm/ADT/StringExtras.h" #include "llvm/Support/Compiler.h" #include #include using namespace clang; +using llvm::CStrInCStrNoCase; //===----------------------------------------------------------------------===// // Utility functions. @@ -604,8 +606,8 @@ RetainSummaryManager::getMethodSummary(ObjCMessageExpr* ME) { if (!isNSType(ME->getReceiver()->getType())) return 0; - if (strcasestr(s, "create") == 0 || strcasestr(s, "copy") == 0 || - strcasestr(s, "new") == 0) { + if (CStrInCStrNoCase(s, "create") || CStrInCStrNoCase(s, "copy") || + CStrInCStrNoCase(s, "new")) { RetEffect E = isGCEnabled() ? RetEffect::MakeNoRet() : RetEffect::MakeOwned(); -- cgit v1.2.3