From e4b95698df99424e287b34c76da92add5a773392 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Mon, 24 Nov 2008 03:33:13 +0000 Subject: Rename Selector::getName() to Selector::getAsString(), and add a new NamedDecl::getAsString() method. Change uses of Selector::getName() to just pass in a Selector where possible (e.g. to diagnostics) instead of going through an std::string. This also adds new formatters for objcinstance and objcclass as described in the dox. llvm-svn: 59933 --- clang/lib/AST/ASTContext.cpp | 4 ++-- clang/lib/AST/DeclObjC.cpp | 2 +- clang/lib/AST/DeclarationName.cpp | 2 +- clang/lib/AST/StmtDumper.cpp | 11 +++++------ clang/lib/AST/StmtPrinter.cpp | 2 +- 5 files changed, 10 insertions(+), 11 deletions(-) (limited to 'clang/lib/AST') diff --git a/clang/lib/AST/ASTContext.cpp b/clang/lib/AST/ASTContext.cpp index 7bfdf713391..61e8c99aa40 100644 --- a/clang/lib/AST/ASTContext.cpp +++ b/clang/lib/AST/ASTContext.cpp @@ -1577,12 +1577,12 @@ void ASTContext::getObjCEncodingForPropertyDecl(const ObjCPropertyDecl *PD, if (PD->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_getter) { S += ",G"; - S += PD->getGetterName().getName(); + S += PD->getGetterName().getAsString(); } if (PD->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_setter) { S += ",S"; - S += PD->getSetterName().getName(); + S += PD->getSetterName().getAsString(); } if (SynthesizePID) { diff --git a/clang/lib/AST/DeclObjC.cpp b/clang/lib/AST/DeclObjC.cpp index 558156c4a02..e69526e241c 100644 --- a/clang/lib/AST/DeclObjC.cpp +++ b/clang/lib/AST/DeclObjC.cpp @@ -763,7 +763,7 @@ unsigned ObjCMethodDecl::getSynthesizedMethodSize() const { if (ObjCCategoryImplDecl *CID = dyn_cast(MethodContext)) length += strlen(CID->getIdentifierName()) +1; - length += getSelector().getName().size(); // selector name + length += getSelector().getAsString().size(); // selector name return length; } diff --git a/clang/lib/AST/DeclarationName.cpp b/clang/lib/AST/DeclarationName.cpp index 3a9e7c84e3d..ed4b7c6105d 100644 --- a/clang/lib/AST/DeclarationName.cpp +++ b/clang/lib/AST/DeclarationName.cpp @@ -120,7 +120,7 @@ std::string DeclarationName::getAsString() const { case ObjCZeroArgSelector: case ObjCOneArgSelector: case ObjCMultiArgSelector: - return getObjCSelector().getName(); + return getObjCSelector().getAsString(); case CXXConstructorName: { QualType ClassType = getCXXNameType(); diff --git a/clang/lib/AST/StmtDumper.cpp b/clang/lib/AST/StmtDumper.cpp index 04ae2cdb19a..f7330c2a9dc 100644 --- a/clang/lib/AST/StmtDumper.cpp +++ b/clang/lib/AST/StmtDumper.cpp @@ -376,7 +376,7 @@ void StmtDumper::VisitSizeOfAlignOfExpr(SizeOfAlignOfExpr *Node) { void StmtDumper::VisitMemberExpr(MemberExpr *Node) { DumpExpr(Node); fprintf(F, " %s%s %p", Node->isArrow() ? "->" : ".", - Node->getMemberDecl()->getName().c_str(), + Node->getMemberDecl()->getNameAsString().c_str(), (void*)Node->getMemberDecl()); } void StmtDumper::VisitExtVectorElementExpr(ExtVectorElementExpr *Node) { @@ -441,7 +441,7 @@ void StmtDumper::VisitCXXFunctionalCastExpr(CXXFunctionalCastExpr *Node) { void StmtDumper::VisitObjCMessageExpr(ObjCMessageExpr* Node) { DumpExpr(Node); - fprintf(F, " selector=%s", Node->getSelector().getName().c_str()); + fprintf(F, " selector=%s", Node->getSelector().getAsString().c_str()); IdentifierInfo* clsName = Node->getClassName(); if (clsName) fprintf(F, " class=%s", clsName->getName()); } @@ -457,8 +457,7 @@ void StmtDumper::VisitObjCSelectorExpr(ObjCSelectorExpr *Node) { DumpExpr(Node); fprintf(F, " "); - Selector selector = Node->getSelector(); - fprintf(F, "%s", selector.getName().c_str()); + fprintf(F, "%s", Node->getSelector().getAsString().c_str()); } void StmtDumper::VisitObjCProtocolExpr(ObjCProtocolExpr *Node) { @@ -481,8 +480,8 @@ void StmtDumper::VisitObjCKVCRefExpr(ObjCKVCRefExpr *Node) { ObjCMethodDecl *Getter = Node->getGetterMethod(); ObjCMethodDecl *Setter = Node->getSetterMethod(); fprintf(F, " Kind=MethodRef Getter=\"%s\" Setter=\"%s\"", - Getter->getSelector().getName().c_str(), - Setter ? Setter->getSelector().getName().c_str() : "(null)"); + Getter->getSelector().getAsString().c_str(), + Setter ? Setter->getSelector().getAsString().c_str() : "(null)"); } void StmtDumper::VisitObjCSuperExpr(ObjCSuperExpr *Node) { diff --git a/clang/lib/AST/StmtPrinter.cpp b/clang/lib/AST/StmtPrinter.cpp index 94cfae9d4c9..8a7d3eb6500 100644 --- a/clang/lib/AST/StmtPrinter.cpp +++ b/clang/lib/AST/StmtPrinter.cpp @@ -988,7 +988,7 @@ void StmtPrinter::VisitObjCEncodeExpr(ObjCEncodeExpr *Node) { } void StmtPrinter::VisitObjCSelectorExpr(ObjCSelectorExpr *Node) { - OS << "@selector(" << Node->getSelector().getName() << ")"; + OS << "@selector(" << Node->getSelector().getAsString() << ")"; } void StmtPrinter::VisitObjCProtocolExpr(ObjCProtocolExpr *Node) { -- cgit v1.2.3