From 0475c8178f7cc8d661b319afc6a40c88a7a1248d Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Sun, 2 Dec 2007 07:32:25 +0000 Subject: globals can't be vla's llvm-svn: 44512 --- clang/CodeGen/CodeGenModule.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'clang/CodeGen/CodeGenModule.cpp') diff --git a/clang/CodeGen/CodeGenModule.cpp b/clang/CodeGen/CodeGenModule.cpp index 97ff705a39f..fdfb883c5ee 100644 --- a/clang/CodeGen/CodeGenModule.cpp +++ b/clang/CodeGen/CodeGenModule.cpp @@ -372,8 +372,7 @@ static llvm::Constant *GenerateConstantExpr(const Expr *Expression, // If this is due to array->pointer conversion, emit the array expression as // an l-value. if (ICExpr->getSubExpr()->getType()->isArrayType()) { - // FIXME: For now we assume that all source arrays map to LLVM arrays. - // This will not true when we add support for VLAs. + // Note that VLAs can't exist for global variables. // The only thing that can have array type like this is a // DeclRefExpr(FileVarDecl)? const DeclRefExpr *DRE = cast(ICExpr->getSubExpr()); @@ -381,8 +380,7 @@ static llvm::Constant *GenerateConstantExpr(const Expr *Expression, llvm::Constant *C = CGM.GetAddrOfFileVarDecl(FVD, false); assert(isa(C->getType()) && isa(cast(C->getType()) - ->getElementType()) && - "Doesn't support VLAs yet!"); + ->getElementType())); llvm::Constant *Idx0 = llvm::ConstantInt::get(llvm::Type::Int32Ty, 0); llvm::Constant *Ops[] = {Idx0, Idx0}; -- cgit v1.2.3