From 056237a457dc3cdc88d0e282663400871f8e96dd Mon Sep 17 00:00:00 2001 From: Matthias Gehre Date: Wed, 20 Jul 2016 12:32:06 +0000 Subject: clang-tidy modernize-loop-convert: preserve type of alias declaration (bug 28341) Summary: Previoly, the added test failed with the fillowing fixit: char v[5]; - for(size_t i = 0; i < 5; ++i) + for(char value : v) { - unsigned char value = v[i]; if (value > 127) i.e. the variable 'value' changes from unsigned char to signed char. And thus the following 'if' does not work anymore. With this commit, the fixit is changed to: char v[5]; - for(size_t i = 0; i < 5; ++i) + for(unsigned char value : v) { - unsigned char value = v[i]; if (value > 127) Reviewers: alexfh, klimek Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D22069 llvm-svn: 276111 --- .../test/clang-tidy/modernize-loop-convert-extra.cpp | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'clang-tools-extra/test/clang-tidy/modernize-loop-convert-extra.cpp') diff --git a/clang-tools-extra/test/clang-tidy/modernize-loop-convert-extra.cpp b/clang-tools-extra/test/clang-tidy/modernize-loop-convert-extra.cpp index 7312b48b9b3..b46ff25c2a3 100644 --- a/clang-tools-extra/test/clang-tidy/modernize-loop-convert-extra.cpp +++ b/clang-tools-extra/test/clang-tidy/modernize-loop-convert-extra.cpp @@ -1060,3 +1060,15 @@ void f() { } } // namespace InitLists + +void bug28341() { + char v[5]; + for(int i = 0; i < 5; ++i) { + unsigned char value = v[i]; + if (value > 127) + ; + // CHECK-MESSAGES: :[[@LINE-4]]:3: warning: use range-based for loop instead + // CHECK-FIXES: for(unsigned char value : v) + // CHECK-FIXES-NEXT: if (value > 127) + } +} -- cgit v1.2.3