From 885c559369fe3d6323898c17787bd0454065fc34 Mon Sep 17 00:00:00 2001 From: Dmitri Gribenko Date: Fri, 11 Oct 2019 12:05:42 +0000 Subject: [ClangTidy] Separate tests for infrastructure and checkers Summary: This change moves tests for checkers and infrastructure into separate directories, making it easier to find infrastructure tests. Tests for checkers are already easy to find because they are named after the checker. Tests for infrastructure were difficult to find because they were outnumbered by tests for checkers. Now they are in a separate directory. Reviewers: jfb, jdoerfert, lebedev.ri Subscribers: srhines, nemanjai, aheejin, kbarton, christof, mgrang, arphaman, jfb, lebedev.ri, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D68807 llvm-svn: 374540 --- .../cppcoreguidelines-owning-memory-containers.cpp | 62 ---------------------- 1 file changed, 62 deletions(-) delete mode 100644 clang-tools-extra/test/clang-tidy/cppcoreguidelines-owning-memory-containers.cpp (limited to 'clang-tools-extra/test/clang-tidy/cppcoreguidelines-owning-memory-containers.cpp') diff --git a/clang-tools-extra/test/clang-tidy/cppcoreguidelines-owning-memory-containers.cpp b/clang-tools-extra/test/clang-tidy/cppcoreguidelines-owning-memory-containers.cpp deleted file mode 100644 index d39e697c6bd..00000000000 --- a/clang-tools-extra/test/clang-tidy/cppcoreguidelines-owning-memory-containers.cpp +++ /dev/null @@ -1,62 +0,0 @@ -// RUN: %check_clang_tidy %s cppcoreguidelines-owning-memory %t - -namespace gsl { -template -using owner = T; -} - -namespace std { - -// Not actually a vector, but more a dynamic, fixed size array. Just to demonstrate -// functionality or the lack of the same. -template -class vector { -public: - vector(unsigned long size, T val) : data{new T[size]}, size{size} { - for (unsigned long i = 0ul; i < size; ++i) { - data[i] = val; - } - } - - T *begin() { return data; } - T *end() { return &data[size]; } - T &operator[](unsigned long index) { return data[index]; } - -private: - T *data; - unsigned long size; -}; - -} // namespace std - -// All of the following codesnippets should be valid with appropriate 'owner<>' anaylsis, -// but currently the type information of 'gsl::owner<>' gets lost in typededuction. -int main() { - std::vector> OwnerStdVector(100, nullptr); - - // Rangebased looping in resource vector. - for (auto *Element : OwnerStdVector) { - Element = new int(42); - // CHECK-NOTES: [[@LINE-1]]:5: warning: assigning newly created 'gsl::owner<>' to non-owner 'int *' - } - for (auto *Element : OwnerStdVector) { - delete Element; - // CHECK-NOTES: [[@LINE-1]]:5: warning: deleting a pointer through a type that is not marked 'gsl::owner<>'; consider using a smart pointer instead - // CHECK-NOTES: [[@LINE-3]]:8: note: variable declared here - } - - // Indexbased looping in resource vector. - for (int i = 0; i < 100; ++i) { - OwnerStdVector[i] = new int(42); - // CHECK-NOTES: [[@LINE-1]]:5: warning: assigning newly created 'gsl::owner<>' to non-owner 'int *' - } - for (int i = 0; i < 100; ++i) { - delete OwnerStdVector[i]; - // CHECK-NOTES: [[@LINE-1]]:5: warning: deleting a pointer through a type that is not marked 'gsl::owner<>'; consider using a smart pointer instead - // CHECK-NOTES: [[@LINE-21]]:3: note: variable declared here - // A note gets emitted here pointing to the return value of the operator[] from the - // vector implementation. Maybe this is considered misleading. - } - - return 0; -} -- cgit v1.2.3