From 24340252a4f58b4d3fd29b73caf123c43dae792a Mon Sep 17 00:00:00 2001 From: Yan Wang Date: Thu, 29 Jun 2017 17:42:23 +0000 Subject: [clang-tidy][Part3] Add a new module Android and three new checks. Summary: -- fopen() should include "e" in their mode string. [android-fopen-mode] Reviewers: chh, alexfh, aaron.ballman, hokein Reviewed By: hokein Subscribers: JDevlieghere, srhines, mgorny, xazax.hun Tags: #clang-tools-extra Differential Revision: https://reviews.llvm.org/D33747 llvm-svn: 306709 --- .../test/clang-tidy/android-cloexec-fopen.cpp | 57 ++++++++++++++++++++++ 1 file changed, 57 insertions(+) create mode 100644 clang-tools-extra/test/clang-tidy/android-cloexec-fopen.cpp (limited to 'clang-tools-extra/test/clang-tidy/android-cloexec-fopen.cpp') diff --git a/clang-tools-extra/test/clang-tidy/android-cloexec-fopen.cpp b/clang-tools-extra/test/clang-tidy/android-cloexec-fopen.cpp new file mode 100644 index 00000000000..6b6c655c157 --- /dev/null +++ b/clang-tools-extra/test/clang-tidy/android-cloexec-fopen.cpp @@ -0,0 +1,57 @@ +// RUN: %check_clang_tidy %s android-cloexec-fopen %t + +#define FILE_OPEN_RO "r" + +typedef int FILE; + +extern "C" FILE *fopen(const char *filename, const char *mode, ...); +extern "C" FILE *open(const char *filename, const char *mode, ...); + +void f() { + fopen("filename", "r"); + // CHECK-MESSAGES: :[[@LINE-1]]:21: warning: use 'fopen' mode 'e' to set O_CLOEXEC [android-cloexec-fopen] + // CHECK-FIXES: fopen("filename", "re"); + + fopen("filename", FILE_OPEN_RO); + // CHECK-MESSAGES: :[[@LINE-1]]:21: warning: use 'fopen' mode 'e' + // CHECK-FIXES: fopen("filename", FILE_OPEN_RO "e"); + + fopen("filename", "er"); + // CHECK-MESSAGES-NOT: warning: + fopen("filename", "re"); + // CHECK-MESSAGES-NOT: warning: + fopen("filename", "e"); + // CHECK-MESSAGES-NOT: warning: + open("filename", "e"); + // CHECK-MESSAGES-NOT: warning: + + char *str = "r"; + fopen("filename", str); + // CHECK-MESSAGES-NOT: warning: + str = "re"; + fopen("filename", str); + // CHECK-MESSAGES-NOT: warning: + char arr[2] = "r"; + fopen("filename", arr); + // CHECK-MESSAGES-NOT: warning: + char arr2[3] = "re"; + fopen("filename", arr2); + // CHECK-MESSAGES-NOT: warning: +} + +namespace i { +int *fopen(const char *filename, const char *mode, ...); +void g() { + fopen("filename", "e"); + // CHECK-MESSAGES-NOT: warning: +} +} // namespace i + +class C { +public: + int *fopen(const char *filename, const char *mode, ...); + void h() { + fopen("filename", "e"); + // CHECK-MESSAGES-NOT: warning: + } +}; -- cgit v1.2.3