From 5a267ed889071dcf07e123a9841eeb7de0c089fb Mon Sep 17 00:00:00 2001 From: Kirill Bobyrev Date: Tue, 29 May 2018 11:50:51 +0000 Subject: [clangd] Minor cleanup This patch silences few clang-tidy warnings, removes unwanted trailing whitespace and enforces coding guidelines. The functionality is not affected since the cleanup is rather straightforward, all clangd tests are still green. Reviewers: ioeric, ilya-biryukov Reviewed By: ioeric Subscribers: MaskRay, jkorous, cfe-commits Differential Revision: https://reviews.llvm.org/D47471 llvm-svn: 333411 --- clang-tools-extra/clangd/CodeComplete.cpp | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) (limited to 'clang-tools-extra/clangd/CodeComplete.cpp') diff --git a/clang-tools-extra/clangd/CodeComplete.cpp b/clang-tools-extra/clangd/CodeComplete.cpp index cfebb3e3c94..09e18361506 100644 --- a/clang-tools-extra/clangd/CodeComplete.cpp +++ b/clang-tools-extra/clangd/CodeComplete.cpp @@ -359,13 +359,13 @@ struct SpecifiedScope { // Get all scopes that will be queried in indexes. std::vector getQueryScopes(CodeCompletionContext &CCContext, - const SourceManager& SM) { - auto GetAllAccessibleScopes = [](CodeCompletionContext& CCContext) { + const SourceManager &SM) { + auto GetAllAccessibleScopes = [](CodeCompletionContext &CCContext) { SpecifiedScope Info; - for (auto* Context : CCContext.getVisitedContexts()) { + for (auto *Context : CCContext.getVisitedContexts()) { if (isa(Context)) Info.AccessibleScopes.push_back(""); // global namespace - else if (const auto*NS = dyn_cast(Context)) + else if (const auto *NS = dyn_cast(Context)) Info.AccessibleScopes.push_back(NS->getQualifiedNameAsString() + "::"); } return Info; @@ -397,8 +397,9 @@ std::vector getQueryScopes(CodeCompletionContext &CCContext, Info.AccessibleScopes.push_back(""); // global namespace Info.UnresolvedQualifier = - Lexer::getSourceText(CharSourceRange::getCharRange((*SS)->getRange()), - SM, clang::LangOptions()).ltrim("::"); + Lexer::getSourceText(CharSourceRange::getCharRange((*SS)->getRange()), SM, + clang::LangOptions()) + .ltrim("::"); // Sema excludes the trailing "::". if (!Info.UnresolvedQualifier->empty()) *Info.UnresolvedQualifier += "::"; @@ -590,7 +591,7 @@ public: SigHelp.signatures.push_back(ProcessOverloadCandidate( Candidate, *CCS, getParameterDocComment(S.getASTContext(), Candidate, CurrentArg, - /*CommentsFromHeader=*/false))); + /*CommentsFromHeaders=*/false))); } } @@ -696,7 +697,7 @@ bool semaCodeComplete(std::unique_ptr Consumer, &DummyDiagsConsumer, false), Input.VFS); if (!CI) { - log("Couldn't create CompilerInvocation");; + log("Couldn't create CompilerInvocation"); return false; } auto &FrontendOpts = CI->getFrontendOpts(); @@ -1013,7 +1014,7 @@ private: LLVM_DEBUG(llvm::dbgs() << "CodeComplete: " << C.Name << (IndexResult ? " (index)" : "") << (SemaResult ? " (sema)" : "") << " = " << Scores.finalScore - << "\n" + << "\n" << Quality << Relevance << "\n"); NSema += bool(SemaResult); @@ -1035,7 +1036,8 @@ private: /*CommentsFromHeader=*/false); } } - return Candidate.build(FileName, Scores, Opts, SemaCCS, Includes.get(), DocComment); + return Candidate.build(FileName, Scores, Opts, SemaCCS, Includes.get(), + DocComment); } }; -- cgit v1.2.3