From d0794365710a85f3c8c4f9847c80eddace29d954 Mon Sep 17 00:00:00 2001 From: Jonas Toth Date: Fri, 5 Oct 2018 13:36:00 +0000 Subject: [clang-tidy] Replace deprecated std::ios_base aliases This check warns the uses of the deprecated member types of std::ios_base and replaces those that have a non-deprecated equivalent. Patch by andobence! Reviewd by: alexfh Revision ID: https://reviews.llvm.org/D51332 llvm-svn: 343848 --- .../modernize/DeprecatedIosBaseAliasesCheck.cpp | 80 ++++++++++++++++++++++ 1 file changed, 80 insertions(+) create mode 100644 clang-tools-extra/clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.cpp (limited to 'clang-tools-extra/clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.cpp') diff --git a/clang-tools-extra/clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.cpp b/clang-tools-extra/clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.cpp new file mode 100644 index 00000000000..2e9dad99e5d --- /dev/null +++ b/clang-tools-extra/clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.cpp @@ -0,0 +1,80 @@ +//===--- DeprecatedIosBaseAliasesCheck.cpp - clang-tidy--------------------===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +#include "DeprecatedIosBaseAliasesCheck.h" +#include "clang/AST/ASTContext.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" + +using namespace clang::ast_matchers; + +namespace clang { +namespace tidy { +namespace modernize { + +static const std::array DeprecatedTypes = { + "::std::ios_base::io_state", "::std::ios_base::open_mode", + "::std::ios_base::seek_dir", "::std::ios_base::streamoff", + "::std::ios_base::streampos", +}; + +static const llvm::StringMap ReplacementTypes = { + {"io_state", "iostate"}, + {"open_mode", "openmode"}, + {"seek_dir", "seekdir"}}; + +void DeprecatedIosBaseAliasesCheck::registerMatchers(MatchFinder *Finder) { + // Only register the matchers for C++; the functionality currently does not + // provide any benefit to other languages, despite being benign. + if (!getLangOpts().CPlusPlus) + return; + + auto IoStateDecl = typedefDecl(hasAnyName(DeprecatedTypes)).bind("TypeDecl"); + auto IoStateType = + qualType(hasDeclaration(IoStateDecl), unless(elaboratedType())); + + Finder->addMatcher(typeLoc(loc(IoStateType)).bind("TypeLoc"), this); +} + +void DeprecatedIosBaseAliasesCheck::check( + const MatchFinder::MatchResult &Result) { + SourceManager &SM = *Result.SourceManager; + + const auto *Typedef = Result.Nodes.getNodeAs("TypeDecl"); + StringRef TypeName = Typedef->getName(); + bool HasReplacement = ReplacementTypes.count(TypeName); + + const auto *TL = Result.Nodes.getNodeAs("TypeLoc"); + SourceLocation IoStateLoc = TL->getBeginLoc(); + + // Do not generate fixits for matches depending on template arguments and + // macro expansions. + bool Fix = HasReplacement && !TL->getType()->isDependentType(); + if (IoStateLoc.isMacroID()) { + IoStateLoc = SM.getSpellingLoc(IoStateLoc); + Fix = false; + } + + SourceLocation EndLoc = IoStateLoc.getLocWithOffset(TypeName.size() - 1); + + if (HasReplacement) { + auto FixName = ReplacementTypes.lookup(TypeName); + auto Builder = diag(IoStateLoc, "'std::ios_base::%0' is deprecated; use " + "'std::ios_base::%1' instead") + << TypeName << FixName; + + if (Fix) + Builder << FixItHint::CreateReplacement(SourceRange(IoStateLoc, EndLoc), + FixName); + } else + diag(IoStateLoc, "'std::ios_base::%0' is deprecated") << TypeName; +} + +} // namespace modernize +} // namespace tidy +} // namespace clang -- cgit v1.2.3