From 3d1d076f794279812b59ba71a0f53bd86ab709dd Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Mon, 8 Feb 2016 16:05:39 +0000 Subject: [clang-tidy] Some improvements in 'misc-definitions-in-headers' check. Reviewers: alexfh Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D16979 llvm-svn: 260108 --- clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp') diff --git a/clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp b/clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp index e6d7567ec93..b5ac6cea492 100644 --- a/clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp +++ b/clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp @@ -51,6 +51,8 @@ void DefinitionsInHeadersCheck::storeOptions( } void DefinitionsInHeadersCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus) + return; if (UseHeaderFileExtension) { Finder->addMatcher( namedDecl(anyOf(functionDecl(isDefinition()), varDecl(isDefinition())), @@ -78,6 +80,8 @@ void DefinitionsInHeadersCheck::check(const MatchFinder::MatchResult &Result) { // satisfy the following requirements. const auto *ND = Result.Nodes.getNodeAs("name-decl"); assert(ND); + if (ND->isInvalidDecl()) + return; // Internal linkage variable definitions are ignored for now: // const int a = 1; -- cgit v1.2.3