From 326e48cd096cf2960a99699437c5f0f4526854c9 Mon Sep 17 00:00:00 2001 From: Alexander Kornienko Date: Wed, 30 Jul 2014 14:31:36 +0000 Subject: Don't warn on NewCallback argument comments, as they are arguments for the function the callback points to. Reviewers: djasper Reviewed By: djasper Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D4722 llvm-svn: 214307 --- clang-tools-extra/clang-tidy/misc/ArgumentCommentCheck.cpp | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) (limited to 'clang-tools-extra/clang-tidy/misc/ArgumentCommentCheck.cpp') diff --git a/clang-tools-extra/clang-tidy/misc/ArgumentCommentCheck.cpp b/clang-tools-extra/clang-tidy/misc/ArgumentCommentCheck.cpp index fcf27dde10c..5357b7c92a9 100644 --- a/clang-tools-extra/clang-tidy/misc/ArgumentCommentCheck.cpp +++ b/clang-tools-extra/clang-tidy/misc/ArgumentCommentCheck.cpp @@ -8,9 +8,6 @@ //===----------------------------------------------------------------------===// #include "ArgumentCommentCheck.h" -#include "../ClangTidy.h" -#include "../ClangTidyModule.h" -#include "../ClangTidyModuleRegistry.h" #include "clang/AST/ASTContext.h" #include "clang/ASTMatchers/ASTMatchFinder.h" #include "clang/Lex/Lexer.h" @@ -25,7 +22,15 @@ ArgumentCommentCheck::ArgumentCommentCheck() : IdentRE("^(/\\* *)([_A-Za-z][_A-Za-z0-9]*)( *= *\\*/)$") {} void ArgumentCommentCheck::registerMatchers(MatchFinder *Finder) { - Finder->addMatcher(callExpr(unless(operatorCallExpr())).bind("expr"), this); + Finder->addMatcher( + callExpr(unless(operatorCallExpr()), + // NewCallback's arguments relate to the pointed function, don't + // check them against NewCallback's parameter names. + // FIXME: Make this configurable. + unless(hasDeclaration(functionDecl(anyOf( + hasName("NewCallback"), hasName("NewPermanentCallback")))))) + .bind("expr"), + this); Finder->addMatcher(constructExpr().bind("expr"), this); } -- cgit v1.2.3