From e4acb971f1ea3f9b0c1e4c0fd1d69b1920c3a9fc Mon Sep 17 00:00:00 2001 From: Stephane Moore Date: Tue, 1 Oct 2019 21:18:40 +0000 Subject: [clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock Summary: OSSpinLock* are Apple/Darwin functions, but were previously located with ObjC checks as those were most closely tied to Apple platforms before. Now that there's a specific Darwin module, relocating the check there. This change was prepared by running rename_check.py. Contributed By: mwyman Reviewers: stephanemoore, dmaclach Reviewed By: stephanemoore Subscribers: Eugene.Zelenko, mgorny, xazax.hun, cfe-commits Tags: #clang-tools-extra, #clang, #llvm Differential Revision: https://reviews.llvm.org/D68148 llvm-svn: 373392 --- .../clang-tidy/darwin/AvoidSpinlockCheck.cpp | 36 ++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 clang-tools-extra/clang-tidy/darwin/AvoidSpinlockCheck.cpp (limited to 'clang-tools-extra/clang-tidy/darwin/AvoidSpinlockCheck.cpp') diff --git a/clang-tools-extra/clang-tidy/darwin/AvoidSpinlockCheck.cpp b/clang-tools-extra/clang-tidy/darwin/AvoidSpinlockCheck.cpp new file mode 100644 index 00000000000..2a52725c19c --- /dev/null +++ b/clang-tools-extra/clang-tidy/darwin/AvoidSpinlockCheck.cpp @@ -0,0 +1,36 @@ +//===--- AvoidSpinlockCheck.cpp - clang-tidy-------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "AvoidSpinlockCheck.h" +#include "clang/AST/ASTContext.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" + +using namespace clang::ast_matchers; + +namespace clang { +namespace tidy { +namespace darwin { + +void AvoidSpinlockCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + callExpr(callee((functionDecl(hasAnyName( + "OSSpinlockLock", "OSSpinlockUnlock", "OSSpinlockTry"))))) + .bind("spinlock"), + this); +} + +void AvoidSpinlockCheck::check(const MatchFinder::MatchResult &Result) { + const auto *MatchedExpr = Result.Nodes.getNodeAs("spinlock"); + diag(MatchedExpr->getBeginLoc(), + "use os_unfair_lock_lock() or dispatch queue APIs instead of the " + "deprecated OSSpinLock"); +} + +} // namespace darwin +} // namespace tidy +} // namespace clang -- cgit v1.2.3