From 9bb9fa84dfb86aa684d8717f80f04ee78a74dac4 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Thu, 20 Jun 2013 22:04:56 +0000 Subject: Add a fixme. llvm-svn: 184486 --- llvm/tools/llvm-ar/llvm-ar.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/llvm/tools/llvm-ar/llvm-ar.cpp b/llvm/tools/llvm-ar/llvm-ar.cpp index b7328e1300f..23b3df3d3b2 100644 --- a/llvm/tools/llvm-ar/llvm-ar.cpp +++ b/llvm/tools/llvm-ar/llvm-ar.cpp @@ -428,6 +428,7 @@ doExtract(std::string* ErrMsg) { // Retain the original mode. sys::fs::perms Mode = sys::fs::perms(I->getMode()); + // FIXME: at least on posix we should be able to reuse FD (fchmod). error_code EC = sys::fs::permissions(I->getPath(), Mode); if (EC) fail(EC.message()); -- cgit v1.2.3