From 80c54b05a0b4790a54556a80587b95b6fc4b5c97 Mon Sep 17 00:00:00 2001 From: Fariborz Jahanian Date: Wed, 3 Feb 2010 21:29:28 +0000 Subject: Fix more rewriting of protocol-quialified 'id' type. (Fixes radar 7607413). llvm-svn: 95257 --- clang/lib/Frontend/RewriteObjC.cpp | 2 ++ clang/test/Rewriter/rewrite-protocol-qualified.mm | 20 ++++++++++++++++++++ 2 files changed, 22 insertions(+) diff --git a/clang/lib/Frontend/RewriteObjC.cpp b/clang/lib/Frontend/RewriteObjC.cpp index 980c96ad17d..9ec28bb6d4e 100644 --- a/clang/lib/Frontend/RewriteObjC.cpp +++ b/clang/lib/Frontend/RewriteObjC.cpp @@ -1995,6 +1995,8 @@ static void scanToNextArgument(const char *&argRef) { } bool RewriteObjC::needToScanForQualifiers(QualType T) { + if (T->isObjCQualifiedIdType()) + return true; if (const PointerType *PT = T->getAs()) { if (PT->getPointeeType()->isObjCQualifiedIdType()) return true; diff --git a/clang/test/Rewriter/rewrite-protocol-qualified.mm b/clang/test/Rewriter/rewrite-protocol-qualified.mm index e93ddbba277..e91c3db8616 100644 --- a/clang/test/Rewriter/rewrite-protocol-qualified.mm +++ b/clang/test/Rewriter/rewrite-protocol-qualified.mm @@ -16,6 +16,26 @@ } @end +// radar 7607413 +@protocol Proto1, Proto2; + +@protocol Proto +@end + +unsigned char func(id inProxy); + +id bar(id); + +void f() { + id a; + id b = bar((id )a); +} + // CHECK-LP: NSConnection /**/ *conn = 0; // CHECK-LP: id /**/ *idc = 0; + +// CHECK-LP: func(id/**/ inProxy); + +// CHECK-LP: bar((id /**/)a); + -- cgit v1.2.3