From 04b78412ad0aa74876341a96ba6178175d537ab3 Mon Sep 17 00:00:00 2001 From: David Majnemer Date: Mon, 29 Dec 2014 10:29:53 +0000 Subject: Sema: Permit array l-values in asm output operands GCC permits array l-values in asm output operands even though they aren't modifiable l-values. We used to permit it but this behavior regressed in r224916. llvm-svn: 224918 --- clang/lib/Sema/SemaStmtAsm.cpp | 3 +++ clang/test/SemaCXX/statements.cpp | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/clang/lib/Sema/SemaStmtAsm.cpp b/clang/lib/Sema/SemaStmtAsm.cpp index 24a91716cb8..afd785c5dfb 100644 --- a/clang/lib/Sema/SemaStmtAsm.cpp +++ b/clang/lib/Sema/SemaStmtAsm.cpp @@ -156,6 +156,9 @@ StmtResult Sema::ActOnGCCAsmStmt(SourceLocation AsmLoc, bool IsSimple, case Expr::MLV_Valid: // Cool, this is an lvalue. break; + case Expr::MLV_ArrayType: + // This is OK too. + break; case Expr::MLV_LValueCast: { const Expr *LVal = OutputExpr->IgnoreParenNoopCasts(Context); if (!getLangOpts().HeinousExtensions) { diff --git a/clang/test/SemaCXX/statements.cpp b/clang/test/SemaCXX/statements.cpp index 22648f3a081..efca37dcba1 100644 --- a/clang/test/SemaCXX/statements.cpp +++ b/clang/test/SemaCXX/statements.cpp @@ -30,3 +30,7 @@ void test4(int) { // expected-note{{possible target for call}} // expected-error@+1{{overloaded function could not be resolved}} __asm__ ("":"+r" (test4)); // expected-error{{invalid lvalue in asm output}} } +void test5() { + char buf[1]; + __asm__ ("":"+r" (buf)); +} -- cgit v1.2.3