summaryrefslogtreecommitdiffstats
path: root/openmp/runtime
Commit message (Collapse)AuthorAgeFilesLines
...
* Improve OMPT initialization codeJonathan Peyton2015-11-054-10/+26
| | | | | | | | | | | | | | | | | Use of #ifdef OMPT_DEBUG was causing messages to be generated under normal operation when the OpenMP library was compiled with KMP_DEBUG enabled. Elsewhere, KMP_DEBUG evaluates assertions, but never produces messages during normal operation. To avoid this inconsistency, set OMPT_DEBUG using a cmake variable LIBOMP_OMPT_DEBUG. While I was editing the associated ompt-specific.h and ompt-general.c files, make the spacing and comments consistent. Patch by John Mellor-Crummey Differential Revision: http://reviews.llvm.org/D14355 llvm-svn: 252173
* Remove incorrect debug assert.Jonathan Peyton2015-11-041-1/+0
| | | | | | in __kmp_free_team(), the team's number of processors can be == 1. llvm-svn: 252086
* Remove some empty lines.Jonathan Peyton2015-11-045-21/+0
| | | | llvm-svn: 252084
* Refactor of task_team code.Jonathan Peyton2015-11-045-242/+131
| | | | | | | | | | This is a refactoring of the task_team code that more elegantly handles the two task_team case. Two task_teams per team are kept in use for the lifetime of the team. Thus no reference counting is needed. Differential Revision: http://reviews.llvm.org/D13993 llvm-svn: 252082
* [OPENMP] Add dependency to clang/clang-headers etc. for in-tree build of libomp.Alexey Bataev2015-11-024-7/+6
| | | | | | | Add additional dependency to clang/clang-headers/FileCheck to avoid possible troubles with in-tree build/test of libomp + allow parallel testing of libomp. Also includes bugfixes for tests + improvements to avoid possible race conditions. Differential Revision: http://reviews.llvm.org/D14055 llvm-svn: 251797
* [OMPT] Adding missing free() calls to ompt_tool_windows() function.Jonathan Peyton2015-10-301-0/+4
| | | | llvm-svn: 251719
* [OMPT] Windows Support for OMPTJonathan Peyton2015-10-297-11/+125
| | | | | | | | | | | | | | | | | | | | | | | | | | | The problem is that the ompt_tool() function (which must be implemented by a performance tool) should be defined in the RTL as well to cover the case when the tool is not present in the address space of the process. This functionality is accomplished with weak symbols in Unices. Unfortunately, Windows does not support weak symbols. The solution in these changes is to grab the list of all modules loaded by the process and then search for symbol "ompt_tool()" within them. The function ompt_tool_windows() performs the search of the ompt_tool symbol. If ompt_tool is found, then its return value is used to initialize the tool. If ompt_tool is not found, then ompt_tool_windows() returns NULL and OMPT is thus, disabled. While doing these changes, the OMPT_SUPPORT detection in CMake was changed to test for the required featuers for OMPT_SUPPORT, namely: builtin_frame_address() existence, weak attribute existence and psapi.dll existence. For LIBOMP_HAVE_OMPT_SUPPORT to be true, it must be that the builtin_frame_address() intrinsic exists AND one of: either weak attributes exist or psapi.dll exists. Also, since Process Status API is used I had to add new dependency -- psapi.dll to the library dependency micro test. Differential Revision: http://reviews.llvm.org/D14027 llvm-svn: 251654
* Removed zeroing th.th_task_state for master thread at start of nested parallel.Jonathan Peyton2015-10-201-9/+7
| | | | | | | | | | | The th.th_task_state for the master thread at the start of a nested parallel should not be zeroed in __kmp_allocate_team() because it is later put in the stack of states in __kmp_fork_call() for further re-use after exiting the nested region. It is zeroed after being put in the stack. Differential Revision: http://reviews.llvm.org/D13702 llvm-svn: 250847
* Removed '@' from delimiters, added it as offset designator.Jonathan Peyton2015-10-202-24/+77
| | | | | | | | | | | | Moved '@' from delimiters to offset designators for the KMP_PLACE_THREADS environment variable. Only one of: postfix "o" or prefix @, should be used in the value of KMP_PLACE_THREADS. For example, '2s@2,4c@2,1t'. This is also the format of KMP_SETTINGS=1 output now (removed "o" from there). e.g., 2s,2o,4c,2o,1t. Differential Revision: http://reviews.llvm.org/D13701 llvm-svn: 250846
* Fix OMP_PLACES negation operator parsing (!place)Jonathan Peyton2015-10-191-1/+1
| | | | | | | Just moved the *scan++ line up before the recursive call. Otherwise, infinite recursion occurs and leads to a segmentation fault. llvm-svn: 250729
* Clean-up cancellation state flag between parallel regionsJonathan Peyton2015-10-191-0/+4
| | | | | | | | Without this fix, cancellation requests in one parallel region cause cancellation of the second region even though the second one was not intended to be cancelled. llvm-svn: 250727
* On FreeBSD, PTHREADS_THREADS_MAX does not fit into an int, leading toDimitry Andric2015-10-191-2/+2
| | | | | | | | | | | | | | | | | | | | warnings similar to the following: runtime/src/kmp_global.c:117:35: warning: implicit conversion from 'unsigned long' to 'int' changes value from 18446744073709551615 to -1 [-Wconstant-conversion] int __kmp_sys_max_nth = KMP_MAX_NTH; ~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~ runtime/src/kmp.h:849:34: note: expanded from macro 'KMP_MAX_NTH' # define KMP_MAX_NTH PTHREAD_THREADS_MAX ^~~~~~~~~~~~~~~~~~~ Clamp KMP_MAX_NTH to INT_MAX to avoid these warnings. Also use INT_MAX whenever PTHREAD_THREADS_MAX is not defined at all. Differential Revision: http://reviews.llvm.org/D13827 llvm-svn: 250708
* [OMPT] Add OMPT events for API lockingJonathan Peyton2015-10-164-73/+142
| | | | | | | | | | | | | | | | | | | | | This fix implements the following OMPT events for the API locking routines: * ompt_event_acquired_lock * ompt_event_acquired_nest_lock_first * ompt_event_acquired_nest_lock_next * ompt_event_init_lock * ompt_event_init_nest_lock * ompt_event_destroy_lock * ompt_event_destroy_nest_lock For the acquired events the depths of the locks ist required, so a return value was added similiar to the return values we already have for the release lock routines. Patch by Tim Cramer Differential Revision: http://reviews.llvm.org/D13689 llvm-svn: 250526
* Detect final task in GOMP interface.Jonathan Peyton2015-10-131-0/+4
| | | | llvm-svn: 250198
* [OPENMP][TESTSUITE] Undefined variable in test omp_task_final.cJonathan Peyton2015-10-121-1/+1
| | | | | | | | Patch by Alexey Bataev Differential Revision: http://reviews.llvm.org/D13661 llvm-svn: 250066
* [OMPT] Reduce overhead of OMPTJonathan Peyton2015-10-093-6/+14
| | | | | | | | | | | * Avoid computing state needed only by OMPT unless the ompt_enabled flag is set. * Properly handle a corner case in OMPT where team == NULL. Patch by John Mellor-Crummey Differential Revision: http://reviews.llvm.org/D13502 llvm-svn: 249857
* [OMPT] Initialize task fields only if neededJonathan Peyton2015-10-092-20/+12
| | | | | | | | | | | | | | Because __kmp_task_init_ompt is called for every initial task in each thread and always generated task ids, this was a big performance issue on bigger systems even without any tool attached. After changing the initialization interface to ompt_tool, we can now rely on already knowing whether a tool is attached and OMPT is enabled at this point. Patch by Jonas Hahnfeld Differential Revision: http://reviews.llvm.org/D13494 llvm-svn: 249855
* Formatting/Whitespace/Comment changes associated with wait/release improvements.Jonathan Peyton2015-10-086-39/+36
| | | | llvm-svn: 249725
* Debug trace and assert statement changes for wait/release improvements.Jonathan Peyton2015-10-084-26/+28
| | | | | | | These changes improve/update the trace messages and debug asserts related to the previous wait/release checkin. llvm-svn: 249717
* OpenMP Wait/release improvements.Jonathan Peyton2015-10-085-41/+51
| | | | | | | | | | These changes improve the wait/release mechanism for threads spinning in barriers that are handling tasks while spinnin by providing feedback to the barriers about any task stealing that occurs. Differential Revision: http://reviews.llvm.org/D13353 llvm-svn: 249711
* Added sockets to the syntax of KMP_PLACE_THREADS environment variable.Jonathan Peyton2015-10-086-104/+221
| | | | | | | | | | | | | | | | | | | Added (optional) sockets to the syntax of the KMP_PLACE_THREADS environment variable. Some limitations: * The number of sockets and then optional offset should be specified first (before other parameters). * The letter designation is mandatory for sockets and then for other parameters. * If number of cores is specified first, then the number of sockets is defaulted to all sockets on the machine; also, the old syntax is partially supported if sockets are skipped. * If number of threads per core is specified first, then the number of sockets and cores per socket are defaulted to all sockets and all cores per socket respectively. * The number of cores per socket cannot be specified before sockets or after threads per core. * The number of threads per core can be specified before or after core-offset (old syntax required it to be before core-offset); * Parameters delimiter can be: empty, comma, lower-case x; * Spaces are allowed around numbers, around letters, around delimiter. Approximate shorthand specification: KMP_PLACE_THREADS="[num_sockets(S|s)[[delim]offset(O|o)][delim]][num_cores_per_socket(C|c)[[delim]offset(O|o)][delim]][num_threads_per_core(T|t)]" Differential Revision: http://reviews.llvm.org/D13175 llvm-svn: 249708
* Fix memory corruption in Windows debug libraryJonathan Peyton2015-09-252-6/+6
| | | | | | | | This patch adjusts the buffer size when reducing the buffer used for printing. This solves the memory corruption in Windows debug library, and potential memory corruption in other builds. llvm-svn: 248588
* [OpenMP Testsuite] Change omp_get_wtime.c timer resolution to 3 percentJonathan Peyton2015-09-241-1/+1
| | | | llvm-svn: 248501
* [OpenMP Testsuite] Mac rpath specified when compiling testsJonathan Peyton2015-09-242-2/+1
| | | | llvm-svn: 248500
* Fix stats build problem.Jonathan Peyton2015-09-242-4/+1
| | | | | | | | This change removes the KMP_STATS_ENABLED macro inside kmp_stats.cpp since it is only compiled anyways when LIBOMP_STATS=on. Also, include kmp_config.h in kmp_stats.h to ensure KMP_STATS_ENABLED is defined. llvm-svn: 248494
* Update Reference.pdf files.Jonathan Peyton2015-09-232-5855/+6168
| | | | | | | This updates the Reference.pdf files to say LLVM OpenMP Runtime Library and also updates the build documentation to show how to build with CMake. llvm-svn: 248407
* OpenMP Initial testsuite change to purely llvm-lit based testingJonathan Peyton2015-09-2173-0/+5992
| | | | | | | | | | | | | | | This change introduces a check-libomp target which is based upon llvm's lit test infrastructure. Each test (generated from the University of Houston's OpenMP testsuite) is compiled and then run. For each test, an exit status of 0 indicates success and non-zero indicates failure. This way, FileCheck is not needed. I've added a bit of logic to generate symlinks (libiomp5 and libgomp) in the build tree so that gcc can be tested as well. When building out-of- tree builds, the user will have to provide llvm-lit either by specifying -DLIBOMP_LLVM_LIT_EXECUTABLE or having llvm-lit in their PATH. Differential Revision: http://reviews.llvm.org/D11821 llvm-svn: 248211
* Use sysconf for the number of cores on FreeBSD too.Joerg Sonnenberger2015-09-211-13/+2
| | | | llvm-svn: 248209
* Complex division requires libm on NetBSD, add it.Joerg Sonnenberger2015-09-211-0/+3
| | | | llvm-svn: 248207
* Add basic NetBSD support.Joerg Sonnenberger2015-09-216-15/+25
| | | | llvm-svn: 248204
* Teach the Perl modules about NetBSD.Joerg Sonnenberger2015-09-212-1/+6
| | | | llvm-svn: 248203
* libomp on NetBSD needs libc, libpthread and libm.Joerg Sonnenberger2015-09-211-0/+2
| | | | llvm-svn: 248200
* Assume that all Unix-like systems will want to handle signals andJoerg Sonnenberger2015-09-211-1/+1
| | | | | | simplify conditional. llvm-svn: 248199
* Darwin is the exception when it comes to accessing environ, all otherJoerg Sonnenberger2015-09-211-4/+2
| | | | | | Unix-like systems can follow the same code path. llvm-svn: 248198
* [OMPT] Simplify control variable logic for OMPTJonathan Peyton2015-09-2112-157/+122
| | | | | | | | | | | | | | | Prior to this change, OMPT had a status flag ompt_status, which could take several values. This was due to an earlier OMPT design that had several levels of enablement (ready, disabled, tracking state, tracking callbacks). The current OMPT design has OMPT support either on or off. This revision replaces ompt_status with a boolean flag ompt_enabled, which simplifies the runtime logic for OMPT. Patch by John Mellor-Crummey Differential Revision: http://reviews.llvm.org/D12999 llvm-svn: 248189
* [OMPT] Overhaul OMPT initialization interfaceJonathan Peyton2015-09-219-158/+195
| | | | | | | | | | | | | | | | | | | | | | | | The OMPT specification has changed. This revision brings the LLVM OpenMP implementation up to date. Technical overview of changes: Previously, a public weak symbol ompt_initialize was called after the OpenMP runtime is initialized. The new interface calls a global weak symbol ompt_tool prior to initialization. If a tool is present, ompt_tool returns a pointer to a function that matches the signature for ompt_initialize. After OpenMP is initialized the function pointer is called to initialize a tool. Knowing that OMPT will be enabled before initialization allows OMPT support to be initialized as part of initialization instead of back patching initialization of OMPT support after the fact. Post OpenMP initialization support has been generalized moves from ompt-specific.c into ompt-general.c, since the OMPT initialization logic is no longer implementation specific. Patch by John Mellor-Crummey Differential Revision: http://reviews.llvm.org/D12998 llvm-svn: 248187
* Fix the OpenMP 3.0 buildJonathan Peyton2015-09-217-6/+25
| | | | | | | | | | | This change adds guards to the code in places where they are missing to enable the OpenMP 3.0 build. Patch by Diego Caballero and Johnny Peyton Mailing List: http://lists.llvm.org/pipermail/openmp-dev/2015-September/000935.html llvm-svn: 248178
* [OMPT] Correct an incorrect OMPT ifdef Jonathan Peyton2015-09-181-1/+1
| | | | | | | | | | | An ifdef for OMPT_TRACE needs to be OMPT_BLAME so that both instances of a callback are controlled by the same ifdef. Patch by John Mellor-Crummey Differential Revision: http://reviews.llvm.org/D12911 llvm-svn: 248001
* Force the readelf call to be in EnglishSylvestre Ledru2015-09-161-0/+5
| | | | | | | | | | | | Summary: For example, when readelf is called on a french localization, it will find "Librairie partagées" instead of "shared library" Reviewers: AndreyChurbanov, jcownie Differential Revision: http://reviews.llvm.org/D12902 llvm-svn: 247787
* Removing the Makefile/Perl build system.Jonathan Peyton2015-09-1431-7277/+30
| | | | | | | | | | | | This change deletes the Makefile+Perl build system and all files used by it which aren't used by the CMake build system. This included many Perl files, *.mk files, iomp* files. This change also updates the README's and index.html to instruct the user to use the CMake build system. All mentioning of the Perl+Makefile based system are removed. Differential Revision: http://reviews.llvm.org/D12331 llvm-svn: 247583
* [OMPT] Fix assertion that arises when waiting for proxy tasks on runtime ↵Jonathan Peyton2015-09-102-11/+19
| | | | | | | | | | | | | | shutdown This only triggered when built in debug mode with OMPT enabled: __kmp_wait_template expected the state of the current thread to be either ompt_state_idle or ompt_state_wait_barrier{,_implicit,_explicit}. Patch by Jonas Hahnfeld Differential Revision: http://reviews.llvm.org/D12754 llvm-svn: 247339
* Fix depth field bug and resize() function in hierarchical barrierJonathan Peyton2015-09-102-12/+26
| | | | | | | | | | | This is a follow up to the hierarchy cleanup patch. Added some clarifying comments to hierarchy_info. Fixed a bug with the depth field not being updated cleanly during a resize. Fixed resize to first check capacity as determined by maxLevels before actually doing the full resize. Differential Revision: http://reviews.llvm.org/D12562 llvm-svn: 247333
* Cleanup of affinity hierarchy code.Jonathan Peyton2015-09-104-456/+310
| | | | | | | | | | | | Some of this is improvement to code suggested by Hal Finkel. Four changes here: 1.Cleanup of hierarchy code to handle all hierarchy cases whether affinity is available or not 2.Separated this and other classes and common functions out to a header file 3.Added a destructor-like fini function for the hierarchy (and call in __kmp_cleanup) 4.Remove some redundant code that is hopefully no longer needed Differential Revision: http://reviews.llvm.org/D12449 llvm-svn: 247326
* Fix hanging barriers if number of parallel regions exceeds UINT_MAXJonathan Peyton2015-09-104-24/+24
| | | | | | | | | | The fix is to make b_arrived flag 64 bit in both structures - kmp_balign_team_t and kmp_balign_t. Otherwise when flag in kmp_balign_team_t wrapped over UINT_MAX the library hangs. Differential Revision: http://reviews.llvm.org/D12563 llvm-svn: 247320
* Remove duplicate of num_threads assignment.Jonathan Peyton2015-09-021-1/+0
| | | | | | | The th.th_team_nproc is assigned in __kmp_allocate_thread() just 3 lines above, so there is no need to assign the same value again. llvm-svn: 246703
* Remove fork_context argument from __kmp_join_call() when OMPT is offJonathan Peyton2015-08-314-7/+28
| | | | | | | | | Conditionally include the fork_context parameter to __kmp_join_call() only if OMPT_SUPPORT=1 Differential Revision: http://reviews.llvm.org/D12495 llvm-svn: 246460
* Follow up to r246426 (Break Fortran Module Files build)Jonathan Peyton2015-08-311-6/+7
| | | | | | | The CMAKE_CURRENT_BINARY_DIR is only necessary on the DEPENDS part of the add_custom_command to build the Fortran Modules. llvm-svn: 246448
* D12403: Fix GCC warning 'always_inline function might not be inlinable'Andrey Churbanov2015-08-313-3/+6
| | | | llvm-svn: 246434
* Fix for Fortran modules build (from C.Bergstrom)Andrey Churbanov2015-08-311-6/+6
| | | | llvm-svn: 246426
* Add kmp_config.h.cmakeJonathan Peyton2015-08-281-0/+92
| | | | | | | In r246314 (Removing expand-vars.pl) patch, I forgot to add kmp_config.h.cmake This patch just adds it. llvm-svn: 246317
OpenPOWER on IntegriCloud