summaryrefslogtreecommitdiffstats
path: root/openmp/runtime/src
Commit message (Collapse)AuthorAgeFilesLines
...
* D11301: Remove the __kmp_invoke_microtask() that relies on libffiAndrey Churbanov2015-08-051-55/+1
| | | | llvm-svn: 244031
* D11159: Fixing the stack offset functionalityAndrey Churbanov2015-08-051-3/+8
| | | | llvm-svn: 244030
* Patch out a fatal assertion in OpenMP runtime until preconditions are metJonathan Peyton2015-07-231-0/+4
| | | | | | | | | | | | | | Compiling simple testcase with g++ and linking it to the LLVM OpenMP runtime compiled in debug mode trips an assertion that produces a fatal error. When the assertion is skipped, the program runs successfully to completion and produces the same answer as the sequential code. Intel will restore the assertion with a patch that fixes the issues that cause it to trip. Patch by John Mellor-Crummey Differential Revision: http://reviews.llvm.org/D11269 llvm-svn: 243032
* Fix OMPT support for task frames, parallel regions, and parallel regions + loopsJonathan Peyton2015-07-218-34/+167
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch makes it possible for a performance tool that uses call stack unwinding to map implementation-level call stacks from master and worker threads into a unified global view. There are several components to this patch. include/*/ompt.h.var Add a new enumeration type that indicates whether the code for a master task for a parallel region is invoked by the user program or the runtime system Change the signature for OMPT parallel begin/end callbacks to indicate whether the master task will be invoked by the program or the runtime system. This enables a performance tool using call stack unwinding to handle these two cases differently. For this case, a profiler that uses call stack unwinding needs to know that the call path prefix for the master task may differ from those available within the begin/end callbacks if the program invokes the master. kmp.h Change the signature for __kmp_join_call to take an additional parameter indicating the fork_context type. This is needed to supply the OMPT parallel end callback with information about whether the compiler or the runtime invoked the master task for a parallel region. kmp_csupport.c Ensure that the OMPT task frame field reenter_runtime_frame is properly set and cleared before and after calls to fork and join threads for a parallel region. Adjust the code for the new signature for __kmp_join_call. Adjust the OMPT parallel begin callback invocations to carry the extra parameter indicating whether the program or the runtime invokes the master task for a parallel region. kmp_gsupport.c Apply all of the analogous changes described for kmp_csupport.c for the GOMP interface Add OMPT support for the GOMP combined parallel region + loop API to maintain the OMPT task frame field reenter_runtime_frame. kmp_runtime.c: Use the new information passed by __kmp_join_call to adjust the OMPT parallel end callback invocations to carry the extra parameter indicating whether the program or the runtime invokes the master task for a parallel region. ompt_internal.h: Use the flavor of the parallel region API (GNU or Intel) to determine who invokes the master task. Differential Revision: http://reviews.llvm.org/D11259 llvm-svn: 242817
* Re-indent the CMake refactor to two-space indentionJonathan Peyton2015-07-151-177/+177
| | | | | | | | | | | I apologize for this nasty commit, but I somehow overlooked Chandler's comment to re-indent these files to two space indention. I know this is a horrible commit, but I figured if it was done quickly after the first one, not too many conflicts would arise. Again, I'm sorry and won't do this again. llvm-svn: 242301
* Large Refactor of CMake build systemJonathan Peyton2015-07-151-265/+241
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit improves numerous functionalities of the OpenMP CMake build system to be more conducive with LLVM's build system and build philosophies. The CMake build system, as it was before this commit, was not up to LLVM's standards and did not implement the configuration stage like most CMake based build systems offer (check for compiler flags, libraries, etc.) In order to improve it dramatically in a short period of time, a large refactoring had to be done. The main changes done with this commit are as follows: * Compiler flag checks - The flags are no longer grabbed from compiler specific directories. They are checked for availability in config-ix.cmake and added accordingly inside LibompHandleFlags.cmake. * Feature checks were added in config-ix.cmake. For example, the standard CMake module FindThreads is probed for the threading model to use inside the OpenMP library. * OS detection - There is no longer a LIBOMP_OS variable, OS-specifc build logic is wrapped around the WIN32 and APPLE macros with !(WIN32 OR APPLE) meaning a Unix flavor of some sort. * Got rid of vestigial functions/macros/variables * Added new libomp_append() function which is used everywhere to conditionally or undconditionally append to a list * All targets have the libomp prefix so as not to interfere with any other project * LibompCheckLinkerFlag.cmake module was added which checks for linker flags specifically for building shared libraries. * LibompCheckFortranFlag.cmake module was added which checks for fortran flag availability. * Removed most of the cruft from the translation between the perl+Makefile based build system and this one. The remaining components that they share are perl scripts which I'm in the process of removing. There is still more left to do. The perl scripts still need to be removed, and a config.h.in file (or similarly named) needs to be added with #cmakedefine lines in it. But this is a much better first step than the previous system. Differential Revision: http://reviews.llvm.org/D10656 llvm-svn: 242298
* Rename OMPT placeholder type names to be in the OMPT name spaceJonathan Peyton2015-07-143-15/+15
| | | | | | | | | | | | r242052 changed the name of OMPT placeholder functions to move them from the omp_ name space to the ompt_ name space. This patch moves the names of the types of these functions into the OMPT name space as well. Patch by John Mellor-Crummey Differential Revision: http://reviews.llvm.org/D11171 llvm-svn: 242155
* Fix some bugs in OMPT supportJonathan Peyton2015-07-138-35/+80
| | | | | | | | | | | | | | | | | | | | | | | 1.) in kmp_csupport.c, move computation of parameters only needed for OMPT tracing inside a conditional to reduce overhead if not receiving ompt_event_master_begin callbacks. 2.) in kmp_gsupport.c, remove spurious reset of OMPT reenter_runtime_frame (which is set in its caller, GOMP_parallel_start correct placement of #if OMP_TRACE so that state is maintained even if tracing support not included. 3.) in z_Linux_util.c, add architecture independent support for OMPT by setting and resetting OMPT's exit_frame_ptr before and after invoking a microtask. 4.) On the Intel MIC, the loader refuses to retain static symbols in the libomp.so shared library, even though tools need them. The loader could not be bullied into doing so. To accommodate this, I changed the visibility of OMPT placeholder functions to public. This required additions in exports.so.txt, adding extern "C" scoping in ompt-general.c so that the public placeholder symbols won't be mangled. Patch by John Mellor-Crummey Differential Revision: http://reviews.llvm.org/D11062 llvm-svn: 242052
* fixed typo in debug assertion reported by John Mellor-CrummeyAndrey Churbanov2015-07-131-1/+1
| | | | llvm-svn: 242043
* Follow up to safe API patchJonathan Peyton2015-07-092-4/+2
| | | | | | | | | | | | | | A while back, we made an initial change where dangerous C API functions were replaced with macros that translated the dangerous API function calls to safer function calls e.g., sprintf() replaced with KMP_SPRINTF() which translates to sprintf_s() on Windows. Currently, the only operating system where this is applicable is Windows. Unix-like systems are still using the dangerous API e.g., KMP_SPRINTF() translates to sprintf(). Our own testing showed no performance differences. Differential Revision: http://reviews.llvm.org/D9918 llvm-svn: 241833
* Enable debugger supportJonathan Peyton2015-07-099-6/+456
| | | | | | | | | | | | These changes enable external debuggers to conveniently interface with the LLVM OpenMP Library. Structures are added which describe the important internal structures of the OpenMP Library e.g., teams, threads, etc. This feature is turned on by default (CMake variable LIBOMP_USE_DEBUGGER) and can be turned off with -DLIBOMP_USE_DEBUGGER=off. Differential Revision: http://reviews.llvm.org/D10038 llvm-svn: 241832
* Fix OMPT event_barrer_endJonathan Peyton2015-07-011-1/+1
| | | | | | | | | | | | The OMPT status is never equal to ompt_status_track. ompt_status_track = 0x2 and ompt_status_track_callback = 0x6 just share a bit, so that we can check for traceing and callbacks with the same status. Patch by Tim Cramer Differential Revision: http://reviews.llvm.org/D10863 llvm-svn: 241167
* Remove _KMP_BUILD_TIME macro from kmp_version.cJonathan Peyton2015-06-291-1/+1
| | | | | | | | At the suggestion of Chandler Carruth, I've removed the timestamp macro, _KMP_BUILD_TIME, that cmake currently sets to "No_Timestamp" and replaced it with standard __DATE__ and __TIME__ macros inside kmp_version.c. llvm-svn: 240985
* Remove use of assignment to multiple struct fields using .fieldname (OMPT)Jonathan Peyton2015-06-291-6/+4
| | | | | | | | | | | Remove use of assignment to multiple struct fields using .fieldname syntax. This doesn't work with gcc 4.8 and earlier. Replace with elementwise field assignments. Patch by John Mellor-Crummey Differential Revision: http://reviews.llvm.org/D10798 llvm-svn: 240972
* Fix OMPT state maintenance for barriers and missing init of implicit task id.Jonathan Peyton2015-06-292-7/+18
| | | | | | | | | | | | | | | | | | Fix OMPT support for barriers so that state changes occur even if OMPT_TRACE turned off. These state changes are needed by performance tools that use callbacks for either ompt_event_wait_barrier_begin or ompt_event_wait_barrier_end. Change ifdef flag to OMPT_BLAME for callbacks ompt_event_wait_barrier_begin or ompt_event_wait_barrier_end rather than OMPT_TRACE -- they were misclassified. Without this patch, when the runtime is compiled with LIBOMP_OMPT_SUPPORT=true, LIBOMP_OMPT_BLAME=true, and LIBOMP_OMPT_TRACE=false, and a callback is registered for either ompt_event_wait_barrier_begin or ompt_event_wait_barrier_end, then an assertion will trip. Fix the scoping of one OMPT_TRACE ifdef, which should not have surrounded an update of an OMPT state. Add a missing initialization of an OMPT task id for an implicit task. Patch by John Mellor-Crummey Differential Revision: http://reviews.llvm.org/D10759 llvm-svn: 240970
* Allow machine hierarchy expansionJonathan Peyton2015-06-221-10/+78
| | | | | | | | | This fix allows the machine hierarchy to be expanded in case it needs to handle more threads. It adds a resize function to accomplish this. Differential Revision: http://reviews.llvm.org/D9900 llvm-svn: 240292
* Re-enable Visual Studio Builds.Jonathan Peyton2015-06-222-7/+4
| | | | | | | | | I tried to compile with Visual Studio using CMake and found these two sections of code causing problems for Visual Studio. The first one removes the use of variable length arrays by instead using KMP_ALLOCA(). The second part eliminates a redundant cpuid assembly call by using the already existing __kmp_x86_cpuid() call instead. llvm-svn: 240290
* Remove unused variables '__kmp_build_check_*' for non assert builds.Jonathan Peyton2015-06-111-1/+5
| | | | | | | | | | | | Add new LIBOMP_ENABLE_ASSERTIONS macro which can be set in a standalone build or takes the value of LLVM_ENABLE_ASSERTIONS when inside llvm/projects. This change also defines the KMP_BUILD_ASSERT() macro to do nothing when ENABLE_ASSERTIONS is off. This means the __kmp_build_check_* types won't be defined and thus, no warnings. http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-June/000719.html Patch by Jack Howarth and Jonathan Peyton llvm-svn: 239546
* Implement recursive CMake.Jonathan Peyton2015-06-111-0/+339
| | | | | | | | | | | | | | Most CMake build systems put CMakeLists.txt files inside source directories where items need to get built. This change follows that convention by adding a new runtime/src/CMakeLists.txt file. An additional benefit is this helps logically seperate configuring with building as well. This change is mostly just copying and pasting the bottom half of runtime/CMakeLists.txt into runtime/src/CMakeLists.txt, but a few changes had to be made to get it to work. Most of those changes were to directory prefixes. Differential Revision: http://reviews.llvm.org/D10344 llvm-svn: 239542
* Remove unused variables '__kmp_build_check_*'Jonathan Peyton2015-06-081-1/+1
| | | | | | | | | | As an ongoing effort to sanitize the openmp code, this one word change eliminates creating 1 byte arrays named __kmp_build_check_* and instead creates one byte array types. The KMP_BUILD_ASSERT macro still offers the same functionality; array types with negative number of elements is illegal and will cause a compiler failure. llvm-svn: 239337
* Remove unused variable warnings by deletion.Jonathan Peyton2015-06-0811-54/+2
| | | | | | | | | | As an ongoing effort to sanitize the openmp code, these changes delete variables that aren't used at all. http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-June/000701.html Patch by Jack Howarth llvm-svn: 239334
* Remove unused variable warnings by moving variables.Jonathan Peyton2015-06-082-5/+5
| | | | | | | | | As an ongoing effort to sanitize the openmp code, these changes move variables under already existing macro guards. Patch by Jack Howarth llvm-svn: 239331
* Remove unused variable warnings by adding proper macro guards.Jonathan Peyton2015-06-088-2/+27
| | | | | | | | | As an ongoing effort to sanitize the openmp code, these changes remove unused variables by adding proper macros around both variables and functions. Patch by Jack Howarth llvm-svn: 239330
* Remove unused variable warnings by fooling compiler.Jonathan Peyton2015-06-086-11/+28
| | | | | | | | | | Some variables are convenient to keep around even if they aren't really used in a release build. This is often seen in DEBUG guarded code where the variable is only used in a DEBUG build. Patch by Jack Howarth llvm-svn: 239326
* Removed unused functions.Jonathan Peyton2015-06-082-123/+0
| | | | | | | | | | | As an ongoing effort to sanitize the openmp code, these changes remove unused functions. The unused functions are: __kmp_fini_allocator_thread(), __kmp_env_isDefined(), __kmp_strip_quotes(), __kmp_convert_to_seconds(), and __kmp_convert_to_nanoseconds(). Patch by Jack Howarth llvm-svn: 239323
* Fix extern warnings produced by ittnotify_static.cJonathan Peyton2015-06-052-4/+8
| | | | | | | | | | | | | | | when compiling with gcc or clang numerous warnings concerning the usage of extern "C" linkage. All the __kmp_itt_sync* variables are declared like: extern "C" type __kmp_itt_sync... = definition; through various macros. This note from cppreference.com explains why this is a problem. // From http://en.cppreference.com/w/cpp/language/language_linkage extern "C" int x; // a declaration and not a definition // The above line is equivalent to extern "C" { extern int x; } extern "C" { int x; } // a declaration and definition Since the __kmp_itt_* variables are being declared and defined, these variables should use the bracketed version instead. llvm-svn: 239184
* Fix some sign compare warnings.Jonathan Peyton2015-06-044-15/+10
| | | | | | | | | This change changes kmp_bstate.old_tid to sign integer instead of unsigned integer. It also defines two new macros KMP_NSEC_PER_SEC and KMP_USEC_PER_SEC which lets us take control of the sign (we want them to be longs). Also, in kmp_wait_release.h, the byteref() function's return type is changed from char to unsigned char. llvm-svn: 239057
* Suppress uninitialized-variable-is-used warning in kmp_csupport.cJonathan Peyton2015-06-031-2/+2
| | | | | | | | | | | The following change is needed to suppress the "variable 'retval' is used uninitialized whenever 'if' condition is false" warnings in runtime/src/kmp_csupport.c. This change just initializes 'retval' to 0. http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-June/000667.html Patch by Jack Howarth llvm-svn: 238954
* Remove conditional parameters from KA_TRACE macro.Jonathan Peyton2015-06-031-3/+6
| | | | | | | | | It's undefined behavior to have arguments to macros be conditionally preprocessed. http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-June/000669.html Patch by Jack Howarth and Jonathan Peyton llvm-svn: 238950
* Reorder C++ initialization lists to appease compiler.Jonathan Peyton2015-06-031-3/+4
| | | | | | | | | | | in kmp_wait_release.h, there were some constructors where the initialization lists were out of order with the member declarations inside the class. This patch just reorders the initialization list so the compiler doesn't complain. http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-June/000670.html Patch by Jack Howarth and Jonathan Peyton llvm-svn: 238946
* Remove unused variable anonym from kmp_atomic.cJonathan Peyton2015-06-031-1/+0
| | | | | | | | | | There is an anonym variable inside a macro that is declared and defined but never used. This patch removes it. http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-June/000666.html Patch by Jack Howarth and Jonathan Peyton llvm-svn: 238934
* Get rid of some dead code.Jonathan Peyton2015-06-023-11/+8
| | | | | | | | | Some old references to RML and IOMP which aren't used anywhere are deleted. http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-June/000664.html Patch by Jack Howarth and Jonathan Peyton llvm-svn: 238878
* Remove unused KMP_IOMP_NAME macro from kmp.hJonathan Peyton2015-06-021-3/+0
| | | | | | | Getting rid of more iomp references. http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-June/000659.html llvm-svn: 238847
* Change Intel(R) OpenMP* to LLVM* OpenMP* in libomp.rc.varJonathan Peyton2015-06-021-3/+3
| | | | | | Missed some places that referenced the Intel(R) OpenMP* Runtime Library. llvm-svn: 238840
* Apply name change to Makefile build system.Jonathan Peyton2015-06-012-22/+21
| | | | | | | | This change produces a dynamic library named libomp instead of libiomp5. Similar to the CMake change, it produces symlinks of libiomp5 in the exports/ directory for Unix systems and copies for Windows. llvm-svn: 238720
* Apply name change to src/* files.Jonathan Peyton2015-06-019-16/+16
| | | | | | | | | These changes are mostly in comments, but there are a few that aren't. Change libiomp5 => libomp everywhere. One internal function name is changed in kmp_gsupport.c, and in kmp_i18n.c, the static char[] variable 'name' is changed to "libomp". llvm-svn: 238712
* Adding libomp.rc.var for name changeJonathan Peyton2015-06-011-0/+70
| | | | | | | Adding a new file libomp.rc.var in anticipation of more name change commits. This file is a copy of libiomp.rc.var. llvm-svn: 238710
* Allow CMAKE_OSX_ARCHITECTURES to build fat library.Jonathan Peyton2015-05-294-151/+150
| | | | | | | | | | | | | The CMAKE_OSX_ARCHITECTURES CMake variable allows users to build universal fat libraries that contain both i386 and x86_64 code. These changes allow this build by having the z_Linux_asm.s file detect the architecture itself instead of receiving it through the build system. Also, there was a LIBOMP_OSX_ARCHITECTURES CMake variable added to allow people to only build libomp as a fat library and not the entire LLVM/Clang system. http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-May/000626.html llvm-svn: 238566
* Fix comment about balanced affinityJonathan Peyton2015-05-271-1/+1
| | | | | | | | A while back, Hal mentioned fixing a comment concerning balanced affinity. http://lists.cs.uiuc.edu/pipermail/openmp-dev/2014-December/000358.html I forgot about fixing it until now, but now is better than never. llvm-svn: 238378
* Allow gcc 5.x to compile library.Jonathan Peyton2015-05-271-1/+1
| | | | | | | Change check of __GNUC__ macro from: __GNUC__ == 4 to __GNUC__ >= 4 llvm-svn: 238347
* Change macro GUIDEDLL_EXPORTS to KMP_DYNAMIC_LIBJonathan Peyton2015-05-265-11/+11
| | | | | | | | | | A while back, Hal suggested updating the GUIDEDLL_EXPORTS macro guard to a more descriptive name. It represents a dynamic library build so KMP_DYNAMIC_LIB is a more suitable name. Differential Revision: http://reviews.llvm.org/D9899 llvm-svn: 238221
* One line fix for possible out-of-bounds issue in kmp_runtime.cJonathan Peyton2015-05-261-1/+1
| | | | | | | The variable j is now checked so there is no possible out-of-bounds issue when accessing __kmp_nested_nth.nth[] array. llvm-svn: 238216
* One line fix for possible out-of-bounds issue in kmp_error.cJonathan Peyton2015-05-261-2/+2
| | | | | | | This off-by-one error could lead to an out-of-bounds access on the cons_text_c[] array. llvm-svn: 238215
* Fix doxygen commentsJonathan Peyton2015-05-222-8/+6
| | | | | | These fixes make doxygen happy. llvm-svn: 238061
* Fix spelling errorsJonathan Peyton2015-05-228-10/+10
| | | | | | These spelling errors are in comments and some debug messages. llvm-svn: 238060
* One line fix - bug with final clause of task constructJonathan Peyton2015-05-211-1/+1
| | | | | | Should be looking at parent_task->td_flags.final instead of the recently allocated task. llvm-svn: 237959
* Fix task team synchronization Jonathan Peyton2015-05-211-0/+1
| | | | | | | | | | | The fix simply syncs up the new threads to have the same task_state and task_team as the old threads. The master thread is skipped, because it shouldn't at this point have the team's task_team value yet -- it should still have parent_team's task_team. It gets pointed at the new team's task_team later, after __kmp_allocate_team returns, and the master has stored a memo of it's old task_state. llvm-svn: 237916
* Delete old CMake build systemJonathan Peyton2015-05-181-183/+0
| | | | | | | | | Remove runtime/CMakeLists.txt.old and runtime/src/CMakeLists.txt as they no longer worked and were not being kept up to date. Differential Revision: http://reviews.llvm.org/D9756 llvm-svn: 237615
* Small fix to allow FreeBSD build to work.Jonathan Peyton2015-05-151-1/+1
| | | | | | | | | | Add xexpand macro to the FTN_IS_INITIAL_DEVICE api function Patch by Davide Italiano Differential Revision: http://reviews.llvm.org/D9798 llvm-svn: 237472
* Missing file runtime/src/include/41/ompt.h.var added; fixed build to ↵Andrey Churbanov2015-05-122-1/+477
| | | | | | optionally use added file. llvm-svn: 237125
OpenPOWER on IntegriCloud