summaryrefslogtreecommitdiffstats
path: root/mlir
Commit message (Collapse)AuthorAgeFilesLines
...
* Add compatible query method to infer type interfaceJacques Pienaar2019-11-076-10/+59
| | | | | | | | A return type that differs from the inferred return type need not indicate that an operation is invalid (e.g., tensor<*xf32> vs tensor<10xf32>) but they should be compatible for the operation to be considered valid. Add method to query if inferred type is compatible with return type. Also add InferTypeOpIntefaceDefault trait that considers equality and compatibility as the same. Currently an op has to opt in to using it explicitly. PiperOrigin-RevId: 279085639
* Update Linalg to use std.viewNicolas Vasilache2019-11-0717-853/+149
| | | | | | Now that a view op has graduated to the std dialect, we can update Linalg to use it and remove ops that have become obsolete. As a byproduct, the linalg buffer and associated ops can also disappear. PiperOrigin-RevId: 279073591
* Add IndexedGenericOp to Linalg.Alexander Belyaev2019-11-065-33/+169
| | | | PiperOrigin-RevId: 279013404
* NFC: Tidy up the implementation of operations in the Toy tutorialRiver Riddle2019-11-0611-208/+251
| | | | | | Use header blocks to separate operation implementations, and switch the build methods to be out-of-line when possible. PiperOrigin-RevId: 278982913
* NFC: Uniformize parser naming scheme in Toy tutorial to camelCase and tidy a ↵River Riddle2019-11-0636-1306/+1225
| | | | | | bit of the implementation. PiperOrigin-RevId: 278982817
* Replace some remnant uses of "inst" with "op".Sean Silva2019-11-069-59/+56
| | | | PiperOrigin-RevId: 278961676
* Drop spurious test fileNicolas Vasilache2019-11-061-25/+0
| | | | PiperOrigin-RevId: 278959717
* Add lowering of std.view to LLVMNicolas Vasilache2019-11-064-1/+257
| | | | | | | | | | | | | This CL ports the lowering of linalg.view to the newly introduced std.view. Differences in implementation relate to std.view having slightly different semantics: 1. a static or dynamic offset can be specified. 2. the size of the (contiguous) shape is passed instead of a range. 3. static size and stride information is extracted from the memref type rather than the range. Besides these differences, lowering behaves the same. A future CL will update Linalg to use this unified infrastructure. PiperOrigin-RevId: 278948853
* Add affine load/store/dma_start/dma_wait to dialect doc.Andy Davis2019-11-061-0/+136
| | | | PiperOrigin-RevId: 278941483
* Adding an m_NonZero constant integer matcher.Ben Vanik2019-11-062-23/+30
| | | | | | This is useful for making matching cases where a non-zero value is required more readable, such as the results of a constant comparison that are expected to be equal. PiperOrigin-RevId: 278932874
* Add ViewOp verification for dynamic strides, and address some comments from ↵Andy Davis2019-11-064-23/+57
| | | | | | previous change. PiperOrigin-RevId: 278903187
* [DRR] List some limitations clearly in the docLei Zhang2019-11-061-2/+13
| | | | PiperOrigin-RevId: 278882517
* Add ViewOp to the StandardOps dialect, which casts a 1D/i8 element type ↵Andy Davis2019-11-066-4/+228
| | | | | | | | | | | memref type to an N-D memref type. Proposed in RFC: https://groups.google.com/a/tensorflow.org/forum/#!searchin/mlir/std.view%7Csort:date/mlir/-wKHANzDNTg/4K6nUAp8AAAJ Supports creating the N-D memref type with dynamic sizes and at a dynamic offset within the 1D base memref. This change contains op definition/parsing/printing and tests. Follow up changes will handle constant shape/layout map folding and llvm lowering. PiperOrigin-RevId: 278869990
* Add support for the LLVM FNeg instructionEric Schweitz2019-11-063-0/+16
| | | | | | | Closes tensorflow/mlir#216 COPYBARA_INTEGRATE_REVIEW=https://github.com/tensorflow/mlir/pull/216 from schweitzpgi:llvmir-fneg-op f9b5f185845d671b745ab6fc213d5d9aff044b34 PiperOrigin-RevId: 278795325
* NFC: Remove an extra space when printing the 'attributes' prefix before a ↵River Riddle2019-11-051-1/+1
| | | | | | dictionary. PiperOrigin-RevId: 278795313
* Add (parse|print)OptionalAttrDictWithKeyword hooks to simplify parsing ↵River Riddle2019-11-056-45/+51
| | | | | | | | attribute dictionaries with regions. Many operations with regions add an additional 'attributes' prefix when printing the attribute dictionary to differentiate it from the region body. This leads to duplicated logic for detecting when to actually print the attribute dictionary. PiperOrigin-RevId: 278747681
* Fix typos in the Standard Dialect documentationRoberto Rosmaninho2019-11-051-2/+2
| | | | | | | | | | "sgt" and "ult" used twice the second "slt" should be "sge" for signed greater than or equal the second "ult" should be "ule" unsigned less than or equal Closes tensorflow/mlir#223 PiperOrigin-RevId: 278745410
* [llvm] Allow GlobalOp to take a region for complex initializersJames Molloy2019-11-058-29/+184
| | | | | | | | | | | | | | | This allows GlobalOp to either take a value attribute (for simple constants) or a region that can contain IR instructions (that must be constant-foldable) to create a ConstantExpr initializer. Example: // A complex initializer is constructed with an initializer region. llvm.mlir.global constant @int_gep() : !llvm<"i32*"> { %0 = llvm.mlir.addressof @g2 : !llvm<"i32*"> %1 = llvm.mlir.constant(2 : i32) : !llvm.i32 %2 = llvm.getelementptr %0[%1] : (!llvm<"i32*">, !llvm.i32) -> !llvm<"i32*"> llvm.return %2 : !llvm<"i32*"> } PiperOrigin-RevId: 278717836
* [llvm] Add initial import of LLVM modules to mlir-translateJames Molloy2019-11-055-2/+754
| | | | | | | | | | | | | | | | This adds an importer from LLVM IR or bitcode to the LLVM dialect. The importer is registered with mlir-translate. Known issues exposed by this patch but not yet fixed: * Globals' initializers are attributes, which makes it impossible to represent a ConstantExpr. This will be fixed in a followup. * icmp returns i32 rather than i1. * select and a couple of other instructions aren't implemented. * llvm.cond_br takes its successors in a weird order. The testing here is known to be non-exhaustive. I'd appreciate feedback on where this functionality should live. It looks like the translator *from MLIR to LLVM* lives in Target/, but the SPIR-V deserializer lives in Dialect/ which is why I've put this here too. PiperOrigin-RevId: 278711683
* NFC: Rename parseOptionalAttributeDict -> parseOptionalAttrDict to match the ↵River Riddle2019-11-0515-82/+79
| | | | | | name of the print method. PiperOrigin-RevId: 278696668
* Add a PatternRewriter hook to merge blocks, and use it to support for ↵River Riddle2019-11-057-7/+112
| | | | | | | | | | | | | | | | | | | folding branches. A pattern rewriter hook, mergeBlock, is added that allows for merging the operations of one block into the end of another. This is used to support a canonicalization pattern for branch operations that folds the branch when the successor has a single predecessor(the branch block). Example: ^bb0: %c0_i32 = constant 0 : i32 br ^bb1(%c0_i32 : i32) ^bb1(%x : i32): return %x : i32 becomes: ^bb0: %c0_i32 = constant 0 : i32 return %c0_i32 : i32 PiperOrigin-RevId: 278677825
* Emit empty lines after headers when generating op docsLei Zhang2019-11-051-7/+7
| | | | | | | | | This makes the generated doc easier to read and it is also more friendly to certain markdown parsers like kramdown. Fixes tensorflow/mlir#221 PiperOrigin-RevId: 278643469
* Rename Region::RegionType to Region::BlockListTypeSean Silva2019-11-052-10/+10
| | | | | | Region::RegionType doesn't make much sense when reading it. It's just a list of blocks. So call it that. PiperOrigin-RevId: 278632500
* [NVVM] Add mma.sync operation.MLIR Team2019-11-046-3/+213
| | | | PiperOrigin-RevId: 278440547
* Update the SPV dialect type parser to use the methods on DialectAsmParser ↵River Riddle2019-11-017-315/+260
| | | | | | | | directly. This simplifies the implementation quite a bit, and removes the need for explicit string munging. One change is made to some of the enum elements of SPV_DimAttr to ensure that they are proper identifiers; The string form is now prefixed with 'Dim'. PiperOrigin-RevId: 278027132
* Drop spurious debug spew.Nicolas Vasilache2019-11-011-2/+0
| | | | PiperOrigin-RevId: 278023371
* Refactor LinalgDialect::parseType to use the DialectAsmParser methods directly.River Riddle2019-11-014-39/+69
| | | | | | This simplifies the implementation, and removes the need to do explicit string manipulation. A utility method 'parseDimensionList' is added to the DialectAsmParser to simplify defining types and attributes that contain shapes. PiperOrigin-RevId: 278020604
* Refactor QuantOps TypeParser to use the DialectAsmParser methods directly.River Riddle2019-11-015-524/+516
| | | | | | This greatly simplifies the implementation and removes custom parser functionality. The necessary methods are added to the DialectAsmParser. PiperOrigin-RevId: 278015983
* Remove the need for passing a location to parseAttribute/parseType.River Riddle2019-11-0114-56/+120
| | | | | | | | Now that a proper parser is passed to these methods, there isn't a need to explicitly pass a source location. The source location can be recovered from the parser as necessary. This removes the need to explicitly decode an SMLoc in the case where we don't need to, which can be expensive. This requires adding some basic nesting support to the parser for supporting nested parsers to allow for remapping source locations of the nested parsers to the top level parser for accurate diagnostics. This is due to the fact that the attribute and type parsers use different source buffers than the top level parser, as they may be represented in string form. PiperOrigin-RevId: 278014858
* Add DialectAsmParser/Printer classes to simplify dialect attribute and type ↵River Riddle2019-11-0113-111/+413
| | | | | | | | | | | | | | parsing. These classes are functionally similar to the OpAsmParser/Printer classes and provide hooks for parsing attributes/tokens/types/etc. This change merely sets up the base infrastructure and updates the parser hooks, followups will add hooks as needed to simplify existing handrolled dialect parsers. This has various different benefits: *) Attribute/Type parsing is much simpler to define. *) Dialect attributes/types that contain other attributes/types can now use aliases. *) It provides a 'spec' with which we may use in the future to auto-generate parsers/printers. *) Error messages emitted by attribute/type parsers can provide character exact locations rather than "beginning of the string" PiperOrigin-RevId: 278005322
* Add ReferToOp attribute constraint for SymbolRefAttrLei Zhang2019-11-015-1/+37
| | | | | | | This constraint can be used to limit a SymbolRefAttr to point to a specific kind of op in the closest parent with a symbol table. PiperOrigin-RevId: 278001364
* Delete spurious fileNicolas Vasilache2019-11-011-281/+0
| | | | PiperOrigin-RevId: 277967079
* Move BitEnumAttr from SPIRVBase.td to OpBase.tdLei Zhang2019-11-0114-346/+420
| | | | | | | | | | | | | | | | | BitEnumAttr is a mechanism for modelling attributes whose value is a bitfield. It should not be scoped to the SPIR-V dialect and can be used by other dialects too. This CL is mostly shuffling code around and adding tests and docs. Functionality changes are: * Fixed to use `getZExtValue()` instead of `getSExtValue()` when getting the value from the underlying IntegerAttr for a case. * Changed to auto-detect whether there is a case whose value is all bits unset (i.e., zero). If so handle it specially in all helper methods. PiperOrigin-RevId: 277964926
* Support lowering of imperfectly nested loops into GPU dialect.Mahesh Ravishankar2019-11-0112-37/+691
| | | | | | | | | | | | | | | | | | | The current lowering of loops to GPU only supports lowering of loop nests where the loops mapped to workgroups and workitems are perfectly nested. Here a new lowering is added to handle lowering of imperfectly nested loop body with the following properties 1) The loops partitioned to workgroups are perfectly nested. 2) The loop body of the inner most loop partitioned to workgroups can contain one or more loop nests that are to be partitioned across workitems. Each individual loops nests partitioned to workitems should also be perfectly nested. 3) The number of workgroups and workitems are not deduced from the loop bounds but are passed in by the caller of the lowering as values. 4) For statements within the perfectly nested loop nest partitioned across workgroups that are not loops, it is valid to have all threads execute that statement. This is NOT verified. PiperOrigin-RevId: 277958868
* Add Linalg pattern for producer-consumer fusionNicolas Vasilache2019-11-019-32/+543
| | | | | | | | | | | | | | | This CL adds a simple pattern for specifying producer-consumer fusion on Linalg operations. Implementing such an extension reveals some interesting properties. Since Linalg operates on a buffer abstraction, the output buffers are specified as in/out parameters to the ops. As a consequence, there are no SSA use-def chains and one cannot specify complex dag input patterns with the current infrastructure. Instead this CL uses constraints based on the existing linalg dependence analysis to focus the pattern and refine patterns based on the type of op that last wrote in a buffer. This is a very local property and is less powerful than the generic dag specification based on SSA use-def chains. This will be generalized in the future. PiperOrigin-RevId: 277931503
* [mlir][llvm] Add missing cast opsJames Molloy2019-11-013-1/+40
| | | | | | Also adds a builder method for fcmp, identical to that for icmp. PiperOrigin-RevId: 277923158
* NFC: Use #ifndef in various .td files instead of #ifdef and #elseLei Zhang2019-10-3142-186/+93
| | | | | | | | | | Upstream LLVM gained support for #ifndef with https://reviews.llvm.org/D61888 This is changed mechanically via the following command: find . -name "*.td" -exec sed -i -e ':a' -e 'N' -e '$!ba' -e 's/#ifdef \([A-Z_]*\)\n#else/#ifndef \1/g' {} \; PiperOrigin-RevId: 277789427
* Add a test for lowering GPU ops that cover cases where the symbol table ↵Mehdi Amini2019-10-312-0/+45
| | | | | | isn't held by a ModuleOp (NFC) PiperOrigin-RevId: 277752004
* Add a test.symbol_scope operation that has the SymbolTable Traits to the ↵Mehdi Amini2019-10-314-0/+23
| | | | | | Test dialect PiperOrigin-RevId: 277741687
* LinalgDependenceGraph: add const modifiers to accessorsAlex Zinenko2019-10-314-37/+39
| | | | | | | | | | | | | MLIR const-correctness policy is to avoid having `const` on IR objects. LinalgDependenceGraph is not an IR object but an auxiliary data structure. Furthermore, it is not updated once constructed unlike IR objects. Add const qualifiers to get* and find* methods of LinalgDependenceGraph since they are not modifying the graph. This allows transformation functions that require the dependence graph to take it by const-reference, clearly indicating that they are not modifying it (and that the graph may have to be recomputed after the transformation). PiperOrigin-RevId: 277731608
* NFC: Simplify UseRange::iterator to just be a std::vector::const_iterator.River Riddle2019-10-301-20/+4
| | | | | | At some point the implementation of UseRange was more complex, but now it is just a simple wrapper around a std::vector<SymbolUse>. PiperOrigin-RevId: 277597294
* [spirv] Add cast operationsDenis Khalikov2019-10-307-98/+564
| | | | | | | | | | | | | | | | | | | This CL added op definitions for a few cast operations: * OpConvertFToU * OpConvertFToS * OpConvertSToF * OpConvertUToF * OpUConvert * OpSConvert * OpFConvert Also moved the definition of spv.Bitcast to the new file. Closes tensorflow/mlir#208 and tensorflow/mlir#174 COPYBARA_INTEGRATE_REVIEW=https://github.com/tensorflow/mlir/pull/208 from denis0x0D:sandbox/cast_ops 79bc9b37398aafddee6cf6beb301807988fe67f9 PiperOrigin-RevId: 277587891
* Use `not` to invert return code in expected to fail testsLei Zhang2019-10-301-1/+1
| | | | | | Windows does not like the RUN command of `(... || true) | ...`. PiperOrigin-RevId: 277587031
* Dump op location in createPrintOpGraphPass for easier debugging.Jing Pu2019-10-301-0/+4
| | | | PiperOrigin-RevId: 277546527
* Add support to GreedyPatternRewriter for erasing unreachable blocks.River Riddle2019-10-302-0/+71
| | | | | | Rewrite patterns may make modifications to the CFG, including dropping edges between blocks. This change adds a simple unreachable block elimination run at the end of each iteration to ensure that the CFG remains valid. PiperOrigin-RevId: 277545805
* Add a utility accessor 'has_single_element' for ranges.River Riddle2019-10-304-4/+8
| | | | | | This provides an easy way to check if a range has a single element. PiperOrigin-RevId: 277544647
* Fix segfault when no symbol is given to an constraint operandLei Zhang2019-10-302-1/+25
| | | | | | | This fixed the segfault when we see the following pattern: Pat<(...), (...), [(... 1, 2, 3), ...]> PiperOrigin-RevId: 277544300
* Add basic support for declarative Linalg transformationsNicolas Vasilache2019-10-309-0/+237
| | | | | | | | | Linalg ops provide a good anchor for pattern matching/rewriting transformations. This CL adds a simple example of how multi-level tiling may be specified by attaching a simple StringAttr to ops as they are transformed so we can easily specify partial lowering to control transformation application. This is a first stab at taking advantage of higher-level information contained in Linalg ops and will evolve in the future. PiperOrigin-RevId: 277497958
* [spirv] Fix gen_spirv_dialect.py and add spv.UnreachableLei Zhang2019-10-306-7/+137
| | | | | | | | | This CL fixed gen_spirv_dialect.py to support nested delimiters when chunking existing ODS entries in .td files and to allow ops without correspondence in the spec. This is needed to pull in the definition of OpUnreachable. PiperOrigin-RevId: 277486465
* [spirv] Mark control flow ops as InFunctionScopeLei Zhang2019-10-291-4/+5
| | | | PiperOrigin-RevId: 277373473
OpenPOWER on IntegriCloud