summaryrefslogtreecommitdiffstats
path: root/mlir
Commit message (Collapse)AuthorAgeFilesLines
...
* Added LLVM ops and lowering phases from standard dialect for FAbs, FCeil, ↵Marcel Koester2019-12-183-28/+102
| | | | | | | | | | | Cos, FNeg, CopySign. Added test cases for the newly added LLVM operations and lowering features. Closes tensorflow/mlir#300 COPYBARA_INTEGRATE_REVIEW=https://github.com/tensorflow/mlir/pull/300 from dfki-jugr:std_to_llvm da6168bbc1a369ae2e99ad3881fdddd82f075dd4 PiperOrigin-RevId: 286231169
* [VectorOps] Add vector.print definition, with lowering supportAart Bik2019-12-188-2/+245
| | | | | | | | | | | | | | | | Examples: vector.print %f : f32 vector.print %x : vector<4xf32> vector.print %y : vector<3x4xf32> vector.print %z : vector<2x3x4xf32> LLVM lowering replaces these with fully unrolled calls into a small runtime support library that provides some basic printing operations (single value, opening closing bracket, comma, newline). PiperOrigin-RevId: 286230325
* NFC: Remove forbidden include of <iostream>River Riddle2019-12-181-2/+0
| | | | | See: https://llvm.org/docs/CodingStandards.html#include-iostream-is-forbidden PiperOrigin-RevId: 286226467
* Add support for providing a default implementation for an interface method.River Riddle2019-12-187-10/+66
| | | | | | | | | | | | | | | | | | | | This enables providing a default implementation of an interface method. This method is defined on the Trait that is attached to the operation, and thus has all of the same constraints and properties as any other interface method. This allows for interface authors to provide a conservative default implementation for certain methods, without requiring that all users explicitly define it. The default implementation can be specified via the argument directly after the interface method body: StaticInterfaceMethod< /*desc=*/"Returns whether two array of types are compatible result types for an op.", /*retTy=*/"bool", /*methodName=*/"isCompatibleReturnTypes", /*args=*/(ins "ArrayRef<Type>":$lhs, "ArrayRef<Type>":$rhs), /*methodBody=*/[{ return ConcreteOp::isCompatibleReturnTypes(lhs, rhs); }], /*defaultImplementation=*/[{ /// Returns whether two arrays are equal as strongest check for /// compatibility by default. return lhs == rhs; }] PiperOrigin-RevId: 286226054
* Update code block designationsJacques Pienaar2019-12-1814-49/+38
| | | | | | | | | | | | | '```mlir' is used to indicate the code block is MLIR code/should use MLIR syntax highlighting, while '{.mlir}' was a markdown extension that used a style file to color the background differently of the code block. The background color extension was a custom one that we can retire given we have syntax highlighting. Also change '```td' to '```tablegen' to match chroma syntax highlighting designation. PiperOrigin-RevId: 286222976
* NFC: Cleanup non-conforming usages of namespaces.River Riddle2019-12-1813-111/+88
| | | | | | | * Fixes use of anonymous namespace for static methods. * Uses explicit qualifiers(mlir::) instead of wrapping the definition with the namespace. PiperOrigin-RevId: 286222654
* Introduce prefetch op: affine -> std -> llvm intrinsicUday Bondhugula2019-12-1821-30/+560
| | | | | | | | | | | | | | | | | | | Introduce affine.prefetch: op to prefetch using a multi-dimensional subscript on a memref; similar to affine.load but has no effect on semantics, but only on performance. Provide lowering through std.prefetch, llvm.prefetch and map to llvm's prefetch instrinsic. All attributes reflected through the lowering - locality hint, rw, and instr/data cache. affine.prefetch %0[%i, %j + 5], false, 3, true : memref<400x400xi32> Signed-off-by: Uday Bondhugula <uday@polymagelabs.com> Closes tensorflow/mlir#225 COPYBARA_INTEGRATE_REVIEW=https://github.com/tensorflow/mlir/pull/225 from bondhugula:prefetch 4c3b4e93bc64d9a5719504e6d6e1657818a2ead0 PiperOrigin-RevId: 286212997
* NFC: Remove unnecessary 'llvm::' prefix from uses of llvm symbols declared ↵River Riddle2019-12-18145-700/+650
| | | | | | | | in `mlir` namespace. Aside from being cleaner, this also makes the codebase more consistent. PiperOrigin-RevId: 286206974
* Move function template definition to the header file. NFCAlex Zinenko2019-12-182-12/+9
| | | | | | | | | The definition of the function template LLVM::ModuleTranslation::lookupValues has been located in a source file. As long as it has been the only file that actually called into the function, this did not cause any problem. However, it creates linking issues if the function is used from other translation units. PiperOrigin-RevId: 286203078
* Fix line break in LangRefJacques Pienaar2019-12-181-6/+8
| | | | | | This was munging up the example with the text. PiperOrigin-RevId: 286201762
* Harden the requirements to memory attribution types in gpu.funcAlex Zinenko2019-12-185-8/+90
| | | | | | | | | | When memory attributions are present in `gpu.func`, require that they are of memref type and live in memoryspaces 3 and 5 for workgroup and private memory attributions, respectively. Adapt the conversion from the GPU dialect to the NVVM dialect to drop the private memory space from attributions as NVVM is able to model them as local `llvm.alloca`s in the default memory space. PiperOrigin-RevId: 286161763
* Add support for float and string attributes to the C API and python bindingsMLIR Team2019-12-174-2/+49
| | | | PiperOrigin-RevId: 286115042
* NFC: Use this-> to appease GCC bug related to template lambda.River Riddle2019-12-178-8/+9
| | | | | | | GCC is unable to properly implicitly capture 'this' in generic lambdas. This bug is not fixed until 7.1.0: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67274 PiperOrigin-RevId: 286083427
* NFC: Use TypeSwitch to simplify existing code.River Riddle2019-12-1711-176/+117
| | | | PiperOrigin-RevId: 286066371
* Add pattern rewrite which splits a vector TransferWriteOp into slices ↵Andy Davis2019-12-174-42/+121
| | | | | | according to the unrolling/slicing scheme of its InsertSlicesOp operand. PiperOrigin-RevId: 286042578
* Add missing virtual inliner interface method in SPIR-V dialect.Mahesh Ravishankar2019-12-172-0/+56
| | | | | | | | | | | The inline interface uses two methods to check legality of inling: 1) Can a region be inlined into another. 2) Can an operation be inlined into another. Setting the former to true, allows the inliner to use the second for legality checks. Add this method to the SPIR-V dialect inlining interface. PiperOrigin-RevId: 286041734
* Make it possible to override the lowering of MemRef to the LLVM dialect. NFC.Alex Zinenko2019-12-173-16/+40
| | | | | | | | | | | | | The lowering of MemRef types to the LLVM dialect is connected to the underlying runtime representation of structured memory buffers. It has changed several times in the past and reached the current state of a LLVM structured-typed descriptor containing two pointers and all sizes. In several reported use cases, a different, often simpler, lowering scheme is required. For example, lowering statically-shaped memrefs to bare LLVM pointers to simplify aliasing annotation. Split the pattern population functions into those include memref-related operations and the remaining ones. Users are expected to extend TypeConverter::convertType to handle the memref types differently. PiperOrigin-RevId: 286030610
* ConversionToLLVMDialect doc: update the syntax for LLVM typesAlex Zinenko2019-12-171-38/+38
| | | | | | | | | | | | The syntax for LLVM dialect types changed twice since this document was introduced. First, the quoted types are only prefixed with the dialect name `!llvm` rather than with `!llvm.type`. Second, for types that are simple enough (e.g., MLIR identifiers), the pretty form can be used instead of the quoted form. The relevant commits updated the dialect documentation, but not the conversion documentation. Use the valid type names in the conversion documentation. PiperOrigin-RevId: 286026153
* StdToLLVM conversion: drop getMemRefElementType utility functionAlex Zinenko2019-12-171-12/+1
| | | | | | | | This function has become redundant with MemRefDescriptor::getElementType and is no longer necessary. Use the MemRefDescriptor pervasively to concentrate descriptor-related logic in one place and drop the utility function. PiperOrigin-RevId: 286024168
* Homogenize the description of the MemRef conversion to the LLVM dialectAlex Zinenko2019-12-171-46/+53
| | | | | | | | | The conversion procedure has been updated to reflect the most recent MemRef descriptor proposal, but the documentation was only updated for the type conversion, omitting the address computation section. Make sure the two sections agree. PiperOrigin-RevId: 286022684
* Add pattern rewrite to forward vector tuple elements to their users.Andy Davis2019-12-172-14/+38
| | | | | | User(TupleGetOp(ExtractSlicesOp(InsertSlicesOp(TupleOp(Producer))) -> User(Producer) PiperOrigin-RevId: 286020249
* fix a typo in OpDefinitions docJin Mingjian2019-12-171-1/+1
| | | | | | | | | [{ matched with }], rather than ]} Closes tensorflow/mlir#320 COPYBARA_INTEGRATE_REVIEW=https://github.com/tensorflow/mlir/pull/320 from jinmingjian:patch-1 6b0870d02284f023bda2b28380960eb31d34f3b6 PiperOrigin-RevId: 286007638
* Add a new utility class TypeSwitch to ADT.River Riddle2019-12-175-0/+326
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This class provides a simplified mechanism for defining a switch over a set of types using llvm casting functionality. More specifically, this allows for defining a switch over a value of type T where each case corresponds to a type(CaseT) that can be used with dyn_cast<CaseT>(...). An example is shown below: // Traditional piece of code: Operation *op = ...; if (auto constant = dyn_cast<ConstantOp>(op)) ...; else if (auto return = dyn_cast<ReturnOp>(op)) ...; else ...; // New piece of code: Operation *op = ...; TypeSwitch<Operation *>(op) .Case<ConstantOp>([](ConstantOp constant) { ... }) .Case<ReturnOp>([](ReturnOp return) { ... }) .Default([](Operation *op) { ... }); Aside from the above, TypeSwitch supports return values, void return, multiple types per case, etc. The usability is intended to be very similar to StringSwitch. (Using c++14 template lambdas makes everything even nicer) More complex example of how this makes certain things easier: LogicalResult process(Constant op); LogicalResult process(ReturnOp op); LogicalResult process(FuncOp op); TypeSwitch<Operation *, LogicalResult>(op) .Case<ConstantOp, ReturnOp, FuncOp>([](auto op) { return process(op); }) .Default([](Operation *op) { return op->emitError() << "could not be processed"; }); PiperOrigin-RevId: 286003613
* Integrate from upstream at revision e4fce659a759.MLIR Team2019-12-172-0/+2
| | | | PiperOrigin-RevId: 285982330
* Add pattern rewrite which splits a vector TransferReadOp into slices ↵Andy Davis2019-12-172-39/+56
| | | | | | according to the unrolling/slicing scheme of its ExtractSlicesOp user. PiperOrigin-RevId: 285975613
* Replace code with equivalent satisfiesLLVMModule() function call.Tres Popp2019-12-171-3/+1
| | | | | | This is a general code cleanup and should be a NFC. PiperOrigin-RevId: 285972718
* Update vector op unrolling transformation to generate ExtractSlicesOp and ↵Andy Davis2019-12-173-178/+236
| | | | | | InsertSlicesOp (instead of less structured chain of StridedSliceOps and InsertStridedSliceOps). PiperOrigin-RevId: 285968051
* Add atomic operations to SPIR-V dialect.Mahesh Ravishankar2019-12-169-18/+739
| | | | | | | Some changes to the dialect generation script to allow specification of different base class to derive from in ODS. PiperOrigin-RevId: 285859230
* Fix (de)serialization generation for SPV_ScopeAttr, SPV_MemorySemanticsAttr.Mahesh Ravishankar2019-12-161-2/+14
| | | | | | | | Scope and Memory Semantics attributes need to be serialized as a constant integer value and the <id> needs to be used to specify the value. Fix the auto-generated SPIR-V (de)serialization to handle this. PiperOrigin-RevId: 285849431
* [spirv] Re-enable nested loop (de)serialization testLei Zhang2019-12-161-98/+99
| | | | PiperOrigin-RevId: 285849308
* Add edsc::ops for pointwise, conv and dilated_convNicolas Vasilache2019-12-166-31/+443
| | | | | | | | | This CL adds more Linalg EDSC ops and tests to support building pointwise operations along with conv and dilated_conv. This also fixes a bug in the existing linalg_matmul EDSC and beefs up the test. The current set of ops is already enough to build an interesting, albeit simple, model used internally. PiperOrigin-RevId: 285838012
* Add InsertSlicesOp to the VectorOps dialect.Andy Davis2019-12-164-1/+150
| | | | PiperOrigin-RevId: 285830394
* Plug gpu.func into the GPU lowering pipelinesAlex Zinenko2019-12-1616-126/+213
| | | | | | | | | | | | | | This updates the lowering pipelines from the GPU dialect to lower-level dialects (NVVM, SPIRV) to use the recently introduced gpu.func operation instead of a standard function annotated with an attribute. In particular, the kernel outlining is updated to produce gpu.func instead of std.func and the individual conversions are updated to consume gpu.funcs and disallow standard funcs after legalization, if necessary. The attribute "gpu.kernel" is preserved in the generic syntax, but can also be used with the custom syntax on gpu.funcs. The special kind of function for GPU allows one to use additional features such as memory attribution. PiperOrigin-RevId: 285822272
* Insert signature-converted blocks into a region with a parent operation.River Riddle2019-12-163-28/+63
| | | | | | This keeps the IR valid and consistent as it is expected that each block should have a valid parent region/operation. Previously, converted blocks were kept floating without a valid parent region. PiperOrigin-RevId: 285821687
* Make "LowerToCFG" an operation passAlex Zinenko2019-12-162-8/+7
| | | | | | | | | The conversion from the Loops dialect to the Standard dialect, also known as loop-to-cfg lowering, has been historically a function pass. It can be required on non-Standard function Ops, in particular the recently introduced GPU functions. Make the conversion an operation pass instead of a function pass. PiperOrigin-RevId: 285814560
* [Linalg] Expose subview promotion as a declarative patternJose Ignacio Gomez2019-12-167-8/+113
| | | | | | | | | | | | This PR targest issue tensorflow/mlir#295. It exposes the already existing subiew promotion pass as a declarative pattern Change-Id: If901ebef9fb53fcd0b12ecc536f6b174ce320b92 Closes tensorflow/mlir#315 COPYBARA_INTEGRATE_REVIEW=https://github.com/tensorflow/mlir/pull/315 from tetuante:issue295 8e5f268b6d85f31015c33505329dbd7a4db97ac5 PiperOrigin-RevId: 285801463
* Remove unused variable (fix warning) NFCMehdi Amini2019-12-161-2/+1
| | | | PiperOrigin-RevId: 285799680
* [VectorOps] Add [insert/extract]element definition together with lowering to ↵Aart Bik2019-12-166-2/+248
| | | | | | | | | | | | | | LLVM Similar to insert/extract vector instructions but (1) work on 1-D vectors only (2) allow for a dynamic index %c3 = constant 3 : index %0 = vector.insertelement %arg0, %arg1[%c : index] : vector<4xf32> %1 = vector.extractelement %arg0[%c3 : index] : vector<4xf32> PiperOrigin-RevId: 285792205
* Adds ExtractSlicesOp to the VectorOps dialect.Andy Davis2019-12-164-6/+388
| | | | | | | ExtractSlicesOp extracts slices of its vector operand and with a specified tiling scheme. This operation centralizes the tiling scheme around a single op, which simplifies vector op unrolling and subsequent pattern rewrite transformations. PiperOrigin-RevId: 285761129
* Make memref promotion during std->LLVM lowering the default calling conventionAlex Zinenko2019-12-163-29/+98
| | | | | | | | | | | | | | | During the conversion from the standard dialect to the LLVM dialect, memref-typed arguments are promoted from registers to memory and passed into functions by pointer. This had been introduced into the lowering to work around the abesnce of calling convention modeling in MLIR to enable better interoperability with LLVM IR generated from C, and has been exerciced for several months. Make this promotion the default calling covention when converting to the LLVM dialect. This adds the documentation, simplifies the code and makes the conversion consistent across function operations and function types used in other places, e.g. in high-order functions or attributes, which would not follow the same rule previously. PiperOrigin-RevId: 285751280
* Remove LLVM dependency on mlir::Module and instead check Traits.Tres Popp2019-12-168-34/+61
| | | | PiperOrigin-RevId: 285724678
* Splat op doc - fix misformat / update tablegen op desc. commentUday Bondhugula2019-12-142-5/+18
| | | | | | | | | | | | - bring op description comment in sync with the doc - fix misformat in doc Signed-off-by: Uday Bondhugula <uday@polymagelabs.com> Closes tensorflow/mlir#317 COPYBARA_INTEGRATE_REVIEW=https://github.com/tensorflow/mlir/pull/317 from bondhugula:quickfix 7fcd945b318c973b2488b702874c87526855c8ef PiperOrigin-RevId: 285574527
* Add verifyCompatibleShape function overload with shapesSmit Hinsu2019-12-142-11/+24
| | | | PiperOrigin-RevId: 285574334
* Reconcile struct and class for NestedPatternMatchers - NFCNicolas Vasilache2019-12-131-8/+11
| | | | | | This removes a warning and fixes a potential ABI issue on Windows. PiperOrigin-RevId: 285502010
* Apply a level of sugaring to the linalg.generic EDSC - NFCNicolas Vasilache2019-12-133-43/+143
| | | | | | Make the declarative C++ builder API simpler to use so we can start chaining these ops together. PiperOrigin-RevId: 285496266
* Refactor various canonicalization patterns as in-place folds.River Riddle2019-12-138-243/+187
| | | | | | This is more efficient, and allows for these to fire in more situations: e.g. createOrFold, DialectConversion, etc. PiperOrigin-RevId: 285476837
* Skip generating C++ for "DeclareOpInterfaceMethods" in op interface gen.Jing Pu2019-12-132-6/+50
| | | | | | This is needed for calling the generator on a .td file that contains both OpInterface definitions and op definitions with DeclareOpInterfaceMethods<...> Traits. PiperOrigin-RevId: 285465784
* Add a layer of EDSC for linalg.GenericOpNicolas Vasilache2019-12-1315-37/+204
| | | | | | | | This will be evolved into a simple programming model for custom ops and custom layers in followup CLs. This CL also deletes the obsolete tablegen's reference-impl.td that was using EDSCs. PiperOrigin-RevId: 285459545
* Try to fold operations in DialectConversion when trying to legalize.River Riddle2019-12-1313-68/+193
| | | | | | This change allows for DialectConversion to attempt folding as a mechanism to legalize illegal operations. This also expands folding support in OpBuilder::createOrFold to generate new constants when folding, and also enables it to work in the context of a PatternRewriter. PiperOrigin-RevId: 285448440
* Add a type range for the XLA HLO dialect.Prakalp Srivastava2019-12-131-0/+1
| | | | PiperOrigin-RevId: 285437835
OpenPOWER on IntegriCloud