| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
| |
2) Fixed a test failure (which should have failed all along!).
llvm-svn: 43589
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- For @class, don't generate multiple typedefs.
- Handle the following edge case interface...
@interface NSMiddleSpecifier : NSObject {}
@end
...which was incorrectly being rewritten to...
struct _interface_NSMiddleSpecifier {
struct _interface_NSObject _NSObject;
};
{}
llvm-svn: 43582
|
|
|
|
| |
llvm-svn: 43580
|
|
|
|
|
|
| |
- Rewrite categories.
llvm-svn: 43501
|
|
|
|
|
|
| |
rewritten properly).
llvm-svn: 43494
|
|
|
|
| |
llvm-svn: 43493
|
|
|
|
| |
llvm-svn: 43476
|
|
|
|
|
|
| |
SourceLocation's for interfaces/protocols/categories/implementations.
llvm-svn: 43475
|
|
|
|
|
|
| |
This involved refining how the parser/AST passes/manages SourceLocations for ObjcMethodDecl's.
llvm-svn: 43404
|
|
|
|
| |
llvm-svn: 43178
|
|
|
|
| |
llvm-svn: 43075
|
|
|
|
| |
llvm-svn: 43051
|
|
|
|
|
|
| |
@selector probably gets this wrong also.
llvm-svn: 43048
|
|
|
|
| |
llvm-svn: 43039
|
|
|
|
| |
llvm-svn: 43038
|
|
|
|
| |
llvm-svn: 43022
|
|
|
|
|
|
|
|
|
|
| |
ParsePostfixExpressionSuffix().
Now were correctly allow the following...
i = [str rangeOfString:@"]"].length;
llvm-svn: 43012
|
|
|
|
|
|
|
|
|
|
|
| |
Sema::AddInstanceMethodToGlobalPool and DenseMaps. This will allow us to efficiently lookup a method from a selector given no type information (for the "id" data type).
- Fixed some funky "}
else {" indentation in Sema::ActOnAddMethodsToObjcDecl(). I'd prefer we stay away from this style...it wastes space and isn't any easier to read (from my perspective, at least:-)
- Changed Parser::ParseObjCInterfaceDeclList() to only call Action::ActOnAddMethodsToObjcDecl() when it actually has methods to add (since most interface have methods, this is a very minor cleanup).
llvm-svn: 42957
|
|
|
|
| |
llvm-svn: 42883
|
|
|
|
| |
llvm-svn: 42856
|
|
|
|
|
|
|
|
| |
use TUScope.
Also improve a recently added comment.
llvm-svn: 42826
|
|
|
|
| |
llvm-svn: 42798
|
|
|
|
|
|
|
| |
Protocols are now sorted and made unique in the list.
Enhanced pretty printer for @interface (So, I can see the protocol list).
llvm-svn: 42776
|
|
|
|
|
|
|
| |
(minimal printing), Derive ObjcClassDecl from Decl. Ted may want to
take note of the change I made to CFGRecStmtDeclVisitor.h
llvm-svn: 42764
|
|
|
|
|
|
|
|
| |
number of arguments now and does the right thing, but the nullary/unary
accessors are preserved as convenience functions. This allows us to
slightly simplify clients.
llvm-svn: 42716
|
|
|
|
|
|
|
|
|
|
|
| |
- Add SelectorTable, which enables us to remove MultiKeywordSelector from the public header.
- Remove FoldingSet from IdentifierInfo.h and Preprocessor.h.
- Remove Parser::ObjcGetUnarySelector and Parser::ObjcGetKeywordSelector, they are subsumed by SelectorTable.
- Add MultiKeywordSelector to IdentifierInfo.cpp.
- Move a bunch of selector related methods from ParseObjC.cpp to IdentifierInfo.cpp.
- Added some comments.
llvm-svn: 42643
|
|
|
|
|
|
| |
@try-statement.
llvm-svn: 42611
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add comments.
Switch to new indentation style for the Action class. Since many actions take many arguments, the new style will...
- make it easier to add/remove arguments without messing up the indentation...
- make it easier to add comments to each argument (see ActOnMethodDeclaration for an example)...
- in general, just makes it easier to see what is being passed.
The rest of Actions will be converted "lazily"...there is no immediate need to hack all the existing methods.
llvm-svn: 42587
|
|
|
|
|
|
|
|
|
| |
more to do).
Remove Action::ObjCStartCategoryInterface/ObjCFinishInterface - they are unused.
.
llvm-svn: 42559
|
|
|
|
|
|
|
|
| |
related to
unimplemented methods in category implementation.
llvm-svn: 42531
|
|
|
|
|
|
| |
MultiKeywordSelector::getName().
llvm-svn: 42524
|
|
|
|
|
|
|
| |
September 28, 2007 4:39:24 PM PDT
Please let me know if I missed anything.
llvm-svn: 42473
|
|
|
|
|
|
|
| |
There is still an issue if doing ScopedLookup is an overkill and we can
just access the decl using the identifier.
llvm-svn: 42463
|
|
|
|
|
|
| |
friend, move some methods around.
llvm-svn: 42456
|
|
|
|
|
|
|
|
|
|
|
|
| |
This motivated implementing a devious clattner inspired solution:-)
This approach uses a small value "Selector" class to point to an IdentifierInfo for the 0/1 case. For multi-keyword selectors, we instantiate a MultiKeywordSelector object (previously known as SelectorInfo). Now, the incremental cost for selectors is only 24,800 for Cocoa.h! This saves 156,592 bytes, or 86%!! The size reduction is also the result of getting rid of the AST slot, which was not strictly necessary (we will associate a selector with it's method using another table...most likely in Sema).
This change was critical to make now, before we have too many clients.
I still need to add some comments to the Selector class...will likely add later today/tomorrow.
llvm-svn: 42452
|
|
|
|
| |
llvm-svn: 42416
|
|
|
|
|
|
|
|
| |
with method implementation declarations .
It checks and warns on those methods declared in class interface and not implemented.
llvm-svn: 42412
|
|
|
|
| |
llvm-svn: 42396
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is SelectorInfo is not string-oriented, it is a unique aggregate of IdentifierInfo's (using a folding set). SelectorInfo also has a richer API that simplifies the parser/action interface. 3 noteworthy benefits:
#1: It is cleaner. I never "liked" storing keyword selectors (i.e. foo:bar:baz) in the IdentifierTable.
#2: It is more space efficient. Since Cocoa keyword selectors can be quite long, this technique is space saving. For Cocoa.h, pulling the keyword selectors out saves ~180k. The cost of the SelectorInfo data is ~100k. Saves ~80k, or 43%.
#3: It results in many API simplifications. Here are some highlights:
- Removed 3 actions (ActOnKeywordMessage, ActOnUnaryMessage, & one flavor of ObjcBuildMethodDeclaration that was specific to unary messages).
- Removed 3 funky structs from DeclSpec.h (ObjcKeywordMessage, ObjcKeywordDecl, and ObjcKeywordInfo).
- Removed 2 ivars and 2 constructors from ObjCMessageExpr (fyi, this space savings has not been measured).
I am happy with the way it turned out (though it took a bit more hacking than I expected). Given the central role of selectors in ObjC, making sure this is "right" will pay dividends later.
Thanks to Chris for talking this through with me and suggesting this approach.
llvm-svn: 42395
|
|
|
|
|
|
|
|
|
| |
info. It also adds more
semantic checks for class and protocol declarations. Test cases are good indications of kind of
checking being done in this patch.
llvm-svn: 42311
|
|
|
|
|
|
|
|
| |
use of
protocols referenced in @protocol declarations.
llvm-svn: 42191
|
|
|
|
| |
llvm-svn: 42148
|
|
|
|
|
|
|
|
|
|
|
| |
- Add ObjcMessageExpr AST node and associated constructors.
- Add SourceLocation's to ActOnKeywordMessage/ActOnUnaryMessage API.
- Instantiate message expressions...
- Replace alloca usage with SmallString.
Next step, installing a correct type, among other tweaks...
llvm-svn: 42116
|
|
|
|
| |
llvm-svn: 42104
|
|
|
|
|
|
| |
Moves such argument as the last argument and uses defaul value.
llvm-svn: 42073
|
|
|
|
|
|
| |
instead for @protocol method decls.
llvm-svn: 42070
|
|
|
|
| |
llvm-svn: 42060
|
|
|
|
| |
llvm-svn: 42059
|
|
|
|
|
|
|
|
|
|
|
|
| |
ObjcKeywordMessage.
- Removed helper ObjcGetSelectorInfo(), moving the code directly into ObjcBuildMethodDeclaration().
- Many refinements to ParseObjCMessageExpression().
- Add ActOnMessageExpression().
Next step, finish the message actions and (finally) create/instantiate an ObjcMessageExpr AST.
llvm-svn: 42050
|
|
|
|
| |
llvm-svn: 42028
|