summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* We need this symbol after an LTO build.Bill Wendling2012-10-121-0/+1
| | | | llvm-svn: 165776
* docs: Add SphinxQuickstartTemplate.rst.Sean Silva2012-10-122-0/+130
| | | | | | | The intent of this document is to be the go-to document for anybody who wants to write new documentation, but isn't familiar with Sphinx. llvm-svn: 165775
* Conditionally use an integral cast for BodyFarm support for ↵Ted Kremenek2012-10-121-6/+19
| | | | | | OSAtomicCompareAndSwap if the return type is not a boolean. llvm-svn: 165774
* Track which particular submodule #undef's a macro, so that the actualDouglas Gregor2012-10-1210-36/+117
| | | | | | #undef only occurs if that submodule is imported. llvm-svn: 165773
* Remove dead code introduced in r165751.Chad Rosier2012-10-121-6/+2
| | | | llvm-svn: 165772
* search for overridden methods with comment when overriding methodFariborz Jahanian2012-10-117-45/+35
| | | | | | | has none of its own. Factor in Doug's comments. // rdar://12378793 llvm-svn: 165771
* Remove pointless classof()'s.Sean Silva2012-10-1140-425/+0
| | | | | | | Updates to llvm/Support/Casting.h have rendered these classof()'s irrelevant. llvm-svn: 165770
* Add missing classof().Sean Silva2012-10-111-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Somewhat troublingly, without this implemented, the check inside isa_impl<> would silently use the parent's `classof()` when determining whether it was okay to downcast from the parent to the child! Bug analysis: A build failure after removing the parent's `classof()` initially alerted me to the bug, after which a little bit of thinking and reading of the code identified the root cause. The compiler could be made to prevent this bug from happening if there were a way to ensure that in the code template <typename To, typename From, typename Enabler = void> struct isa_impl { static inline bool doit(const From &Val) { return To::classof(&Val); } }; that `To::classof` is actually inside the class `To`, and not in a base class. I am not aware of a way to check this in C++. If there is a means to perform that check, please bring it up on the list and this will be fixed. There is a high likelihood that there are other instances of this same bug in the codebase. llvm-svn: 165769
* docs: Improve HowToSetUpLLVMStyleRTTI.Sean Silva2012-10-111-26/+59
| | | | | | | | | | * Fix confusing explanation regarding abstract classes. * Clarify auto-upcasting and why `Shape` doesn't need a `classof()`. * Add section `Rules of Thumb` with some quick summary tips. llvm-svn: 165768
* Remove unnecessary classof()'sSean Silva2012-10-1143-214/+0
| | | | | | | isa<> et al. automatically infer when the cast is an upcast (including a self-cast), so these are no longer necessary. llvm-svn: 165767
* docs: Update HowToSetUpLLVMStyleRTTI.Sean Silva2012-10-111-21/+39
| | | | | | | | | | | Recent changes to isa<>/dyn_cast<> have made unnecessary those classof() of the form: static bool classof(const Foo *) { return true; } Accordingly, remove mention of such classof() from the documentation. llvm-svn: 165766
* Casting.h: Automatically handle isa<Base>(Derived).Sean Silva2012-10-112-1/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | Additionally, all such cases are handled with no dynamic check. All `classof()` of the form class Foo { [...] static bool classof(const Bar *) { return true; } [...] } where Foo is an ancestor of Bar are no longer necessary. Don't write them! Note: The exact test is `is_base_of<Foo, Bar>`, which is non-strict, so that Foo is considered an ancestor of itself. This leads to the following rule of thumb for LLVM-style RTTI: The argument type of `classof()` should be a strict ancestor. For more information about implementing LLVM-style RTTI, see docs/HowToSetUpLLVMStyleRTTI.rst llvm-svn: 165765
* Remove buggy classof().Sean Silva2012-10-111-11/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This classof() is effectively saying that a MachineCodeEmitter "is-a" JITEmitter, but JITEmitter is in fact a descendant of MachineCodeEmitter, so this is not semantically correct. Consequently, none of the assertions that rely on these classof() actualy check anything. Remove the RTTI (which didn't actually check anything) and use static_cast<> instead. Post-Mortem Bug Analysis ======================== Cause of the bug ---------------- r55022 appears to be the source of the classof() and assertions removed by this commit. It aimed at removing some dynamic_cast<> that were solely in the assertions. A typical diff hunk from that commit looked like: - assert(dynamic_cast<JITEmitter*>(MCE) && "Unexpected MCE?"); - JITEmitter *JE = static_cast<JITEmitter*>(getCodeEmitter()); + assert(isa<JITEmitter>(MCE) && "Unexpected MCE?"); + JITEmitter *JE = cast<JITEmitter>(getCodeEmitter()); Hence, the source of the bug then seems to be an attempt to replace dynamic_cast<> with LLVM-style RTTI without properly setting up the class hierarchy for LLVM-style RTTI. The bug therefore appears to be simply a "thinko". What initially indicated the presence of the bug ------------------------------------------------ After implementing automatic upcasting for isa<>, classof() functions of the form static bool classof(const Foo *) { return true; } were removed, since they only serve the purpose of optimizing statically-OK upcasts. A subsequent recompilation triggered a build failure on the isa<> tests within the removed asserts, since the automatic upcasting (correctly) failed to substitute this classof(). Key to pinning down the root cause of the bug --------------------------------------------- After being alerted to the presence of the bug, some thought about the semantics which were being asserted by the buggy classof() revealed that it was incorrect. How the bug could have been prevented ------------------------------------- This bug could have been prevented by better documentation for how to set up LLVM-style RTTI. This should be solved by the recently added documentation HowToSetUpLLVMStyleRTTI. However, this bug suggests that the documentation should clearly explain the contract that classof() must fulfill. The HowToSetUpLLVMStyleRTTI already explains this contract, but it is a little tucked away. A future patch will expand that explanation and make it more prominent. There does not appear to be a simple way to have the compiler prevent this bug, since fundamentally it boiled down to a spurious classof() where the programmer made an erroneous statement about the conversion. This suggests that perhaps the interface to LLVM-style RTTI of classof() is not the best. There is already some evidence for this, since in a number of places Clang has classof() forward to classofKind(Kind K) which evaluates the cast in terms of just the Kind. This could probably be generalized to simply a `static const Kind MyKind;` field in leaf classes and `static const Kind firstMyKind, lastMyKind;` for non-leaf classes, and have the rest of the work be done inside Casting.h, assuming that the Kind enum is laid out in a preorder traversal of the inheritance tree. llvm-svn: 165764
* Provide a fixit when taking the address of an unqualified member function.David Blaikie2012-10-113-2/+23
| | | | | | | | | | | | | This only applies if the type has a name. (we could potentially do something crazy with decltype in C++11 to qualify members of unnamed types but that seems excessive) It might be nice to also suggest a fixit for "&this->i", "&foo->i", and "&foo.i" but those expressions produce 'bound' member functions that have a different AST representation & make error recovery a little trickier. Left as future work. llvm-svn: 165763
* clang/test/Index/index-module.m: Move XFAIL. It was line-number-sensitive.NAKAMURA Takumi2012-10-111-1/+2
| | | | llvm-svn: 165762
* clang/test/Index/index-module.m: Mark it as XFAIL:win32 for now.NAKAMURA Takumi2012-10-111-0/+1
| | | | llvm-svn: 165761
* clang/test/Index/index-pch-with-module.m: Tweak expressions for win32 pathsep.NAKAMURA Takumi2012-10-111-3/+3
| | | | llvm-svn: 165760
* PGO: create metadata for switch only if it has more than one targets.Manman Ren2012-10-111-1/+1
| | | | | | | When all cases of a switch statement are dead, the weights vector only has one element, and we will get an ssertion failure when calling createBranchWeights. llvm-svn: 165759
* Remove extra semicolon.Chad Rosier2012-10-111-1/+1
| | | | llvm-svn: 165758
* Remove extra semicolons.Chad Rosier2012-10-111-2/+2
| | | | llvm-svn: 165757
* <rdar://problem/12042500>Greg Clayton2012-10-111-1/+3
| | | | | | Fixed an issue where we would try to launch an application twice and the second failure would cover up the first. llvm-svn: 165756
* Fix build warnings.Greg Clayton2012-10-111-2/+2
| | | | llvm-svn: 165755
* Fixed the IR interaction layer to deal with aSean Callanan2012-10-113-16/+11
| | | | | | change in the LLDB target data API. llvm-svn: 165754
* Fix some typos 165739, spotted by Duncan.Jan Wen Voung2012-10-112-2/+2
| | | | llvm-svn: 165753
* [ms-inline asm] Remove a bunch of parsing code from the front-end, which will beChad Rosier2012-10-112-97/+4
| | | | | | reimplemented in the AsmParser where it belongs. llvm-svn: 165752
* [ms-inline asm] Lookup the IdentifierInfo using the Idents table and remove theChad Rosier2012-10-112-26/+1
| | | | | | | | | now unused static helper function. The test case needs to be remove temporarily until I can better filter memory operands that aren't actual variable reference. llvm-svn: 165751
* Revert 165732 for further review.Micah Villmow2012-10-1140-188/+109
| | | | llvm-svn: 165747
* Diagnose the expansion of ambiguous macro definitions. This can happenDouglas Gregor2012-10-1110-16/+99
| | | | | | | only with modules, when two disjoint modules #define the same identifier to different token sequences. llvm-svn: 165746
* Remove OSAtomicChecker.Ted Kremenek2012-10-115-227/+5
| | | | llvm-svn: 165744
* Switch over to BodyFarm implementation of OSAtomicCompareAndSwap andTed Kremenek2012-10-112-13/+130
| | | | | | objc_atomicCompareAndSwap. llvm-svn: 165743
* Teach GetBaseType() about BlockPointerTypes.Ted Kremenek2012-10-111-0/+2
| | | | llvm-svn: 165742
* Add TargetTransformInfo to the clang driver.Nadav Rotem2012-10-111-1/+5
| | | | llvm-svn: 165741
* Fixed an indentation issue that only shows up when dumping .o files that use ↵Greg Clayton2012-10-111-1/+1
| | | | | | linked addresses (DWARF in .o files with debug map). llvm-svn: 165740
* Change encoding of instruction operands in bitcode binaries to be relativeJan Wen Voung2012-10-115-91/+236
| | | | | | | | | | | | | | | | | | | | | | | | | | | to the instruction position. The old encoding would give an absolute ID which counts up within a function, and only resets at the next function. I.e., Instead of having: ... = icmp eq i32 n-1, n-2 br i1 ..., label %bb1, label %bb2 it will now be roughly: ... = icmp eq i32 1, 2 br i1 1, label %bb1, label %bb2 This makes it so that ids remain relatively small and can be encoded in fewer bits. With this encoding, forward reference operands will be given negative-valued IDs. Use signed VBRs for the most common case of forward references, which is phi instructions. To retain backward compatibility we bump the bitcode version from 0 to 1 to distinguish between the different encodings. llvm-svn: 165739
* Adds Phabricator documentation. This is a first step that answers many ↵Manuel Klimek2012-10-112-0/+100
| | | | | | questions we have seen. llvm-svn: 165736
* [libclang] Make sure the index_data.main_filename field is initializedArgyrios Kyrtzidis2012-10-112-0/+54
| | | | | | | in c-index-test. index_enteredMainFile is not invoked when indexing a module file. llvm-svn: 165735
* [libclang] Remove this test while I investigate why it is crashing on ↵Argyrios Kyrtzidis2012-10-111-52/+0
| | | | | | release+asserts. llvm-svn: 165734
* Add null check for malformed code.Ted Kremenek2012-10-111-2/+5
| | | | llvm-svn: 165733
* [libclang] Add tests for indexing modules and PCHs using modules.Argyrios Kyrtzidis2012-10-113-1/+84
| | | | llvm-svn: 165732
* Fix build failure from r165722Derek Schuff2012-10-111-1/+1
| | | | llvm-svn: 165731
* <rdar://problem/12331741>Greg Clayton2012-10-1110-339/+379
| | | | | | | | | | | | Dynamic type code must be efficient and fast. Now it is. Added ObjC v1 support for getting the complete list of ISA values. The main flow of the AppleObjCRuntime subclasses is now they must override "virtual bool UpdateISAToDescriptorMap_Impl();". This function will update the complete list of ISA values and create ClassDescriptorSP objects for each one. Now we have the complete list of valid ISA values which we can use for verification when doing dynamic typing. Refactored a bunch of stuff so that the AppleObjCRuntime subclasses don't have to implement as many functions as they used to. llvm-svn: 165730
* Introduce a simple "hint" scheme to eliminate the quadratic behaviorDouglas Gregor2012-10-114-11/+14
| | | | | | associated with deserializing macro history for an identifier. llvm-svn: 165729
* Patch from Andrew Kaylor that fixes Linux default host triple values.Greg Clayton2012-10-111-0/+5
| | | | llvm-svn: 165728
* Make the deserialization of PendingMacroIDs deterministic.Douglas Gregor2012-10-112-17/+11
| | | | llvm-svn: 165727
* Add in the first iteration of support for llvm/clang/lldb to allow variable ↵Micah Villmow2012-10-1144-121/+206
| | | | | | per address space pointer sizes to be optimized correctly. llvm-svn: 165726
* -Warc-repeated-use-of-weak: fix a use-of-uninitialized and add a test case.Jordan Rose2012-10-112-1/+13
| | | | | | Fix-up for r165718, should get the buildbots back online. llvm-svn: 165723
* Properly factor Native Client defines to support NaCl as an OSDerek Schuff2012-10-117-11/+238
| | | | | | with x86/ARM architecture llvm-svn: 165722
* Pass an explicit operand number to addLiveIns.Jakob Stoklund Olesen2012-10-113-8/+40
| | | | | | | | | Not all instructions define a virtual register in their first operand. Specifically, INLINEASM has a different format. <rdar://problem/12472811> llvm-svn: 165721
* Handle gnu_inline in c++ in a gcc compatible way. Original patch by TobiasRafael Espindola2012-10-112-1/+10
| | | | | | Grosser. llvm-svn: 165720
* -Warc-repeated-use-of-weak: Don't warn on a single read followed by writes.Jordan Rose2012-10-112-10/+101
| | | | | | | | | | This is a "safe" pattern, or at least one that cannot be helped by using a strong local variable. However, if the single read is within a loop, it should /always/ be treated as potentially dangerous. <rdar://problem/12437490> llvm-svn: 165719
OpenPOWER on IntegriCloud