summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix incorrect FIXME.Manuel Klimek2013-01-072-2/+4
| | | | | | | | The case that we wanted to write a test for cannot happen, as the UnwrappedLineParser already protects against it. Added an assert to prevent regressions of that assumption. llvm-svn: 171720
* Fix a slew of indentation and parameter naming style issues. This 80% ofChandler Carruth2013-01-071-42/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | this patch brought to you by the tool clang-format. I wanted to fix up the names of constructor parameters because they followed a bit of an anti-pattern by naming initialisms with CamelCase: 'Tti', 'Se', etc. This appears to have been in an attempt to not overlap with the names of member variables 'TTI', 'SE', etc. However, constructor arguments can very safely alias members, and in fact that's the conventional way to pass in members. I've fixed all of these I saw, along with making some strang abbreviations such as 'Lp' be simpler 'L', or 'Lgl' be the word 'Legal'. However, the code I was touching had indentation and formatting somewhat all over the map. So I ran clang-format and fixed them. I also fixed a few other formatting or doxygen formatting issues such as using ///< on trailing comments so they are associated with the correct entry. There is still a lot of room for improvement of the formating and cleanliness of this code. ;] At least a few parts of the coding standards or common practices in LLVM's code aren't followed, the enum naming rules jumped out at me. I may mix some of these while I'm here, but not all of them. llvm-svn: 171719
* CFG.cpp: Fix wrapping logic when printing block preds/succs.Will Dietz2013-01-072-2/+39
| | | | | | | | | First check only wrapped with i==8, second wrapped at i==2,8,18,28,... This fix restores the intended behavior: i==8,18,28,... Found with -fsanitize=integer. llvm-svn: 171718
* Remove outdated FIXME and add explanation for error handling strategyManuel Klimek2013-01-071-2/+6
| | | | | | while parsing #define's. llvm-svn: 171717
* Remove outdated fixme.Manuel Klimek2013-01-071-3/+0
| | | | llvm-svn: 171716
* Do not ever allow using the full line in preprocessor directives.Manuel Klimek2013-01-072-5/+14
| | | | | | | | | | | | | | | | We would format: #define A \ int f(a); int i; as #define A \ int f(a);\ int i The fix will break up macro definitions that could fit a line, but hit the last column; fixing that is more involved, though, as it requires looking at the following line. llvm-svn: 171715
* Switch LoopIdiom pass to directly require target transform information.Chandler Carruth2013-01-071-3/+3
| | | | | | | | I'm sorry for duplicating bad style here, but I wanted to keep consistency. I've pinged the code review thread where this style was reviewed and changes were requested. llvm-svn: 171714
* Fix layouting of single-line-comments preceded by an escaped newline.Manuel Klimek2013-01-072-7/+10
| | | | | | | | | | | | | Previously, we'd format int i;\ // comment as int i; // comment The problem is that the escaped newline is part of the next token, and thus the raw token text of the comment doesn't start with "//". llvm-svn: 171713
* Rough out a new c'tor for the AttrBuilder class.Bill Wendling2013-01-073-109/+141
| | | | | | | | This c'tor takes the AttributeSet class as the parameter. It will eventually grab the attributes from the specified index and create a new attribute builder with those attributes. llvm-svn: 171712
* [ELF] Properly handle constant data.Michael J. Spencer2013-01-073-0/+8
| | | | | | With this hello world works with dietlibc on x86-64 Linux. llvm-svn: 171711
* [lld] Add -emit-yaml option. This outputs yaml instead of a binary.Michael J. Spencer2013-01-075-5/+45
| | | | llvm-svn: 171710
* [ELF] Emit the file header and program headers at the beginning of the first ↵Michael J. Spencer2013-01-074-51/+55
| | | | | | | | | | segment. This is required for the loader to correctly set AT_PHDR. With this lld can correctly link against dietlibc and get to main. llvm-svn: 171709
* [ELF] Change Segment to hold Chunks instead of Sections. No functionality ↵Michael J. Spencer2013-01-071-4/+7
| | | | | | change. llvm-svn: 171708
* [ELF] Remove dead variable.Michael J. Spencer2013-01-071-2/+0
| | | | llvm-svn: 171707
* Fix layouting of tokens with a leading escaped newline.Manuel Klimek2013-01-073-8/+28
| | | | | | | | | | | If a token follows directly on an escaped newline, the escaped newline is stored with the token. Since we re-layout escaped newlines, we need to treat them just like normal whitespace - thus, we need to increase the whitespace-length of the token, while decreasing the token length (otherwise the token length contains the length of the escaped newline and we double-count it while indenting). llvm-svn: 171706
* Put a higher penalty on breaking before "." or "->".Daniel Jasper2013-01-072-2/+7
| | | | | | | | | | | | | | This fixes llvm.org/PR14823. Before: local_state->SetString(prefs::kApplicationLocale, parent_local_state ->GetString(prefs::kApplicationLocale)); After: local_state->SetString( prefs::kApplicationLocale, parent_local_state->GetString(prefs::kApplicationLocale)); llvm-svn: 171705
* [ELF] Emit zeroFill as STT_OBJECT in the final executable. ld does this.Michael J. Spencer2013-01-072-1/+5
| | | | llvm-svn: 171704
* [ELF] Add common x86_64 relocation types.Michael J. Spencer2013-01-073-1/+53
| | | | llvm-svn: 171703
* Remove more unnecessary # operators with nothing to paste proceeding them.Craig Topper2013-01-072-40/+40
| | | | llvm-svn: 171702
* Documentation updates for pointer-to-member debug info added in r171698.David Blaikie2013-01-071-9/+11
| | | | llvm-svn: 171701
* PR14759: Improve/correct support for debug info for C++ member pointers.David Blaikie2013-01-072-32/+7
| | | | | | | | | | Using added LLVM functionality in r171698. This works in GDB for member variable pointers but not member function pointers. See the LLVM commit and GDB bug 14998 for details. Un-xfailing cases in the GDB 7.5 test suite will follow. llvm-svn: 171699
* PR14759: Debug info support for C++ member pointers.David Blaikie2013-01-076-0/+67
| | | | | | | | This works fine with GDB for member variable pointers, but GDB's support for member function pointers seems to be quite unrelated to DW_TAG_ptr_to_member_type. (see GDB bug 14998 for details) llvm-svn: 171698
* Remove # from the beginning and end of def names. The # is a paste operator ↵Craig Topper2013-01-074-93/+93
| | | | | | and should only be used with something to paste on either side. llvm-svn: 171697
* Remove # from the beginning and end of def names.Craig Topper2013-01-074-283/+283
| | | | llvm-svn: 171696
* Revert r171140. We don't actually need to support #NAME. Because NAME by ↵Craig Topper2013-01-071-5/+1
| | | | | | itself is interpreted just fine. llvm-svn: 171695
* Remove unnecessary # tokens at the beginning and end of defm names.Craig Topper2013-01-071-10/+10
| | | | llvm-svn: 171694
* [Driver] x86-64 should use ELF 64.Michael J. Spencer2013-01-072-2/+5
| | | | llvm-svn: 171693
* [ELF] Give a slightly better message for unknown relocation types.Michael J. Spencer2013-01-071-1/+4
| | | | llvm-svn: 171692
* Make SimplifyCFG simply depend upon TargetTransformInfo and pass itChandler Carruth2013-01-073-48/+54
| | | | | | | | | | | | | through as a reference rather than a pointer. There is always *some* implementation of this available, so this simplifies code by not having to test for whether it is available or not. Further, it turns out there were piles of places where SimplifyCFG was recursing and not passing down either TD or TTI. These are fixed to be more pedantically consistent even though I don't have any particular cases where it would matter. llvm-svn: 171691
* Move the initialization to the Analysis library as well as the pass.Chandler Carruth2013-01-072-1/+1
| | | | | | | This was (somewhat distressingly) only caught be the ocaml bindings tests... llvm-svn: 171690
* Update comment.Eric Christopher2013-01-071-1/+1
| | | | llvm-svn: 171689
* Fix the enumerator names for ShuffleKind to match tho coding standards,Chandler Carruth2013-01-073-7/+8
| | | | | | and make its comments doxygen comments. llvm-svn: 171688
* Make the popcnt support enums and methods have more clear names andChandler Carruth2013-01-074-21/+23
| | | | | | | follow the conding conventions regarding enumerating a set of "kinds" of things. llvm-svn: 171687
* Move TargetTransformInfo to live under the Analysis library. This noChandler Carruth2013-01-0715-18/+18
| | | | | | | longer would violate any dependency layering and it is in fact an analysis. =] llvm-svn: 171686
* tblgen, docs: Add initial syntax reference.Sean Silva2013-01-072-0/+376
| | | | llvm-svn: 171685
* Simplify TableGen type-compatibility checks.Sean Silva2013-01-072-75/+45
| | | | | | Patch by Elior Malul! llvm-svn: 171684
* Switch to asking the target machine to add any relevant analysis passsesChandler Carruth2013-01-071-19/+8
| | | | | | rather than doing it ourselves. This reflects the API changes in r171681. llvm-svn: 171683
* Switch TargetTransformInfo from an immutable analysis pass that requiresChandler Carruth2013-01-0747-1202/+1117
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | a TargetMachine to construct (and thus isn't always available), to an analysis group that supports layered implementations much like AliasAnalysis does. This is a pretty massive change, with a few parts that I was unable to easily separate (sorry), so I'll walk through it. The first step of this conversion was to make TargetTransformInfo an analysis group, and to sink the nonce implementations in ScalarTargetTransformInfo and VectorTargetTranformInfo into a NoTargetTransformInfo pass. This allows other passes to add a hard requirement on TTI, and assume they will always get at least on implementation. The TargetTransformInfo analysis group leverages the delegation chaining trick that AliasAnalysis uses, where the base class for the analysis group delegates to the previous analysis *pass*, allowing all but tho NoFoo analysis passes to only implement the parts of the interfaces they support. It also introduces a new trick where each pass in the group retains a pointer to the top-most pass that has been initialized. This allows passes to implement one API in terms of another API and benefit when some other pass above them in the stack has more precise results for the second API. The second step of this conversion is to create a pass that implements the TargetTransformInfo analysis using the target-independent abstractions in the code generator. This replaces the ScalarTargetTransformImpl and VectorTargetTransformImpl classes in lib/Target with a single pass in lib/CodeGen called BasicTargetTransformInfo. This class actually provides most of the TTI functionality, basing it upon the TargetLowering abstraction and other information in the target independent code generator. The third step of the conversion adds support to all TargetMachines to register custom analysis passes. This allows building those passes with access to TargetLowering or other target-specific classes, and it also allows each target to customize the set of analysis passes desired in the pass manager. The baseline LLVMTargetMachine implements this interface to add the BasicTTI pass to the pass manager, and all of the tools that want to support target-aware TTI passes call this routine on whatever target machine they end up with to add the appropriate passes. The fourth step of the conversion created target-specific TTI analysis passes for the X86 and ARM backends. These passes contain the custom logic that was previously in their extensions of the ScalarTargetTransformInfo and VectorTargetTransformInfo interfaces. I separated them into their own file, as now all of the interface bits are private and they just expose a function to create the pass itself. Then I extended these target machines to set up a custom set of analysis passes, first adding BasicTTI as a fallback, and then adding their customized TTI implementations. The fourth step required logic that was shared between the target independent layer and the specific targets to move to a different interface, as they no longer derive from each other. As a consequence, a helper functions were added to TargetLowering representing the common logic needed both in the target implementation and the codegen implementation of the TTI pass. While technically this is the only change that could have been committed separately, it would have been a nightmare to extract. The final step of the conversion was just to delete all the old boilerplate. This got rid of the ScalarTargetTransformInfo and VectorTargetTransformInfo classes, all of the support in all of the targets for producing instances of them, and all of the support in the tools for manually constructing a pass based around them. Now that TTI is a relatively normal analysis group, two things become straightforward. First, we can sink it into lib/Analysis which is a more natural layer for it to live. Second, clients of this interface can depend on it *always* being available which will simplify their code and behavior. These (and other) simplifications will follow in subsequent commits, this one is clearly big enough. Finally, I'm very aware that much of the comments and documentation needs to be updated. As soon as I had this working, and plausibly well commented, I wanted to get it committed and in front of the build bots. I'll be doing a few passes over documentation later if it sticks. Commits to update DragonEgg and Clang will be made presently. llvm-svn: 171681
* Simplify. No behavior change.Nico Weber2013-01-072-11/+5
| | | | llvm-svn: 171680
* [ObjCARC Debug Message] - Added debug message when fuse a retain/autorelease ↵Michael Gottesman2013-01-071-2/+10
| | | | | | pair in ObjCARCContract::ContractAutorelease. llvm-svn: 171679
* [ObjCARC Debug Message] - Added debug message when we zap a matching ↵Michael Gottesman2013-01-071-0/+3
| | | | | | retain/autorelease pair in ObjCARCOpt::OptimizeReturns. llvm-svn: 171678
* [ObjCARC Debug Message] - Added debug message when we erase ARC calls with ↵Michael Gottesman2013-01-071-0/+2
| | | | | | null since they are no-ops. llvm-svn: 171677
* [ObjCARC Debug Message] - Added debug message when we add a nounwind keyword ↵Michael Gottesman2013-01-061-0/+2
| | | | | | to a function which can not throw. llvm-svn: 171676
* [ObjCARC Debug Message] - Added debug message when we add a tail keyword to ↵Michael Gottesman2013-01-061-0/+3
| | | | | | a function which can never be passed stack args. llvm-svn: 171675
* [ObjCARC Debug Messages] - Added missing newline.Michael Gottesman2013-01-061-1/+1
| | | | llvm-svn: 171674
* Added debug statement to ObjCARC when we replace objc_autorelease(x) with ↵Michael Gottesman2013-01-061-0/+8
| | | | | | objc_release(x) when x is otherwise unused. llvm-svn: 171673
* Added 2x Debug statements to ObjCARC that log when we handle the two ↵Michael Gottesman2013-01-061-2/+16
| | | | | | | | undefined pointer-to-weak-pointer is NULL cases by replacing the given call inst with an undefined value. The reason that there are two cases is that the first case handles the unary cases and the second the binary cases. llvm-svn: 171672
* Documentation: add clang 3.0 + libstdc++ 4.7.x as a known bad combination thatDmitri Gribenko2013-01-061-0/+5
| | | | | | is actually used by a few Linux distributions llvm-svn: 171671
* Added debug message in ObjCARC when we remove a no-op cast which has only ↵Michael Gottesman2013-01-061-0/+2
| | | | | | special semantic meaning in the frontend and thus in the optimizer can be deleted. llvm-svn: 171670
* Added debug message to ObjCARC when we transform an ↵Michael Gottesman2013-01-061-0/+12
| | | | | | objc_autoreleaseReturnValue => objc_autorelease due to its operand not being used as a return value. llvm-svn: 171669
OpenPOWER on IntegriCloud