diff options
Diffstat (limited to 'llvm')
| -rw-r--r-- | llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp | 2 | ||||
| -rw-r--r-- | llvm/test/CodeGen/X86/simple-zext.ll | 16 |
2 files changed, 17 insertions, 1 deletions
diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp index 00469b0f32a..1688fc495ad 100644 --- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -2755,7 +2755,7 @@ SDValue DAGCombiner::visitAND(SDNode *N) { ? cast<LoadSDNode>(N0.getOperand(0)) : cast<LoadSDNode>(N0); if (LN0->getExtensionType() != ISD::SEXTLOAD && - LN0->isUnindexed() && N0.hasOneUse() && LN0->hasOneUse()) { + LN0->isUnindexed() && N0.hasOneUse() && SDValue(LN0, 0).hasOneUse()) { uint32_t ActiveBits = N1C->getAPIntValue().getActiveBits(); if (ActiveBits > 0 && APIntOps::isMask(ActiveBits, N1C->getAPIntValue())){ EVT ExtVT = EVT::getIntegerVT(*DAG.getContext(), ActiveBits); diff --git a/llvm/test/CodeGen/X86/simple-zext.ll b/llvm/test/CodeGen/X86/simple-zext.ll new file mode 100644 index 00000000000..ccd8292bcdb --- /dev/null +++ b/llvm/test/CodeGen/X86/simple-zext.ll @@ -0,0 +1,16 @@ +; RUN: llc -mtriple=x86_64-apple-darwin < %s| FileCheck %s + +; A bug in DAGCombiner prevented it forming a zextload in this simple case +; because it counted both the chain user and the real user against the +; profitability total. + +define void @load_zext(i32* nocapture %p){ +entry: + %0 = load i32* %p, align 4 + %and = and i32 %0, 255 + tail call void @use(i32 %and) + ret void +; CHECK: movzbl ({{%r[a-z]+}}), {{%e[a-z]+}} +} + +declare void @use(i32) |
