diff options
Diffstat (limited to 'llvm/tools')
| -rw-r--r-- | llvm/tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp | 8 | ||||
| -rw-r--r-- | llvm/tools/llvm-dis/llvm-dis.cpp | 39 |
2 files changed, 14 insertions, 33 deletions
diff --git a/llvm/tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp b/llvm/tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp index 96820f9c8a0..fec11e35d50 100644 --- a/llvm/tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp +++ b/llvm/tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp @@ -436,10 +436,6 @@ static bool decodeMetadataStringsBlob(BitstreamReader &Reader, StringRef Indent, SimpleBitstreamCursor R(Reader); R.jumpToPointer(Lengths.begin()); - // Ensure that Blob doesn't get invalidated, even if this is reading from a - // StreamingMemoryObject with corrupt data. - R.setArtificialByteLimit(R.getCurrentByteNo() + StringsOffset); - StringRef Strings = Blob.drop_front(StringsOffset); do { if (R.AtEndOfStream()) @@ -735,7 +731,7 @@ static bool openBitcodeFile(StringRef Path, return ReportError("Invalid bitcode wrapper header"); } - StreamFile = BitstreamReader(BufPtr, EndBufPtr); + StreamFile = BitstreamReader(ArrayRef<uint8_t>(BufPtr, EndBufPtr)); Stream = BitstreamCursor(StreamFile); StreamFile.CollectBlockInfoNames(); @@ -814,7 +810,7 @@ static int AnalyzeBitcode() { if (Dump) outs() << "\n\n"; - uint64_t BufferSizeBits = StreamFile.getBitcodeBytes().getExtent() * CHAR_BIT; + uint64_t BufferSizeBits = StreamFile.getBitcodeBytes().size() * CHAR_BIT; // Print a summary of the read file. outs() << "Summary of " << InputFilename << ":\n"; outs() << " Total size: "; diff --git a/llvm/tools/llvm-dis/llvm-dis.cpp b/llvm/tools/llvm-dis/llvm-dis.cpp index 88333aeb688..69533ccac52 100644 --- a/llvm/tools/llvm-dis/llvm-dis.cpp +++ b/llvm/tools/llvm-dis/llvm-dis.cpp @@ -26,7 +26,6 @@ #include "llvm/IR/Module.h" #include "llvm/IR/Type.h" #include "llvm/Support/CommandLine.h" -#include "llvm/Support/DataStream.h" #include "llvm/Support/Error.h" #include "llvm/Support/FileSystem.h" #include "llvm/Support/FormattedStream.h" @@ -139,34 +138,20 @@ static void diagnosticHandler(const DiagnosticInfo &DI, void *Context) { } static Expected<std::unique_ptr<Module>> openInputFile(LLVMContext &Context) { - if (MaterializeMetadata) { - ErrorOr<std::unique_ptr<MemoryBuffer>> MBOrErr = - MemoryBuffer::getFileOrSTDIN(InputFilename); - if (!MBOrErr) - return errorCodeToError(MBOrErr.getError()); - ErrorOr<std::unique_ptr<Module>> MOrErr = - getLazyBitcodeModule(std::move(*MBOrErr), Context, - /*ShouldLazyLoadMetadata=*/true); - if (!MOrErr) - return errorCodeToError(MOrErr.getError()); + ErrorOr<std::unique_ptr<MemoryBuffer>> MBOrErr = + MemoryBuffer::getFileOrSTDIN(InputFilename); + if (!MBOrErr) + return errorCodeToError(MBOrErr.getError()); + ErrorOr<std::unique_ptr<Module>> MOrErr = + getLazyBitcodeModule(std::move(*MBOrErr), Context, + /*ShouldLazyLoadMetadata=*/true); + if (!MOrErr) + return errorCodeToError(MOrErr.getError()); + if (MaterializeMetadata) (*MOrErr)->materializeMetadata(); - return std::move(*MOrErr); - } else { - std::string ErrorMessage; - std::unique_ptr<DataStreamer> Streamer = - getDataFileStreamer(InputFilename, &ErrorMessage); - if (!Streamer) - return make_error<StringError>(ErrorMessage, inconvertibleErrorCode()); - std::string DisplayFilename; - if (InputFilename == "-") - DisplayFilename = "<stdin>"; - else - DisplayFilename = InputFilename; - ErrorOr<std::unique_ptr<Module>> MOrErr = - getStreamedBitcodeModule(DisplayFilename, std::move(Streamer), Context); + else (*MOrErr)->materializeAll(); - return std::move(*MOrErr); - } + return std::move(*MOrErr); } int main(int argc, char **argv) { |

