diff options
Diffstat (limited to 'llvm/lib/Transforms/InstCombine/InstructionCombining.cpp')
-rw-r--r-- | llvm/lib/Transforms/InstCombine/InstructionCombining.cpp | 21 |
1 files changed, 4 insertions, 17 deletions
diff --git a/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp index 33e3fa4ceb6..b3db47bbbf9 100644 --- a/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp +++ b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp @@ -2330,21 +2330,13 @@ static bool isAllocSiteRemovable(Instruction *AI, return false; LLVM_FALLTHROUGH; } + case Intrinsic::invariant_start: case Intrinsic::invariant_end: case Intrinsic::lifetime_start: case Intrinsic::lifetime_end: case Intrinsic::objectsize: Users.emplace_back(I); continue; - case Intrinsic::invariant_start: - // Only delete this if it has no uses or a single 'end' use. - if (I->use_empty()) - Users.emplace_back(I); - else if (I->hasOneUse() && - match(I->user_back(), - m_Intrinsic<Intrinsic::invariant_end>())) - Users.emplace_back(I); - continue; } } @@ -2392,13 +2384,14 @@ Instruction *InstCombiner::visitAllocSite(Instruction &MI) { if (isAllocSiteRemovable(&MI, Users, &TLI)) { for (unsigned i = 0, e = Users.size(); i != e; ++i) { + // Lowering all @llvm.objectsize calls first because they may + // use a bitcast/GEP of the alloca we are removing. if (!Users[i]) continue; Instruction *I = cast<Instruction>(&*Users[i]); + if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(I)) { - // Lowering all @llvm.objectsize calls first because they may - // use a bitcast/GEP of the alloca we are removing. if (II->getIntrinsicID() == Intrinsic::objectsize) { Value *Result = lowerObjectSizeCall(II, DL, &TLI, /*MustSucceed=*/true); @@ -2406,12 +2399,6 @@ Instruction *InstCombiner::visitAllocSite(Instruction &MI) { eraseInstFromFunction(*I); Users[i] = nullptr; // Skip examining in the next loop. } - // Erase llvm.invariant.end because we expect that it uses an - // llvm.invariant.start that we will remove below. - if (II->getIntrinsicID() == Intrinsic::invariant_end) { - eraseInstFromFunction(*I); - Users[i] = nullptr; // Skip examining in the next loop. - } } } for (unsigned i = 0, e = Users.size(); i != e; ++i) { |