summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Remarks
diff options
context:
space:
mode:
Diffstat (limited to 'llvm/lib/Remarks')
-rw-r--r--llvm/lib/Remarks/BitstreamRemarkParser.cpp8
-rw-r--r--llvm/lib/Remarks/BitstreamRemarkParser.h9
2 files changed, 9 insertions, 8 deletions
diff --git a/llvm/lib/Remarks/BitstreamRemarkParser.cpp b/llvm/lib/Remarks/BitstreamRemarkParser.cpp
index 1cfde119222..dfad5902545 100644
--- a/llvm/lib/Remarks/BitstreamRemarkParser.cpp
+++ b/llvm/lib/Remarks/BitstreamRemarkParser.cpp
@@ -174,7 +174,7 @@ static Error parseBlock(T &ParserHelper, unsigned BlockID,
// Stop when there is nothing to read anymore or when we encounter an
// END_BLOCK.
while (!Stream.AtEndOfStream()) {
- Expected<BitstreamEntry> Next = Stream.advance();
+ Next = Stream.advance();
if (!Next)
return Next.takeError();
switch (Next->Kind) {
@@ -366,15 +366,15 @@ Error BitstreamRemarkParser::parseMeta() {
}
Error BitstreamRemarkParser::processCommonMeta(
- BitstreamMetaParserHelper &MetaHelper) {
- if (Optional<uint64_t> Version = MetaHelper.ContainerVersion)
+ BitstreamMetaParserHelper &Helper) {
+ if (Optional<uint64_t> Version = Helper.ContainerVersion)
ContainerVersion = *Version;
else
return createStringError(
std::make_error_code(std::errc::illegal_byte_sequence),
"Error while parsing BLOCK_META: missing container version.");
- if (Optional<uint8_t> Type = MetaHelper.ContainerType) {
+ if (Optional<uint8_t> Type = Helper.ContainerType) {
// Always >= BitstreamRemarkContainerType::First since it's unsigned.
if (*Type > static_cast<uint8_t>(BitstreamRemarkContainerType::Last))
return createStringError(
diff --git a/llvm/lib/Remarks/BitstreamRemarkParser.h b/llvm/lib/Remarks/BitstreamRemarkParser.h
index 7c9cc2f1e7d..749219fc515 100644
--- a/llvm/lib/Remarks/BitstreamRemarkParser.h
+++ b/llvm/lib/Remarks/BitstreamRemarkParser.h
@@ -34,15 +34,16 @@ struct BitstreamRemarkParser : public RemarkParser {
std::unique_ptr<MemoryBuffer> TmpRemarkBuffer;
/// The common metadata used to decide how to parse the buffer.
/// This is filled when parsing the metadata block.
- uint64_t ContainerVersion;
- uint64_t RemarkVersion;
- BitstreamRemarkContainerType ContainerType;
+ uint64_t ContainerVersion = 0;
+ uint64_t RemarkVersion = 0;
+ BitstreamRemarkContainerType ContainerType =
+ BitstreamRemarkContainerType::Standalone;
/// Wether the parser is ready to parse remarks.
bool ReadyToParseRemarks = false;
/// Create a parser that expects to find a string table embedded in the
/// stream.
- BitstreamRemarkParser(StringRef Buf)
+ explicit BitstreamRemarkParser(StringRef Buf)
: RemarkParser(Format::Bitstream), ParserHelper(Buf) {}
/// Create a parser that uses a pre-parsed string table.
OpenPOWER on IntegriCloud