diff options
Diffstat (limited to 'clang')
-rw-r--r-- | clang/lib/StaticAnalyzer/Core/PathDiagnostic.cpp | 5 | ||||
-rw-r--r-- | clang/test/Analysis/new-ctor-malloc.cpp | 11 |
2 files changed, 11 insertions, 5 deletions
diff --git a/clang/lib/StaticAnalyzer/Core/PathDiagnostic.cpp b/clang/lib/StaticAnalyzer/Core/PathDiagnostic.cpp index fac0d380d47..b03517c02a8 100644 --- a/clang/lib/StaticAnalyzer/Core/PathDiagnostic.cpp +++ b/clang/lib/StaticAnalyzer/Core/PathDiagnostic.cpp @@ -574,8 +574,11 @@ getLocationForCaller(const StackFrameContext *SFC, return PathDiagnosticLocation::createEnd(CallerBody, SM, CallerCtx); return PathDiagnosticLocation::create(CallerInfo->getDecl(), SM); } + case CFGElement::NewAllocator: { + const CFGNewAllocator &Alloc = Source.castAs<CFGNewAllocator>(); + return PathDiagnosticLocation(Alloc.getAllocatorExpr(), SM, CallerCtx); + } case CFGElement::TemporaryDtor: - case CFGElement::NewAllocator: llvm_unreachable("not yet implemented!"); case CFGElement::LifetimeEnds: case CFGElement::LoopExit: diff --git a/clang/test/Analysis/new-ctor-malloc.cpp b/clang/test/Analysis/new-ctor-malloc.cpp index d07242c92ae..74b1e21a5c9 100644 --- a/clang/test/Analysis/new-ctor-malloc.cpp +++ b/clang/test/Analysis/new-ctor-malloc.cpp @@ -1,4 +1,4 @@ -// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection,unix.Malloc -analyzer-config c++-allocator-inlining=true -std=c++11 -verify %s +// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection,unix.Malloc -analyzer-config c++-allocator-inlining=true -analyzer-output=text -std=c++11 -verify %s void clang_analyzer_eval(bool); @@ -7,12 +7,15 @@ typedef __typeof__(sizeof(int)) size_t; void *malloc(size_t size); void *operator new(size_t size) throw() { - void *x = malloc(size); - if (!x) + void *x = malloc(size); // expected-note {{Memory is allocated}} + if (!x) // expected-note {{Assuming 'x' is non-null}} + // expected-note@-1 {{Taking false branch}} return nullptr; return x; } void checkNewAndConstructorInlining() { - int *s = new int; + int *s = new int; // expected-note {{Calling 'operator new'}} + // expected-note@-1{{Returning from 'operator new'}} } // expected-warning {{Potential leak of memory pointed to by 's'}} + // expected-note@-1 {{Potential leak of memory pointed to by 's'}} |