diff options
Diffstat (limited to 'clang')
-rw-r--r-- | clang/lib/Serialization/ASTReaderDecl.cpp | 7 | ||||
-rw-r--r-- | clang/test/Modules/Inputs/cxx-templates-a.h | 4 | ||||
-rw-r--r-- | clang/test/Modules/Inputs/cxx-templates-b.h | 4 | ||||
-rw-r--r-- | clang/test/Modules/Inputs/cxx-templates-common.h | 4 | ||||
-rw-r--r-- | clang/test/Modules/cxx-templates.cpp | 3 |
5 files changed, 18 insertions, 4 deletions
diff --git a/clang/lib/Serialization/ASTReaderDecl.cpp b/clang/lib/Serialization/ASTReaderDecl.cpp index d8495da1bac..f9fed46ad9c 100644 --- a/clang/lib/Serialization/ASTReaderDecl.cpp +++ b/clang/lib/Serialization/ASTReaderDecl.cpp @@ -1017,7 +1017,8 @@ ASTDeclReader::RedeclarableResult ASTDeclReader::VisitVarDeclImpl(VarDecl *VD) { switch ((VarKind)Record[Idx++]) { case VarNotTemplate: // Only true variables (not parameters or implicit parameters) can be merged - if (VD->getKind() != Decl::ParmVar && VD->getKind() != Decl::ImplicitParam) + if (VD->getKind() != Decl::ParmVar && VD->getKind() != Decl::ImplicitParam && + !isa<VarTemplateSpecializationDecl>(VD)) mergeRedeclarable(VD, Redecl); break; case VarTemplate: @@ -1438,7 +1439,9 @@ ASTDeclReader::VisitCXXRecordDeclImpl(CXXRecordDecl *D) { }; switch ((CXXRecKind)Record[Idx++]) { case CXXRecNotTemplate: - mergeRedeclarable(D, Redecl); + // Merged when we merge the folding set entry in the primary template. + if (!isa<ClassTemplateSpecializationDecl>(D)) + mergeRedeclarable(D, Redecl); break; case CXXRecTemplate: { // Merged when we merge the template. diff --git a/clang/test/Modules/Inputs/cxx-templates-a.h b/clang/test/Modules/Inputs/cxx-templates-a.h index 12b647b52de..5ac1697bff6 100644 --- a/clang/test/Modules/Inputs/cxx-templates-a.h +++ b/clang/test/Modules/Inputs/cxx-templates-a.h @@ -63,3 +63,7 @@ template<> struct WithExplicitSpecialization<int> { return n; } }; + +template<typename T> template<typename U> +constexpr int Outer<T>::Inner<U>::f() { return 1; } +static_assert(Outer<int>::Inner<int>::f() == 1, ""); diff --git a/clang/test/Modules/Inputs/cxx-templates-b.h b/clang/test/Modules/Inputs/cxx-templates-b.h index a6828553027..efd07c617e5 100644 --- a/clang/test/Modules/Inputs/cxx-templates-b.h +++ b/clang/test/Modules/Inputs/cxx-templates-b.h @@ -20,6 +20,10 @@ extern DefinedInCommon &defined_in_common; template<int> struct MergeTemplates; MergeTemplates<0> *merge_templates_b; +template<typename T> template<typename U> +constexpr int Outer<T>::Inner<U>::g() { return 2; } +static_assert(Outer<int>::Inner<int>::g() == 2, ""); + @import cxx_templates_b_impl; template<typename T, typename> struct Identity { typedef T type; }; diff --git a/clang/test/Modules/Inputs/cxx-templates-common.h b/clang/test/Modules/Inputs/cxx-templates-common.h index 986c52b362c..682ef939cec 100644 --- a/clang/test/Modules/Inputs/cxx-templates-common.h +++ b/clang/test/Modules/Inputs/cxx-templates-common.h @@ -26,8 +26,8 @@ template<typename T> struct TemplateInstantiationVisibility { typedef int type; template<typename T> struct Outer { template<typename U> struct Inner { - void f(); - void g(); + static constexpr int f(); + static constexpr int g(); }; }; diff --git a/clang/test/Modules/cxx-templates.cpp b/clang/test/Modules/cxx-templates.cpp index f68bc72a271..679d7d12b1b 100644 --- a/clang/test/Modules/cxx-templates.cpp +++ b/clang/test/Modules/cxx-templates.cpp @@ -107,6 +107,9 @@ void g() { int &q = WithExplicitSpecializationUse().inner_template<int>(); } +static_assert(Outer<int>::Inner<int>::f() == 1, ""); +static_assert(Outer<int>::Inner<int>::g() == 2, ""); + RedeclaredAsFriend<int> raf1; RedeclareTemplateAsFriend<double> rtaf; RedeclaredAsFriend<double> raf2; |