diff options
Diffstat (limited to 'clang')
| -rw-r--r-- | clang/lib/CodeGen/CGVTables.h | 9 | ||||
| -rw-r--r-- | clang/lib/CodeGen/CodeGenModule.cpp | 9 | ||||
| -rw-r--r-- | clang/test/CodeGenCXX/PR6747.cpp | 11 | 
3 files changed, 28 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/CGVTables.h b/clang/lib/CodeGen/CGVTables.h index b4262fe224c..bc113ec42fa 100644 --- a/clang/lib/CodeGen/CGVTables.h +++ b/clang/lib/CodeGen/CGVTables.h @@ -295,6 +295,15 @@ public:    CodeGenVTables(CodeGenModule &CGM)      : CGM(CGM) { } +  // isKeyFunctionInAnotherTU - True if this record has a key function and it is +  // in another translation unit. +  static bool isKeyFunctionInAnotherTU(ASTContext &Context, +				       const CXXRecordDecl *RD) { +    assert (RD->isDynamicClass() && "Non dynamic classes have no key."); +    const CXXMethodDecl *KeyFunction = Context.getKeyFunction(RD); +    return KeyFunction && !KeyFunction->getBody(); +  } +    /// needsVTTParameter - Return whether the given global decl needs a VTT    /// parameter, which it does if it's a base constructor or destructor with    /// virtual bases. diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index ab2f1c7aa2e..035e57fd0b2 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -314,7 +314,14 @@ GetLinkageForFunction(ASTContext &Context, const FunctionDecl *FD,    if (FD->getTemplateSpecializationKind()                                          == TSK_ExplicitInstantiationDeclaration)      return CodeGenModule::GVA_C99Inline; -   + +  if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(FD)) { +    const CXXRecordDecl *RD = MD->getParent(); +    if (MD->isVirtual() && +	CodeGenVTables::isKeyFunctionInAnotherTU(Context, RD)) +      return CodeGenModule::GVA_C99Inline; +  }   +    return CodeGenModule::GVA_CXXInline;  } diff --git a/clang/test/CodeGenCXX/PR6747.cpp b/clang/test/CodeGenCXX/PR6747.cpp new file mode 100644 index 00000000000..5a07ce62201 --- /dev/null +++ b/clang/test/CodeGenCXX/PR6747.cpp @@ -0,0 +1,11 @@ +// RUN: %clang_cc1 %s -emit-llvm -o - | FileCheck %s + +struct foo { +  virtual void bar(); +// CHECK: define available_externally void @_ZN3foo3bazEv +  virtual void baz() {} +}; +void zed() { +  foo b; +  b.baz(); +}  | 

