diff options
Diffstat (limited to 'clang')
-rw-r--r-- | clang/lib/Analysis/SimpleConstraintManager.cpp | 13 | ||||
-rw-r--r-- | clang/test/Analysis/misc-ps.m | 13 |
2 files changed, 26 insertions, 0 deletions
diff --git a/clang/lib/Analysis/SimpleConstraintManager.cpp b/clang/lib/Analysis/SimpleConstraintManager.cpp index 82cc0bb7bc2..a4d59bec887 100644 --- a/clang/lib/Analysis/SimpleConstraintManager.cpp +++ b/clang/lib/Analysis/SimpleConstraintManager.cpp @@ -21,6 +21,19 @@ namespace clang { SimpleConstraintManager::~SimpleConstraintManager() {} bool SimpleConstraintManager::canReasonAbout(SVal X) const { + if (nonloc::SymIntConstraintVal *Y = dyn_cast<nonloc::SymIntConstraintVal>(&X)) { + const SymIntConstraint& C = Y->getConstraint(); + switch (C.getOpcode()) { + // We don't reason yet about bitwise-constraints on symbolic values. + case BinaryOperator::And: + case BinaryOperator::Or: + case BinaryOperator::Xor: + return false; + default: + return true; + } + } + return true; } diff --git a/clang/test/Analysis/misc-ps.m b/clang/test/Analysis/misc-ps.m index 20a14f95c21..04e6555dd1b 100644 --- a/clang/test/Analysis/misc-ps.m +++ b/clang/test/Analysis/misc-ps.m @@ -165,3 +165,16 @@ my_test_mm_movepi64_pi64(__a128vector a) { } @end +// PR 3770 +char pr3770(int x) { + int y = x & 0x2; + char *p = 0; + if (y == 1) + p = "hello"; + + if (y == 1) + return p[0]; // no-warning + + return 'a'; +} + |