diff options
Diffstat (limited to 'clang')
-rw-r--r-- | clang/lib/CodeGen/CGDebugInfo.cpp | 13 | ||||
-rw-r--r-- | clang/test/Modules/ExtDebugInfo.cpp | 13 | ||||
-rw-r--r-- | clang/test/Modules/Inputs/DebugCXX.h | 9 | ||||
-rw-r--r-- | clang/test/Modules/ModuleDebugInfo.cpp | 4 |
4 files changed, 27 insertions, 12 deletions
diff --git a/clang/lib/CodeGen/CGDebugInfo.cpp b/clang/lib/CodeGen/CGDebugInfo.cpp index e275f060dfd..e794aeeb169 100644 --- a/clang/lib/CodeGen/CGDebugInfo.cpp +++ b/clang/lib/CodeGen/CGDebugInfo.cpp @@ -1520,13 +1520,12 @@ static bool isDefinedInClangModule(const RecordDecl *RD) { return false; if (!RD->isExternallyVisible() && RD->getName().empty()) return false; - if (auto *CTSD = dyn_cast<ClassTemplateSpecializationDecl>(RD)) { - if (!CTSD->isCompleteDefinition()) - return false; - // Make sure the instantiation is actually in a module. - if (CTSD->field_begin() != CTSD->field_end()) - return CTSD->field_begin()->isFromASTFile(); - } + if (auto *CXXDecl = dyn_cast<CXXRecordDecl>(RD)) + if (CXXDecl->getTemplateSpecializationKind() != TSK_Undeclared) + // Make sure the instantiation is actually in a module. + if (CXXDecl->field_begin() != CXXDecl->field_end()) + return CXXDecl->field_begin()->isFromASTFile(); + return true; } diff --git a/clang/test/Modules/ExtDebugInfo.cpp b/clang/test/Modules/ExtDebugInfo.cpp index 4760737bc4f..dbf79f4ff14 100644 --- a/clang/test/Modules/ExtDebugInfo.cpp +++ b/clang/test/Modules/ExtDebugInfo.cpp @@ -28,6 +28,8 @@ using DebugCXX::Struct; Struct s; DebugCXX::Enum e; + +// Template instantiations. DebugCXX::Template<long> implicitTemplate; DebugCXX::Template<int> explicitTemplate; DebugCXX::FloatInstantiation typedefTemplate; @@ -51,13 +53,16 @@ TypedefFwdDeclTemplate tdfdt; InAnonymousNamespace anon; -// Forward-declared in the module. +// Types that are forward-declared in the module and defined here. struct PureFwdDecl { int i; }; PureFwdDecl definedLocally; struct Specialized<int>::Member { int i; }; struct Specialized<int>::Member definedLocally2; +template <class T> struct FwdDeclTemplateMember<T>::Member { T t; }; +TypedefFwdDeclTemplateMember tdfdtm; + void foo() { anon.i = GlobalStruct.i = GlobalUnion.i = GlobalEnum; } @@ -150,6 +155,12 @@ void foo() { // CHECK-SAME: elements: // CHECK-SAME: identifier: "_ZTSN11SpecializedIiE6MemberE") +// This type is defined locally and forward-declared in the module. +// CHECK: !DICompositeType(tag: DW_TAG_structure_type, name: "Member", +// CHECK-SAME: elements: +// CHECK-SAME: identifier: "_ZTSN21FwdDeclTemplateMemberIiE6MemberE") + + // CHECK: !DIGlobalVariable(name: "anon_enum", {{.*}}, type: ![[ANON_ENUM:[0-9]+]] // CHECK: !DICompositeType(tag: DW_TAG_enumeration_type, scope: ![[NS]], // CHECK-SAME: line: 16 diff --git a/clang/test/Modules/Inputs/DebugCXX.h b/clang/test/Modules/Inputs/DebugCXX.h index 9ae74dc688f..793ad209f8b 100644 --- a/clang/test/Modules/Inputs/DebugCXX.h +++ b/clang/test/Modules/Inputs/DebugCXX.h @@ -97,10 +97,11 @@ template <class T> class FwdDeclTemplate; typedef FwdDeclTemplate<int> TypedefFwdDeclTemplate; // Member classes of class template specializations. -template <typename T> struct Specialized { -}; +template <typename T> struct Specialized {}; -template <> struct Specialized<int> { -struct Member;// { int i; }; +template <> struct Specialized<int> { + struct Member; }; +template <class T> struct FwdDeclTemplateMember { struct Member; }; +typedef FwdDeclTemplateMember<int>::Member TypedefFwdDeclTemplateMember; diff --git a/clang/test/Modules/ModuleDebugInfo.cpp b/clang/test/Modules/ModuleDebugInfo.cpp index 45023736309..998d36327ef 100644 --- a/clang/test/Modules/ModuleDebugInfo.cpp +++ b/clang/test/Modules/ModuleDebugInfo.cpp @@ -130,5 +130,9 @@ // CHECK-SAME: flags: DIFlagFwdDecl // CHECK-SAME: identifier: "_ZTS15FwdDeclTemplateIiE") +// Forward-declared member of a template. +// CHECK: !DICompositeType(tag: DW_TAG_structure_type, name: "Member", +// CHECK-SAME: flags: DIFlagFwdDecl +// CHECK-SAME: identifier: "_ZTSN21FwdDeclTemplateMemberIiE6MemberE") // CHECK-NEG-NOT: !DICompositeType(tag: DW_TAG_structure_type, name: "PureForwardDecl" |